From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd2e.google.com (mail-io1-xd2e.google.com [IPv6:2607:f8b0:4864:20::d2e]) by sourceware.org (Postfix) with ESMTPS id EFE643858C01 for ; Thu, 28 Sep 2023 20:38:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EFE643858C01 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-io1-xd2e.google.com with SMTP id ca18e2360f4ac-79fa425855cso399278139f.2 for ; Thu, 28 Sep 2023 13:38:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1695933496; x=1696538296; darn=gcc.gnu.org; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=8dMiKu2UfywC3kOcJu74AAbyiDNG5FCzxaeeFL7h3XY=; b=Ow8wTuSsXONb8YP0REE7PrS59nGAG1HcYPSx+09AxyF5TcvBVYEFfe1rZKCJEWaKuA oCKhMWKGMYIEW1zfhUyvK3cwvz1KJdRSwmDCNMUeSWp+vtFOM0XtYIwUo9y8GnmRgQvL 3fTxtcETsOisnUwODPby7ErwM3wbzIQOUoWTTRZJ0WZ6B6z394SeRcgAM57Tvbft8m3F VIquLiEoDQwm5srgt+dsKG9+ZEM4fDSHiOyJ6AI3jn7FMswdF3UsHh0gVqPzuw6K4no0 3QFvto1RX+ocJ7U5Ir100jQ+SIbdBGK80U9tKkal0Ys74+bRR5BtRoN1q//deTmeQOAL 49XA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695933496; x=1696538296; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8dMiKu2UfywC3kOcJu74AAbyiDNG5FCzxaeeFL7h3XY=; b=GjwFkLOPO0akJ3iEAsSvytpX/v3+3rrEgogLPAydra3Mge1hXxCyieDktrelWoApVD vbUxAh9KC0pzmZ27cvK+51NDTWl7DlAgl7MXYnj+1xfLQJcbGmCRyntkArVTwH5XK/o9 jwCDAEuzrWb7q7nr8pBpyOl/qtTWktSb3LZiP61Ss94906mOSDp9PXCLR3XUwwWvHaUJ MuR0rJ9nHStF0Tto9vX1M4bMpa5ZDbK7CTgqULihsEQ7MhJAVNbE9E9yECdx1pqIGlkz UAWL6rUS4sZIft5Vj++kldhjM001vQfpyqpZZwUxUkwUxdINsPDsfpYuAgy9Ey/kSvUT dfuA== X-Gm-Message-State: AOJu0Yxle9lqTshUcduGPIAafw6pBhKO30y8lzw7ScbpExVt/xjbtHUV Slm1oGtbUvclpHS4Vi+S8OOirg== X-Google-Smtp-Source: AGHT+IGt+1bQHzJeOAv431LTHE0rIlBggBXTVT7lvNoUfpbUZFxdJjwLjxfEv4AnGoPVtF9l73anVg== X-Received: by 2002:a5d:9cd5:0:b0:794:cdd8:db3c with SMTP id w21-20020a5d9cd5000000b00794cdd8db3cmr2699203iow.17.1695933496250; Thu, 28 Sep 2023 13:38:16 -0700 (PDT) Received: from murgatroyd (71-211-130-31.hlrn.qwest.net. [71.211.130.31]) by smtp.gmail.com with ESMTPSA id y29-20020a02731d000000b0043cfdff8b95sm1082951jab.21.2023.09.28.13.38.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 Sep 2023 13:38:15 -0700 (PDT) From: Tom Tromey To: Jonathan Wakely Cc: Tom Tromey , gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org Subject: Re: [PATCH 2/7] libstdc++: Use gdb.ValuePrinter base class References: <20230928174630.4004388-1-tromey@adacore.com> <20230928174630.4004388-3-tromey@adacore.com> X-Attribution: Tom Date: Thu, 28 Sep 2023 14:38:15 -0600 In-Reply-To: (Jonathan Wakely's message of "Thu, 28 Sep 2023 21:26:47 +0100") Message-ID: <874jje2fuw.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Jonathan> I've pushed the changes I wanted to make, so you'll have to rebase Jonathan> your patches now, sorry. No problem. I rebased & re-tested them. I can send a v2 if you want to double-check (only this large patch required any changes), or just go ahead. Let me know. I may not be able to push until Monday. Tom