From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x12e.google.com (mail-il1-x12e.google.com [IPv6:2607:f8b0:4864:20::12e]) by sourceware.org (Postfix) with ESMTPS id 01D6D3857726 for ; Wed, 27 Sep 2023 17:24:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 01D6D3857726 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-il1-x12e.google.com with SMTP id e9e14a558f8ab-3512740906dso29233695ab.0 for ; Wed, 27 Sep 2023 10:24:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1695835455; x=1696440255; darn=gcc.gnu.org; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=fKr9iD2tfqpdLz77ybUwg5DPp0VAMQvJ4MrJfC6x1ZA=; b=M+Mh6HkbIKi1b4Zlr61Xy9AvYeFgPuA8BGh93vmCMoA8PzdoxPVJltCQr1smbevXje AiFA1EPz09Qr3CGpnPsqzWS7uhEmFlnWngG9SP5dEx1jKLkzq2bxzSfZn4IhIg77kF4O XkBQLN0FG6V8aCY9ZFCMVNPDFWlMsJAPIM2iDb+KVzRnl3XNTi/DKGcU17ub8fs/w2Zx HXOr0po7nzflwbDWa6MyAQAD/ZiBjzRfKsotX69oCc5W1K9evJ9yBu31D1qghgJTNtL+ ghzZKXU9bTz3n2Wx/irFNabW/lguObjAxPU+pjVHaHviNtseQe6dWgsQrs/PGug/K1DD EYkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695835455; x=1696440255; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=fKr9iD2tfqpdLz77ybUwg5DPp0VAMQvJ4MrJfC6x1ZA=; b=f2Nm6vVTppCQwvBsB9FK23obO8ZYaL2RtoyPqPfa/xeWQ9NY8eLrnOP+DnUe4Tn05f 1wysKlxXPvYpCuSO5xydEEDIY0ZRKihndHARUdb1/tSeafaFHSoS14Po9XMM8ofFq4aU H3p65xIdmAtNATbtNFFXXbasK/2q5/XyFzqcvQQHMN0bJ1SdLMS//xSla6N+MK4pK9/Z Y3gg3RkopxBCbE5camOS6rByE6h9sb4lqc5oDQwl5b0anjg6f5QRLIsikPpkNR0wO8Kc yTVQ7CsL/mybgReTG7oiauv2CtDuKQt+eQNLD1LqpWdDMiKxdxMer/eBFJpX8daloj9a Vu9A== X-Gm-Message-State: AOJu0YzOZkCym0z17oubyXHuwE4+PO+AjLbvMOZOnNRZzzDESJmiwuM+ /MU2k2WPdTy+guZCEwDx2lk50RpjlsL4hteNG8iByQ== X-Google-Smtp-Source: AGHT+IE1TMSEhna5bIwc0lb1vSLWaErxOUVgEUWc4jyR58+VF+UD/6A6eqdYBjqDOHE2TLeTxPRw9g== X-Received: by 2002:a05:6e02:d0b:b0:351:b22:af5c with SMTP id g11-20020a056e020d0b00b003510b22af5cmr2371734ilj.32.1695835455230; Wed, 27 Sep 2023 10:24:15 -0700 (PDT) Received: from murgatroyd (71-211-130-31.hlrn.qwest.net. [71.211.130.31]) by smtp.gmail.com with ESMTPSA id l10-20020a056e020dca00b003513332e0e1sm2683061ilj.81.2023.09.27.10.24.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Sep 2023 10:24:14 -0700 (PDT) From: Tom Tromey To: Jonathan Wakely Cc: Tom Tromey , Jonathan Wakely via Gcc-patches , libstdc++@gcc.gnu.org Subject: Re: [committed] libstdc++: Add GDB printers for types References: <20221222233804.772229-1-jwakely@redhat.com> <878r8r4og4.fsf@tromey.com> X-Attribution: Tom Date: Wed, 27 Sep 2023 11:24:13 -0600 In-Reply-To: (Jonathan Wakely's message of "Wed, 27 Sep 2023 17:15:07 +0100") Message-ID: <874jjf4jia.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >> I have fixes for most of the issues that are worth fixing (I didn't >> bother with line lengths -- FWIW in gdb we just run 'black' and don't >> worry about these details), Jonathan> I used autopep8 and committed the result as Jonathan> e08559271b2d797f658579ac8610dbf5e58bcfd8 so the line lengths Jonathan> should be OK now. Yeah, my patches are on top of that, but flake8 still complains, and I still see lines > 79 characters. However maybe flake8 isn't the checker you want to use, or maybe you have something set up for a different line length? Jonathan> So the fix is to just change the string to '{} {}' which I've pushed Jonathan> as 1fab05a885a308c19cf42b72fd36805ddf27fdc8 now (also attached). Thank you. Tom