From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa4.mentor.iphmx.com (esa4.mentor.iphmx.com [68.232.137.252]) by sourceware.org (Postfix) with ESMTPS id 3FD5E3858C83 for ; Thu, 23 Feb 2023 08:11:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3FD5E3858C83 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-IronPort-AV: E=Sophos;i="5.97,320,1669104000"; d="scan'208";a="97939602" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa4.mentor.iphmx.com with ESMTP; 23 Feb 2023 00:11:32 -0800 IronPort-SDR: Wp92o/UeE5Z9/Q43m+O/969DeOapURhnO0Ary7dODbwQGs2GmWqHcmrDjqnb/VvgYjmgj8BQVE 9bD5p2RKpCvvyOCuqEg4OpF70wMxPt32Ys5Z4s4pj67A13K7LiKV0pPUTc90FVSCsqxGs5yECR dGdfqJ27J68CtZdLK4HXNvL5jNa8bfpBvAk0acYLbcDuBASpTHOctthtbpmyNwneFzk2xo+dKc 8ton9n6JtiXHt3h5itm1Fpsj1LuWul2wmA51OXZFBS442bNY4x7s/L1tSXXqFagg5qYwMgWmUG z4s= From: Thomas Schwinge To: Arsen =?utf-8?Q?Arsenovi=C4=87?= CC: Subject: Re: [PATCH 3/7] **/*.texi: Reorder index entries In-Reply-To: <8850cffaffae7e85824576b7761e446df8731115.1674777149.git.arsen@aarsen.me> References: <8850cffaffae7e85824576b7761e446df8731115.1674777149.git.arsen@aarsen.me> User-Agent: Notmuch/0.29.3+94~g74c3f1b (https://notmuchmail.org) Emacs/28.2 (x86_64-pc-linux-gnu) Date: Thu, 23 Feb 2023 09:11:19 +0100 Message-ID: <874jrc94yg.fsf@euler.schwinge.homeip.net> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-11.mgc.mentorg.com (139.181.222.11) To svr-ies-mbx-10.mgc.mentorg.com (139.181.222.10) X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi! On 2023-01-27T01:18:31+0100, Arsen Arsenovi=C4=87 via Gcc-patches wrote: > Much like the previous commit, this change is mostly mechanical I find it helpful to see in the Git commit log some kind of rationale, instead of just the almost-useless GNU ChangeLog snippets. ;-) > with a > simple script. I have, however, gone over the patch myself also, to see > if there's anything that ought to be kept as-is. Assuming that the script is safe to run automatically (no manual intervention necessary), I wonder: should that go into the GCC test suite (say, like 'gcc.src/maintainers.exp') or GCC build process (say, like 'gcc/Makefile.in:s-tm-texi'), to make sure that we're not regressing this again? > Formatter: > > # GPL3+ > use v5.35; > use strict; > use warnings; > > my @lineq =3D (); > my @itemq =3D (); > my @indxq =3D (); > my $lstin =3D 0; > > while (<>) > { > push (@lineq, $_); > if (/^\@[a-zA-Z0-9]{1,2}index\W/) > { > $lstin =3D @lineq; > push (@indxq, $_); > next; > } > if (/^\@itemx?\W/) > { > $lstin =3D @lineq; > push (@itemq, $_); > next; > } > next if $lstin && /^\s*(\@c(omment)?\W.*)?$/; > > if (@indxq and @itemq) > { > print @indxq; > print @itemq; > print @lineq[$lstin..@lineq-1]; > } > else > { > print @lineq; > } > @lineq =3D (); > @itemq =3D (); > @indxq =3D (); > $lstin =3D 0; > } > > if (@indxq and @itemq) > { > print @indxq; > print @itemq; > print @lineq[$lstin..@lineq-1]; > } > else > { > print @lineq; > } > > # Local Variables: > # indent-tabs-mode: nil > # End: Gr=C3=BC=C3=9Fe Thomas > gcc/d/ChangeLog: > > * implement-d.texi: Reorder index entries around @items. > [...] > --- a/gcc/d/implement-d.texi > +++ b/gcc/d/implement-d.texi > @@ -126,11 +126,11 @@ The following attributes are supported on most targ= ets. > > @table @code > > +@cindex @code{alloc_size} function attribute > +@cindex @code{alloc_size} variable attribute > @item @@(gcc.attributes.alloc_size (@var{sizeArgIdx})) > @itemx @@(gcc.attributes.alloc_size (@var{sizeArgIdx}, @var{numArgIdx})) > @itemx @@(gcc.attributes.alloc_size (@var{sizeArgIdx}, @var{numArgIdx}, = @var{zeroBasedNumbering})) > -@cindex @code{alloc_size} function attribute > -@cindex @code{alloc_size} variable attribute > >[...] ----------------- Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstra=C3=9Fe 201= , 80634 M=C3=BCnchen; Gesellschaft mit beschr=C3=A4nkter Haftung; Gesch=C3= =A4ftsf=C3=BChrer: Thomas Heurung, Frank Th=C3=BCrauf; Sitz der Gesellschaf= t: M=C3=BCnchen; Registergericht M=C3=BCnchen, HRB 106955