From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id E15333858D32 for ; Mon, 2 Jan 2023 15:20:31 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1672672831; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Xyz0NM036F2nb8/+AKx+Qw89nJSBL/PVsJj490I+GAI=; b=MVwfmu9OIHgv6MEeBX/KCV6asmMo5sltf6F6KxkQ81jjuZZPVOZpNYK1YbicjkPTgpIEAL VbB0I7jeydRam4/lVKnUuUTus5NXkrQp7jFs+OLxOps+K5Ee55VQHyvosPyVDQE/DdX+59 FkVxp0PRERzwabhO9dSkyYPjIZDUU1I= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-568-KzQKmL1UP728ZBymxGxs_Q-1; Mon, 02 Jan 2023 10:20:15 -0500 X-MC-Unique: KzQKmL1UP728ZBymxGxs_Q-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 27FDB183B3C0; Mon, 2 Jan 2023 15:20:15 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.2.16.30]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7C0E3140EBF5; Mon, 2 Jan 2023 15:20:14 +0000 (UTC) From: Florian Weimer To: Jeff Law Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH 1/3] Compute a table of DWARF register sizes at compile References: Date: Mon, 02 Jan 2023 16:20:13 +0100 In-Reply-To: (Jeff Law's message of "Sun, 20 Nov 2022 08:23:18 -0700") Message-ID: <874jt9netu.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: * Jeff Law: > On 11/8/22 11:05, Florian Weimer via Gcc-patches wrote: >> The sizes are compile-time constants. Create a vector with them, >> so that they can be inspected at compile time. >> >> * gcc/dwarf2cfi.cc (init_return_column_size): Remove. >> (init_one_dwarf_reg_size): Adjust. >> (generate_dwarf_reg_sizes): New function. Extracted >> from expand_builtin_init_dwarf_reg_sizes. >> (expand_builtin_init_dwarf_reg_sizes): Call >> generate_dwarf_reg_sizes. >> * gcc/target.def (init_dwarf_reg_sizes_extra): Adjust >> hook signature. >> * gcc/config/msp430/msp430.cc >> (msp430_init_dwarf_reg_sizes_extra): Adjust. >> * gcc/config/rs6000.cc (rs6000_init_dwarf_reg_sizes_extra): >> Likewise. >> * gcc/doc/tm.texi: Update. > > This series of 3 patches is fine. Thanks, now pushed (after polishing the ChangeLog snippets). Florian