From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa3.mentor.iphmx.com (esa3.mentor.iphmx.com [68.232.137.180]) by sourceware.org (Postfix) with ESMTPS id F41193858020; Tue, 28 Sep 2021 12:30:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org F41193858020 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com IronPort-SDR: 80sO/zCu9SetFiHvdQaxMubbx41H7IH58mwNjqlY6BAy11Cuz4RD+ZhuAoGQf+DMaVEWVL9CDu 3/UV0r5jINIRddKnKqdiDjxmitGWM7s+XepFDJ+nqbDusMTozZL3uEXRoY7JZdt8VWUMnYHfwO jKDjObsvm13FvtodH8EXw/Xod4IdfOm6h9mC9AB7V6CqF0LvmckddGdrvQWMG5dnl1XGcFxaRB 12Hf4e0XfOXzDLP2RNeAU9LZdgPk8rcl2f0IY9h2vkcCjjJo/ShA2zi9qgE+XoufyoOxlNUnQ9 OY2Hu+sa+6e8LlUgBIPqxcax X-IronPort-AV: E=Sophos;i="5.85,329,1624348800"; d="scan'208,223";a="66394753" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa3.mentor.iphmx.com with ESMTP; 28 Sep 2021 04:30:15 -0800 IronPort-SDR: x8FYwvTYyoxp8xmqqp+vZHdmOv2HsA0l2hPE2KO14mDWXHujz7itVaADimfSaJiMuf3GRVEL+U WO0/WQGghZ8Ap6k3k1g8cgZEx9BTD0W94i9VSzNLkVXJuhLIz/clXMew4Vsoa0JPsGy6Dfz1Q3 beWA4FOOBzSB0DGjhIpz69E/ae9jL17njefN6mgZxe1xOvinW1fTA8aVQ9GoCV2kqZSVGY9yMF wHpSCFuISqHEHE+OKl0sWj0ORNqO0i3lUppD99nsssapypbMlOkiBAwtJQoqFqLI7FypiS7nUF lvg= From: Thomas Schwinge To: Tobias Burnus , , CC: Thomas Koenig Subject: Re: [Patch] Fortran: Fix assumed-size to assumed-rank passing [PR94070] In-Reply-To: <89e972fd-fd0c-4269-4598-b025faa7e0ca@codesourcery.com> References: <53d84639-36ea-15e0-fecc-359007294dc0@codesourcery.com> <6413a5ba-4b64-1e47-1800-d4fd7402c16e@netcologne.de> <89e972fd-fd0c-4269-4598-b025faa7e0ca@codesourcery.com> User-Agent: Notmuch/0.29.3+94~g74c3f1b (https://notmuchmail.org) Emacs/27.1 (x86_64-pc-linux-gnu) Date: Tue, 28 Sep 2021 14:30:06 +0200 Message-ID: <874ka4zxv5.fsf@euler.schwinge.homeip.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Sep 2021 12:30:18 -0000 --=-=-= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi! On 2021-09-27T14:07:53+0200, Tobias Burnus wrote: > now committed r12-3897-g00f6de9c69119594f7dad3bd525937c94c8200d0 > Conclusion: Reviews are very helpful :-) Ha! :-) (... and I wasn't even involed here!) ;-P As testing showed here: > --- /dev/null > +++ b/gcc/testsuite/gfortran.dg/assumed_rank_22_aux.c > @@ -0,0 +1,68 @@ > +/* Called by assumed_rank_22.f90. */ > + if (num =3D=3D 0) > + assert (x->dim[2].extent =3D=3D -1); > + else if (num =3D=3D 20) > + assert (x->dim[2].extent =3D=3D 1); > + else if (num =3D=3D 40) > + { > + /* FIXME: - dg-output =3D 'c_assumed ... OK' checked in .f90 file.= */ > + /* assert (x->dim[2].extent =3D=3D 0); */ > + if (x->dim[2].extent =3D=3D 0) > + __builtin_printf ("c_assumed - 40 - OK\n"); > + else > + __builtin_printf ("ERROR: c_assumed num=3D%d: " > + "x->dim[2].extent =3D %d !=3D 0\n", > + num, x->dim[2].extent); > + } > + else if (num =3D=3D 60) > + assert (x->dim[2].extent =3D=3D 2); > + else if (num =3D=3D 80) > + assert (x->dim[2].extent =3D=3D 2); > + else if (num =3D=3D 100) > + { > + /* FIXME: - dg-output =3D 'c_assumed ... OK' checked in .f90 file.= */ > + /* assert (x->dim[2].extent =3D=3D 0); */ > + if (x->dim[2].extent =3D=3D 0) > + __builtin_printf ("c_assumed - 100 - OK\n"); > + else > + __builtin_printf ("ERROR: c_assumed num=3D%d: " > + "x->dim[2].extent =3D %d !=3D 0\n", > + num, x->dim[2].extent); > + } > + else > + assert (0); ... the 'ERROR:' prefixes printed do confuse DejaGnu... As obvious, pushed to master branch commit 95540a6d1d7b29cdd3ed06fbcb07465804504cfd "'gfortran.dg/assumed_rank_22_aux.c' messages printed vs. DejaGnu", see attached. Gr=C3=BC=C3=9Fe Thomas ----------------- Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstra=C3=9Fe 201= , 80634 M=C3=BCnchen; Gesellschaft mit beschr=C3=A4nkter Haftung; Gesch=C3= =A4ftsf=C3=BChrer: Thomas Heurung, Frank Th=C3=BCrauf; Sitz der Gesellschaf= t: M=C3=BCnchen; Registergericht M=C3=BCnchen, HRB 106955 --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename="0001-gfortran.dg-assumed_rank_22_aux.c-messages-printed-v.patch" >From 95540a6d1d7b29cdd3ed06fbcb07465804504cfd Mon Sep 17 00:00:00 2001 From: Thomas Schwinge Date: Tue, 28 Sep 2021 09:02:56 +0200 Subject: [PATCH] 'gfortran.dg/assumed_rank_22_aux.c' messages printed vs. DejaGnu Print lower-case 'error: [...]' instead of upper-case 'ERROR: [...]', to not confuse the DejaGnu log processing harness into thinking these are DejaGnu harness ERRORs: Running /scratch/tschwing/build2-trusty-cs/gcc/build/submit-big/source-gcc/gcc/testsuite/gfortran.dg/dg.exp ... +ERROR: c_assumed num=100: x->dim[2].extent = -1 != 0 +ERROR: c_assumed num=100: x->dim[2].extent = -1 != 0 +ERROR: c_assumed num=100: x->dim[2].extent = -1 != 0 +ERROR: c_assumed num=100: x->dim[2].extent = -1 != 0 +ERROR: c_assumed num=100: x->dim[2].extent = -1 != 0 +ERROR: c_assumed num=100: x->dim[2].extent = -1 != 0 [...] Fix-up for recent commit 00f6de9c69119594f7dad3bd525937c94c8200d0 "Fortran: Fix assumed-size to assumed-rank passing [PR94070]". gcc/testsuite/ * gfortran.dg/assumed_rank_22_aux.c: Adjust messages printed. --- gcc/testsuite/gfortran.dg/assumed_rank_22_aux.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gcc/testsuite/gfortran.dg/assumed_rank_22_aux.c b/gcc/testsuite/gfortran.dg/assumed_rank_22_aux.c index 2fbf83d649a..e5fe02135e9 100644 --- a/gcc/testsuite/gfortran.dg/assumed_rank_22_aux.c +++ b/gcc/testsuite/gfortran.dg/assumed_rank_22_aux.c @@ -29,7 +29,7 @@ c_assumed (CFI_cdesc_t *x, int num) if (x->dim[2].extent == 0) __builtin_printf ("c_assumed - 40 - OK\n"); else - __builtin_printf ("ERROR: c_assumed num=%d: " + __builtin_printf ("error: c_assumed num=%d: " "x->dim[2].extent = %d != 0\n", num, x->dim[2].extent); } @@ -44,7 +44,7 @@ c_assumed (CFI_cdesc_t *x, int num) if (x->dim[2].extent == 0) __builtin_printf ("c_assumed - 100 - OK\n"); else - __builtin_printf ("ERROR: c_assumed num=%d: " + __builtin_printf ("error: c_assumed num=%d: " "x->dim[2].extent = %d != 0\n", num, x->dim[2].extent); } -- 2.33.0 --=-=-=--