From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16943 invoked by alias); 12 May 2017 10:26:05 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 16869 invoked by uid 89); 12 May 2017 10:26:04 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.6 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=goc, renewed, H*r:PDT X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 12 May 2017 10:26:02 +0000 Received: from svr-orw-fem-02x.mgc.mentorg.com ([147.34.96.206] helo=SVR-ORW-FEM-02.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1d97lr-0002e8-Jf from Thomas_Schwinge@mentor.com ; Fri, 12 May 2017 03:26:03 -0700 Received: from tftp-cs (147.34.91.1) by svr-orw-fem-02.mgc.mentorg.com (147.34.96.168) with Microsoft SMTP Server id 14.3.224.2; Fri, 12 May 2017 03:26:03 -0700 Received: by tftp-cs (Postfix, from userid 49978) id C3F9DC231E; Fri, 12 May 2017 03:26:02 -0700 (PDT) From: Thomas Schwinge To: Ian Lance Taylor , gcc-patches , "gofrontend-dev@googlegroups.com" CC: Than McIntosh Subject: Re: Go patches committed: merge recent changes to gofrontend In-Reply-To: References: User-Agent: Notmuch/0.9-125-g4686d11 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Fri, 12 May 2017 10:27:00 -0000 Message-ID: <874lwqz80p.fsf@euler.schwinge.homeip.net> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-SW-Source: 2017-05/txt/msg01010.txt.bz2 Hi! This doesn't block me in any way, but I wanted to report it anyway: On Wed, 10 May 2017 10:26:15 -0700, Ian Lance Taylor wrot= e: > I have committed a large patch to update the Go frontend and libgo to > the recent changes in the gofrontend repository. Doing an incremental rebuild, that ran into: [...]/source-gcc/libgo/go/runtime/heapdump.go:379:14: error: reference = to undefined identifier 'sys.Goexperiment' dumpstr(sys.Goexperiment) ^ make[3]: *** [runtime.lo] Error 1 make[3]: Leaving directory `[...]/build-gcc/x86_64-pc-linux-gnu/libgo' make[2]: *** [all-recursive] Error 1 make[2]: Leaving directory `[...]/build-gcc/x86_64-pc-linux-gnu/libgo' make[1]: *** [all] Error 2 make[1]: Leaving directory `[...]/build-gcc/x86_64-pc-linux-gnu/libgo' make: *** [all-target-libgo] Error 2 Removing "x86_64-pc-linux-gnu/libgo", and rebuilding, it passed. There is: > commit eab2960aee91d3e3a6baa5b1bce01262d24c714f > Author: Ian Lance Taylor > Date: Thu Apr 20 17:08:19 2017 -0700 >=20 > runtime/internal/sys: define Goexperiment >=20 > The gc toolchain defines Goexperiment based on the environment > variable GOEXPERIMENT when the toolchain is built. We just always set > Goexperiment to the empty string. >=20 > Reviewed-on: https://go-review.googlesource.com/41292 | diff --git a/libgo/Makefile.am b/libgo/Makefile.am | index f600a83..f4bf2bc 100644 | --- a/libgo/Makefile.am | +++ b/libgo/Makefile.am |=20 | @@ -512,6 +512,7 @@ | echo "package sys" > version.go.tmp | echo 'const DefaultGoroot =3D "$(prefix)"' >> version.go.tmp | echo 'const TheVersion =3D "'`cat $(srcdir)/VERSION | sed 1q`' '`$(GOC)= --version | sed 1q`'"' >> version.go.tmp | + echo 'const Goexperiment =3D ``' >> version.go.tmp | echo 'const GOARCH =3D "'$(GOARCH)'"' >> version.go.tmp | echo 'const GOOS =3D "'$(GOOS)'"' >> version.go.tmp | echo 'const GccgoToolDir =3D "$(libexecsubdir)"' >> version.go.tmp In the failed build's tree, I do see that the Makefile has been renewed, but the version.go file has not yet been, at the time the build failed. Is there some missing dependency, or should that be implicit? libgo/go/runtime/heapdump.go also is new, and is the only user of sys.Goexperiment, as far as I can tell. Gr=C3=BC=C3=9Fe Thomas