From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 95718 invoked by alias); 22 Nov 2016 21:26:50 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 95701 invoked by uid 89); 22 Nov 2016 21:26:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mail-wj0-f179.google.com Received: from mail-wj0-f179.google.com (HELO mail-wj0-f179.google.com) (209.85.210.179) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 22 Nov 2016 21:26:39 +0000 Received: by mail-wj0-f179.google.com with SMTP id qp4so49174826wjc.3 for ; Tue, 22 Nov 2016 13:26:39 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:mail-followup-to:cc:subject:references :date:in-reply-to:message-id:user-agent:mime-version; bh=yphya8pS26FdjCtbpNntOfyhpkUvULv0WATkiqaxDng=; b=V0F/vxn2fyRj5RNnSD54C6+RdbExz/hyCCLyuWNJLsbPinJ/PtfM69plHOBwkBg2q/ N2QoykNjhiRFj3R4xU9/ZXzzg1oIRqKbyX88/sOmCSwCrtTCC339ifce2MTH8m1dtb5Z T5Iq5RauPd74gPPTjrXqtGa5SJjCgRQhKo3rftLHkg0PkdINqIWOBKteuwyeTWJc+NVy C9G1Z5nHIrOmf57rqBB09VNwP/RYGtsqwMJT5sQnZiN9CuV3mFHjlDiLU92xKOMpZBM8 uozrPJqEuUPIVEUfuk6bcRWFlrp+yeaHoALkXbQUntEfmpCc60dskyMnZvM8Rz6kgegg GqNw== X-Gm-Message-State: AKaTC02P1On5dICGOnjKHQSjxO/idKTfSKuG9zYvCuacSWWWziqlbFi7Hro04jQ0we57Ag== X-Received: by 10.194.125.114 with SMTP id mp18mr233091wjb.106.1479849997774; Tue, 22 Nov 2016 13:26:37 -0800 (PST) Received: from localhost ([2.25.234.124]) by smtp.googlemail.com with ESMTPSA id w8sm4941525wmw.4.2016.11.22.13.26.36 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 22 Nov 2016 13:26:37 -0800 (PST) From: Richard Sandiford To: David Malcolm Mail-Followup-To: David Malcolm ,gcc-patches@gcc.gnu.org, rdsandiford@googlemail.com Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH 6/9] Split class rtx_reader into md_reader vs rtx_reader References: <1478898935-46932-1-git-send-email-dmalcolm@redhat.com> <1478898935-46932-7-git-send-email-dmalcolm@redhat.com> Date: Tue, 22 Nov 2016 21:26:00 -0000 In-Reply-To: <1478898935-46932-7-git-send-email-dmalcolm@redhat.com> (David Malcolm's message of "Fri, 11 Nov 2016 16:15:32 -0500") Message-ID: <874m2zp5o3.fsf@googlemail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2016-11/txt/msg02279.txt.bz2 Sorry, only just realised that this one hadn't been approved as part of the earlier series. David Malcolm writes: > gcc/ChangeLog: > * genpreds.c (write_tm_constrs_h): Update for renaming of > rtx_reader_ptr to md_reader_ptr. > (write_tm_preds_h): Likewise. > (write_insn_preds_c): Likewise. > * read-md.c (rtx_reader_ptr): Rename to... > (md_reader_ptr): ...this, and convert from an > rtx_reader * to a md_reader *. > (rtx_reader::set_md_ptr_loc): Rename to... > (md_reader::set_md_ptr_loc): ...this. > (rtx_reader::get_md_ptr_loc): Rename to... > (md_reader::get_md_ptr_loc): ...this. > (rtx_reader::copy_md_ptr_loc): Rename to... > (md_reader::copy_md_ptr_loc): ...this. > (rtx_reader::fprint_md_ptr_loc): Rename to... > (md_reader::fprint_md_ptr_loc): ...this. > (rtx_reader::print_md_ptr_loc): Rename to... > (md_reader::print_md_ptr_loc): ...this. > (rtx_reader::join_c_conditions): Rename to... > (md_reader::join_c_conditions): ...this. > (rtx_reader::fprint_c_condition): ...this. > (rtx_reader::print_c_condition): Rename to... > (md_reader::print_c_condition): ...this. > (fatal_with_file_and_line): Update for renaming of > rtx_reader_ptr to md_reader_ptr. > (rtx_reader::require_char): Rename to... > (md_reader::require_char): ...this. > (rtx_reader::require_char_ws): Rename to... > (md_reader::require_char_ws): ...this. > (rtx_reader::require_word_ws): Rename to... > (md_reader::require_word_ws): ...this. > (rtx_reader::read_char): Rename to... > (md_reader::read_char): ...this. > (rtx_reader::unread_char): Rename to... > (md_reader::unread_char): ...this. > (rtx_reader::peek_char): Rename to... > (md_reader::peek_char): ...this. > (rtx_reader::read_name): Rename to... > (md_reader::read_name): ...this. > (rtx_reader::read_escape): Rename to... > (md_reader::read_escape): ...this. > (rtx_reader::read_quoted_string): Rename to... > (md_reader::read_quoted_string): ...this. > (rtx_reader::read_braced_string): Rename to... > (md_reader::read_braced_string): ...this. > (rtx_reader::read_string): Rename to... > (md_reader::read_string): ...this. > (rtx_reader::read_skip_construct): Rename to... > (md_reader::read_skip_construct): ...this. > (rtx_reader::handle_constants): Rename to... > (md_reader::handle_constants): ...this. > (rtx_reader::traverse_md_constants): Rename to... > (md_reader::traverse_md_constants): ...this. > (rtx_reader::handle_enum): Rename to... > (md_reader::handle_enum): ...this. > (rtx_reader::lookup_enum_type): Rename to... > (md_reader::lookup_enum_type): ...this. > (rtx_reader::traverse_enum_types): Rename to... > (md_reader::traverse_enum_types): ...this. > (rtx_reader::rtx_reader): Rename to... > (md_reader::md_reader): ...this, and update for renaming of > rtx_reader_ptr to md_reader_ptr. > (rtx_reader::~rtx_reader): Rename to... > (md_reader::~md_reader): ...this, and update for renaming of > rtx_reader_ptr to md_reader_ptr. > (rtx_reader::handle_include): Rename to... > (md_reader::handle_include): ...this. > (rtx_reader::handle_file): Rename to... > (md_reader::handle_file): ...this. > (rtx_reader::handle_toplevel_file): Rename to... > (md_reader::handle_toplevel_file): ...this. > (rtx_reader::get_current_location): Rename to... > (md_reader::get_current_location): ...this. > (rtx_reader::add_include_path): Rename to... > (md_reader::add_include_path): ...this. > (rtx_reader::read_md_files): Rename to... > (md_reader::read_md_files): ...this. > * read-md.h (class rtx_reader): Split into... > (class md_reader): ...new class. > (rtx_reader_ptr): Rename to... > (md_reader_ptr): ...this, and convert to a md_reader *. > (class noop_reader): Update base class to be md_reader. > (class rtx_reader): Reintroduce as a subclass of md_reader. > (rtx_reader_ptr): Reintroduce as a rtx_reader *. > (read_char): Update for renaming of rtx_reader_ptr to > md_reader_ptr. > (unread_char): Likewise. > * read-rtl.c (rtx_reader_ptr): New global. > (rtx_reader::apply_iterator_to_string): Rename to... > (md_reader::apply_iterator_to_string): ...this. > (rtx_reader::copy_rtx_for_iterators): Rename to... > (md_reader::copy_rtx_for_iterators): ...this. > (rtx_reader::read_conditions): Rename to... > (md_reader::read_conditions): ...this. > (rtx_reader::record_potential_iterator_use): Rename to... > (md_reader::record_potential_iterator_use): ...this. > (rtx_reader::read_mapping): Rename to... > (md_reader::read_mapping): ...this. > (rtx_reader::read_rtx): Use rtx_reader_ptr when calling > read_rtx_code. > (rtx_reader::read_rtx_operand): Use get_string_obstack rather > than directly accessing m_string_obstack. > (rtx_reader::rtx_reader): New ctor. > (rtx_reader::~rtx_reader): New dtor. OK, thanks. It'd be nice to split the rtl stuff out of read-md.h at some point, but there's no reason it should happen here. Richard