Re: [PATCH diagnostics/fortran] Handle two locations for the same diagnostic. Convert all gfc_warning_1 and gfc_notify_std_1 calls

[Dodji Seketeli <dodji@redhat.com>]

Manuel López-Ibáñez <lopezibanez@gmail.com> writes:

> On 15 May 2015 at 10:39, Dodji Seketeli <dodji@redhat.com> wrote:
>> Manuel López-Ibáñez <lopezibanez@gmail.com> writes:
>>> -/* Expand the location of this diagnostic. Use this function for consistency. */
>>> +/* Return the location associated to this diagnostic. WHICH specifies
>>
>> Here, I think only the 'W' (in WHICH) should be uppercase.
>
> I'm following the convention that parameter names are uppercase in the
> description of functions.

Oh, okay then.  My bad.  Sorry.

>>>  /* The type of a text to be formatted according a format specification
>>>     along with a list of things.  */
>>>  struct text_info
>>>  {
>>> +public:
>>
>> As this is a struct, the 'public' here is not necessary, as the members
>> are public by default.
>
> I have a very poor memory for such details ;), since we are using
> 'private:' already, does it really hurt to be explicit and use
> 'public:' here?

It doesn't hurt, per se.  But I think it's a very common style to avoid
specifying the 'public' in this case, so I'd rather just remove it, yes.

[...]

OK to commit with this change then.

Cheers,

-- 
		Dodji