From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 123160 invoked by alias); 18 May 2015 07:35:54 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 123151 invoked by uid 89); 18 May 2015 07:35:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 18 May 2015 07:35:52 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t4I7ZoVm016702 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 18 May 2015 03:35:50 -0400 Received: from localhost (ovpn-116-78.ams2.redhat.com [10.36.116.78]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t4I7Znbh028233 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Mon, 18 May 2015 03:35:50 -0400 Received: by localhost (Postfix, from userid 1000) id 9647240C16; Mon, 18 May 2015 09:35:47 +0200 (CEST) From: Dodji Seketeli To: Manuel =?utf-8?B?TMOzcGV6LUliw6HDsWV6?= Cc: Gcc Patch List Subject: Re: [PATCH diagnostics/fortran] Handle two locations for the same diagnostic. Convert all gfc_warning_1 and gfc_notify_std_1 calls References: <86h9rogn3z.fsf@redhat.com> <86mw16utdv.fsf@redhat.com> X-URL: http://www.redhat.com Date: Mon, 18 May 2015 07:35:00 -0000 In-Reply-To: ("Manuel \=\?utf-8\?B\?TMOzcGV6LUliw6HDsWV6Iidz\?\= message of "Fri, 15 May 2015 13:47:24 +0200") Message-ID: <874mnaz6b0.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SW-Source: 2015-05/txt/msg01534.txt.bz2 Manuel L=C3=B3pez-Ib=C3=A1=C3=B1ez writes: > On 15 May 2015 at 10:39, Dodji Seketeli wrote: >> Manuel L=C3=B3pez-Ib=C3=A1=C3=B1ez writes: >>> -/* Expand the location of this diagnostic. Use this function for consi= stency. */ >>> +/* Return the location associated to this diagnostic. WHICH specifies >> >> Here, I think only the 'W' (in WHICH) should be uppercase. > > I'm following the convention that parameter names are uppercase in the > description of functions. Oh, okay then. My bad. Sorry. >>> /* The type of a text to be formatted according a format specification >>> along with a list of things. */ >>> struct text_info >>> { >>> +public: >> >> As this is a struct, the 'public' here is not necessary, as the members >> are public by default. > > I have a very poor memory for such details ;), since we are using > 'private:' already, does it really hurt to be explicit and use > 'public:' here? It doesn't hurt, per se. But I think it's a very common style to avoid specifying the 'public' in this case, so I'd rather just remove it, yes. [...] OK to commit with this change then. Cheers, --=20 Dodji