From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20489 invoked by alias); 13 Feb 2013 17:58:05 -0000 Received: (qmail 20414 invoked by uid 22791); 13 Feb 2013 17:58:04 -0000 X-SWARE-Spam-Status: No, hits=-3.9 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_SPAMHAUS_DROP,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from mail-wi0-f182.google.com (HELO mail-wi0-f182.google.com) (209.85.212.182) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 13 Feb 2013 17:57:48 +0000 Received: by mail-wi0-f182.google.com with SMTP id hi18so1745036wib.9 for ; Wed, 13 Feb 2013 09:57:47 -0800 (PST) X-Received: by 10.180.101.99 with SMTP id ff3mr11861808wib.21.1360778266950; Wed, 13 Feb 2013 09:57:46 -0800 (PST) Received: from localhost ([2.26.176.154]) by mx.google.com with ESMTPS id gy2sm47538479wib.3.2013.02.13.09.57.44 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Wed, 13 Feb 2013 09:57:45 -0800 (PST) From: Richard Sandiford To: Aldy Hernandez Mail-Followup-To: Aldy Hernandez ,Jakub Jelinek , gcc-patches , rdsandiford@googlemail.com Cc: Jakub Jelinek , gcc-patches Subject: Re: PR target/52555: attribute optimize is overriding command line options References: <51198989.7090803@redhat.com> <20130212140503.GD4385@tucnak.redhat.com> <878v6twl42.fsf@talisman.default> <511A7BBF.1030401@redhat.com> <874nhhwhvi.fsf@talisman.default> <511BCFC2.6070601@redhat.com> Date: Wed, 13 Feb 2013 17:58:00 -0000 In-Reply-To: <511BCFC2.6070601@redhat.com> (Aldy Hernandez's message of "Wed, 13 Feb 2013 11:39:14 -0600") Message-ID: <874nhgumeg.fsf@talisman.default> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2013-02/txt/msg00624.txt.bz2 Aldy Hernandez writes: > Richard. > > I made all the changes you suggested. > > I also changed other instances of s/this_target_optabs/this_fn_optabs/ > which I forgot in the previous iteration. And I also changed > save_optabs_if_changed() to use this_fn_optabs, since init_all_optabs() > will generate the optabs into this_fn_optabs. Sorry, just noticed: > + /* If the optabs changed, record it in the node. */ > + if (memcmp (tmp_target_optabs, &default_target_optabs, > + sizeof (struct target_optabs))) This should be this_target_optabs rather than &default_target_optabs. Nothing but target code and initialisers should use &default_target_optabs directly. I don't think that needs a retest though. It only makes a difference on MIPS. Looks good to me otherwise. If there's any fallout on MIPS (hopefully not) I'll fix it up after the commit. Thanks, Richard