From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11830 invoked by alias); 10 Aug 2007 15:22:51 -0000 Received: (qmail 11774 invoked by uid 22791); 10 Aug 2007 15:22:51 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 10 Aug 2007 15:22:45 +0000 Received: (qmail 30996 invoked from network); 10 Aug 2007 15:22:43 -0000 Received: from unknown (HELO gateway) (10.0.0.100) by mail.codesourcery.com with SMTP; 10 Aug 2007 15:22:43 -0000 Received: by gateway (Postfix, from userid 1010) id 1DD276C0CF; Fri, 10 Aug 2007 08:22:43 -0700 (PDT) From: Richard Sandiford To: Sandra Loosemore Mail-Followup-To: Sandra Loosemore ,David Ung , GCC Patches , richard@codesourcery.com Cc: David Ung , GCC Patches Subject: Re: PATCH: MIPS 74K load/store scheduling tweak (take 2) References: <46B3C4C0.8030606@codesourcery.com> <87d4y3da61.fsf@firetop.home> <46B74A75.8070905@mips.com> <87y7gomxb7.fsf@firetop.home> <46BC8131.5090204@codesourcery.com> Date: Fri, 10 Aug 2007 15:22:00 -0000 In-Reply-To: <46BC8131.5090204@codesourcery.com> (Sandra Loosemore's message of "Fri\, 10 Aug 2007 11\:16\:01 -0400") Message-ID: <874pj7ct31.fsf@firetop.home> User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2007-08/txt/msg00670.txt.bz2 Sandra Loosemore writes: > + /* Implement TARGET_SCHED_INIT. */ > + > + static void > + mips_sched_init (FILE *file ATTRIBUTE_UNUSED, int verbose ATTRIBUTE_UNUSED, > + int max_ready ATTRIBUTE_UNUSED) > + { > + if (!reload_completed && TUNE_MACC_CHAINS) > + mips_macc_chains_last_hilo = 0; > + if (reload_completed && TUNE_MIPS4130 && !TARGET_VR4130_ALIGN) > + vr4130_last_insn = 0; > + if (TUNE_74K) > + mips_74k_agen_init (NULL_RTX); > + > + } Excess blank line before "}". Might as well do the initialisations unconditinally; it's one less thing to keep in sync. OK with that change, thanks. No need to retest; if it compiles, it's fine. Richard