ping patches (regressions)

ping patches (regressions)

[Andrew Pinski]

http://gcc.gnu.org/ml/gcc-patches/2004-10/msg00884.html
Gotos in conditional expression don't get a line note

http://gcc.gnu.org/ml/gcc-patches/2004-10/msg00314.html
Fix const-str-[34].m on darwin, the objective-C part has been approved

http://gcc.gnu.org/ml/gcc-patches/2004-10/msg00860.html
labels which have their address taken are removed

http://gcc.gnu.org/ml/gcc-patches/2004-10/msg00843.html
File names are wrong with IMA

http://gcc.gnu.org/ml/gcc-patches/2004-10/msg00800.html
Wrong file name in C++ error

http://gcc.gnu.org/ml/gcc-patches/2004-09/msg02909.html
Objective-C problem, bootstrap problem on x86-solaris

Thanks,
Andrew Pinski

Re: ping patches (regressions)

[Roger Sayle]

On Sun, 17 Oct 2004, Andrew Pinski wrote:
> http://gcc.gnu.org/ml/gcc-patches/2004-10/msg00884.html
> Gotos in conditional expression don't get a line note

This is OK for mainline, provided that you avoid introducing two
consective blank lines in the third hunk (as pointed out by Paolo).

Thanks,

Roger
--

Re: ping patches (regressions)

[Zack Weinberg]

Roger Sayle <roger@eyesopen.com> writes:

> On Sun, 17 Oct 2004, Andrew Pinski wrote:
>> http://gcc.gnu.org/ml/gcc-patches/2004-10/msg00884.html
>> Gotos in conditional expression don't get a line note
>
> This is OK for mainline, provided that you avoid introducing two
> consective blank lines in the third hunk (as pointed out by Paolo).

Also, never put anything else on the same line as a ^L character.

zw

Re: ping patches (regressions)

[Geoffrey Keating]

Andrew Pinski <pinskia@physics.uc.edu> writes:

> http://gcc.gnu.org/ml/gcc-patches/2004-10/msg00314.html
> Fix const-str-[34].m on darwin, the objective-C part has been approved

This is OK.

> http://gcc.gnu.org/ml/gcc-patches/2004-10/msg00860.html
> labels which have their address taken are removed

Is this still necessary?

> http://gcc.gnu.org/ml/gcc-patches/2004-10/msg00843.html
> File names are wrong with IMA

This is OK.

> http://gcc.gnu.org/ml/gcc-patches/2004-10/msg00800.html
> Wrong file name in C++ error

Is this still necessary?  When I tried your testcase, I got:

test.h: In function `int main()':
test.h:3: error: `int t::g' is private
test.cc:8: error: within this context

> http://gcc.gnu.org/ml/gcc-patches/2004-09/msg02909.html
> Objective-C problem, bootstrap problem on x86-solaris

Zem should look at this one.

Re: ping patches (regressions)

[Andrew Pinski]

On Oct 21, 2004, at 11:23 AM, Geoffrey Keating wrote:

>> http://gcc.gnu.org/ml/gcc-patches/2004-10/msg00800.html
>> Wrong file name in C++ error
>
> Is this still necessary?  When I tried your testcase, I got:
>
> test.h: In function `int main()':
> test.h:3: error: `int t::g' is private
> test.cc:8: error: within this context

Note:
> test.h: In function `int main()':

The file name is wrong there there which gives a false
sense of where the function is.

Thanks,
Andrew Pinski

Re: ping patches (regressions)

[Geoff Keating]

[-- Attachment #1: Type: text/plain, Size: 625 bytes --]


On 21/10/2004, at 8:30 AM, Andrew Pinski wrote:

>
> On Oct 21, 2004, at 11:23 AM, Geoffrey Keating wrote:
>
>>> http://gcc.gnu.org/ml/gcc-patches/2004-10/msg00800.html
>>> Wrong file name in C++ error
>>
>> Is this still necessary?  When I tried your testcase, I got:
>>
>> test.h: In function `int main()':
>> test.h:3: error: `int t::g' is private
>> test.cc:8: error: within this context
>
> Note:
>> test.h: In function `int main()':
>
> The file name is wrong there there which gives a false
> sense of where the function is.

Doh!  I read those error messages twice and still didn't see that.

The patch is OK then.


[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 2410 bytes --]

Re: ping patches (regressions)

[Andrew Pinski]

On Oct 21, 2004, at 11:23 AM, Geoffrey Keating wrote:

>> http://gcc.gnu.org/ml/gcc-patches/2004-10/msg00860.html
>> labels which have their address taken are removed
>
> Is this still necessary?

This was already approved and applied.

Thanks,
Andrew Pinski

Re: ping patches (regressions)

[Roger Sayle]

On Mon, 21 Feb 2005, Andrew Pinski wrote:
> http://gcc.gnu.org/ml/gcc-patches/2005-02/msg00657.html
> Fix PR 19937, Fixes binutils miscompiling, forgot to fold_convert a
> value in IV-OPTS.

This is OK for mainline.


> Well that was the only one which I could find right now.
:-)

Roger
--

ping patches (regressions)

[Andrew Pinski]

I am going to ping some important patches which fixes regressions.

http://gcc.gnu.org/ml/gcc-patches/2005-02/msg00657.html
Fix PR 19937, Fixes binutils miscompiling, forgot to fold_convert a
value in IV-OPTS.


Well that was the only one which I could find right now.

-- Pinski