From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17467 invoked by alias); 19 Oct 2003 17:37:29 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 17460 invoked from network); 19 Oct 2003 17:37:29 -0000 Received: from unknown (HELO mail.codesourcery.com) (65.73.237.138) by sources.redhat.com with SMTP; 19 Oct 2003 17:37:29 -0000 Received: (qmail 6897 invoked from network); 19 Oct 2003 17:37:16 -0000 Received: from taltos.codesourcery.com (zack@66.92.218.83) by mail.codesourcery.com with DES-CBC3-SHA encrypted SMTP; 19 Oct 2003 17:37:16 -0000 Received: by taltos.codesourcery.com (sSMTP sendmail emulation); Sun, 19 Oct 2003 10:37:28 -0700 From: "Zack Weinberg" To: Zdenek Dvorak Cc: gcc-patches@gcc.gnu.org Subject: Re: Patch ping References: <20031019101617.GA15107@atrey.karlin.mff.cuni.cz> Date: Sun, 19 Oct 2003 17:39:00 -0000 In-Reply-To: <20031019101617.GA15107@atrey.karlin.mff.cuni.cz> (Zdenek Dvorak's message of "Sun, 19 Oct 2003 12:16:17 +0200") Message-ID: <874qy5ruw7.fsf@egil.codesourcery.com> User-Agent: Gnus/5.1002 (Gnus v5.10.2) Emacs/21.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2003-10/txt/msg01627.txt.bz2 Zdenek Dvorak writes: > Hello, > > could someone please review > > http://gcc.gnu.org/ml/gcc-patches/2003-07/msg02991.html? > > I would like to get this in, since it uses value profiling, and I feel > wrong about having a piece of unused and therefore untested code in gcc. > And of course, it also makes a nice improvement in benchmarks. I don't see anything wrong with the code, but I would like someone more familiar with the profiler to comment. Since this was submitted well before the deadline and only affects a non-default optimization mode, I think it can go in now if (say) Nathan Sidwell thinks the code is sound. You have some English grammar issues with the documentation. zw