public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [C++ Patch] PR 80896 ("[[nodiscard]] is ignored for functions returning references")
@ 2017-05-31 12:04 Paolo Carlini
  2017-05-31 19:03 ` Jason Merrill
  0 siblings, 1 reply; 2+ messages in thread
From: Paolo Carlini @ 2017-05-31 12:04 UTC (permalink / raw)
  To: gcc-patches; +Cc: Jason Merrill

[-- Attachment #1: Type: text/plain, Size: 364 bytes --]

Hi,

this one appears to be a rather simple case of missing diagnostic: in 
convert_to_void we aren't calling maybe_warn_nodiscard when we strip an 
INDIRECT_REF wrapping a CALL_EXPR thus we don't issue the diagnostic 
that we normally provide for plain CALL_EXPRs (eg, for a func returning 
a plain int). Tested x86_64-linux.

Thanks, Paolo.

//////////////////


[-- Attachment #2: CL_80896 --]
[-- Type: text/plain, Size: 299 bytes --]

/cp
2017-05-31  Paolo Carlini  <paolo.carlini@oracle.com>

	PR c++/80896
	* cvt.c (convert_to_void): Possibly call maybe_warn_nodiscard
	for case INDIRECT_REF too in the main switch.

/testsuite
2017-05-31  Paolo Carlini  <paolo.carlini@oracle.com>

	PR c++/80896
	* g++.dg/cpp1z/nodiscard5.C: New.

[-- Attachment #3: patch_80896 --]
[-- Type: text/plain, Size: 905 bytes --]

Index: testsuite/g++.dg/cpp1z/nodiscard5.C
===================================================================
--- testsuite/g++.dg/cpp1z/nodiscard5.C	(revision 0)
+++ testsuite/g++.dg/cpp1z/nodiscard5.C	(working copy)
@@ -0,0 +1,7 @@
+// PR c++/80896
+// { dg-do compile { target c++11 } }
+
+int x = 42;
+[[nodiscard]] int& func() { return x; }
+
+int main() { func(); }  // { dg-warning "ignoring return value" }
Index: cp/cvt.c
===================================================================
--- cp/cvt.c	(revision 248728)
+++ cp/cvt.c	(working copy)
@@ -1296,6 +1296,8 @@ convert_to_void (tree expr, impl_conv_void implici
                 && !is_reference)
               warning_at (loc, OPT_Wunused_value, "value computed is not used");
             expr = TREE_OPERAND (expr, 0);
+	    if (TREE_CODE (expr) == CALL_EXPR)
+	      maybe_warn_nodiscard (expr, implicit);
           }
 
 	break;

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [C++ Patch] PR 80896 ("[[nodiscard]] is ignored for functions returning references")
  2017-05-31 12:04 [C++ Patch] PR 80896 ("[[nodiscard]] is ignored for functions returning references") Paolo Carlini
@ 2017-05-31 19:03 ` Jason Merrill
  0 siblings, 0 replies; 2+ messages in thread
From: Jason Merrill @ 2017-05-31 19:03 UTC (permalink / raw)
  To: Paolo Carlini; +Cc: gcc-patches

OK.

On Wed, May 31, 2017 at 8:04 AM, Paolo Carlini <paolo.carlini@oracle.com> wrote:
> Hi,
>
> this one appears to be a rather simple case of missing diagnostic: in
> convert_to_void we aren't calling maybe_warn_nodiscard when we strip an
> INDIRECT_REF wrapping a CALL_EXPR thus we don't issue the diagnostic that we
> normally provide for plain CALL_EXPRs (eg, for a func returning a plain
> int). Tested x86_64-linux.
>
> Thanks, Paolo.
>
> //////////////////
>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-05-31 18:48 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-31 12:04 [C++ Patch] PR 80896 ("[[nodiscard]] is ignored for functions returning references") Paolo Carlini
2017-05-31 19:03 ` Jason Merrill

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).