From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 56277 invoked by alias); 31 May 2017 12:04:36 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 56257 invoked by uid 89); 31 May 2017 12:04:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-11.1 required=5.0 tests=BAYES_00,GIT_PATCH_2,GIT_PATCH_3,KAM_ASCII_DIVIDERS,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: userp1040.oracle.com Received: from userp1040.oracle.com (HELO userp1040.oracle.com) (156.151.31.81) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 31 May 2017 12:04:34 +0000 Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id v4VC4Z6f026748 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 31 May 2017 12:04:35 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userv0021.oracle.com (8.14.4/8.14.4) with ESMTP id v4VC4YFm009081 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 31 May 2017 12:04:35 GMT Received: from abhmp0003.oracle.com (abhmp0003.oracle.com [141.146.116.9]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id v4VC4YKF023990; Wed, 31 May 2017 12:04:34 GMT Received: from [192.168.1.4] (/79.13.225.104) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 31 May 2017 05:04:34 -0700 To: "gcc-patches@gcc.gnu.org" Cc: Jason Merrill From: Paolo Carlini Subject: [C++ Patch] PR 80896 ("[[nodiscard]] is ignored for functions returning references") Message-ID: <875f093a-0b8f-7ddc-cd46-cece5a24cb2f@oracle.com> Date: Wed, 31 May 2017 12:04:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------------662AFFA354FB5195771E2373" X-IsSubscribed: yes X-SW-Source: 2017-05/txt/msg02345.txt.bz2 This is a multi-part message in MIME format. --------------662AFFA354FB5195771E2373 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-length: 364 Hi, this one appears to be a rather simple case of missing diagnostic: in convert_to_void we aren't calling maybe_warn_nodiscard when we strip an INDIRECT_REF wrapping a CALL_EXPR thus we don't issue the diagnostic that we normally provide for plain CALL_EXPRs (eg, for a func returning a plain int). Tested x86_64-linux. Thanks, Paolo. ////////////////// --------------662AFFA354FB5195771E2373 Content-Type: text/plain; charset=UTF-8; name="CL_80896" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="CL_80896" Content-length: 407 L2NwCjIwMTctMDUtMzEgIFBhb2xvIENhcmxpbmkgIDxwYW9sby5jYXJsaW5p QG9yYWNsZS5jb20+CgoJUFIgYysrLzgwODk2CgkqIGN2dC5jIChjb252ZXJ0 X3RvX3ZvaWQpOiBQb3NzaWJseSBjYWxsIG1heWJlX3dhcm5fbm9kaXNjYXJk Cglmb3IgY2FzZSBJTkRJUkVDVF9SRUYgdG9vIGluIHRoZSBtYWluIHN3aXRj aC4KCi90ZXN0c3VpdGUKMjAxNy0wNS0zMSAgUGFvbG8gQ2FybGluaSAgPHBh b2xvLmNhcmxpbmlAb3JhY2xlLmNvbT4KCglQUiBjKysvODA4OTYKCSogZysr LmRnL2NwcDF6L25vZGlzY2FyZDUuQzogTmV3Lgo= --------------662AFFA354FB5195771E2373 Content-Type: text/plain; charset=UTF-8; name="patch_80896" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="patch_80896" Content-length: 1229 SW5kZXg6IHRlc3RzdWl0ZS9nKysuZGcvY3BwMXovbm9kaXNjYXJkNS5DCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIHRlc3RzdWl0ZS9nKysuZGcvY3Bw MXovbm9kaXNjYXJkNS5DCShyZXZpc2lvbiAwKQorKysgdGVzdHN1aXRlL2cr Ky5kZy9jcHAxei9ub2Rpc2NhcmQ1LkMJKHdvcmtpbmcgY29weSkKQEAgLTAs MCArMSw3IEBACisvLyBQUiBjKysvODA4OTYKKy8vIHsgZGctZG8gY29tcGls ZSB7IHRhcmdldCBjKysxMSB9IH0KKworaW50IHggPSA0MjsKK1tbbm9kaXNj YXJkXV0gaW50JiBmdW5jKCkgeyByZXR1cm4geDsgfQorCitpbnQgbWFpbigp IHsgZnVuYygpOyB9ICAvLyB7IGRnLXdhcm5pbmcgImlnbm9yaW5nIHJldHVy biB2YWx1ZSIgfQpJbmRleDogY3AvY3Z0LmMKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gY3AvY3Z0LmMJKHJldmlzaW9uIDI0ODcyOCkKKysrIGNwL2N2 dC5jCSh3b3JraW5nIGNvcHkpCkBAIC0xMjk2LDYgKzEyOTYsOCBAQCBjb252 ZXJ0X3RvX3ZvaWQgKHRyZWUgZXhwciwgaW1wbF9jb252X3ZvaWQgaW1wbGlj aQogICAgICAgICAgICAgICAgICYmICFpc19yZWZlcmVuY2UpCiAgICAgICAg ICAgICAgIHdhcm5pbmdfYXQgKGxvYywgT1BUX1d1bnVzZWRfdmFsdWUsICJ2 YWx1ZSBjb21wdXRlZCBpcyBub3QgdXNlZCIpOwogICAgICAgICAgICAgZXhw ciA9IFRSRUVfT1BFUkFORCAoZXhwciwgMCk7CisJICAgIGlmIChUUkVFX0NP REUgKGV4cHIpID09IENBTExfRVhQUikKKwkgICAgICBtYXliZV93YXJuX25v ZGlzY2FyZCAoZXhwciwgaW1wbGljaXQpOwogICAgICAgICAgIH0KIAogCWJy ZWFrOwo= --------------662AFFA354FB5195771E2373--