From: "Jose E. Marchesi" <jose.marchesi@oracle.com>
To: David Faust <david.faust@oracle.com>
Cc: gcc-patches@gcc.gnu.org, cupertino.miranda@oracle.com
Subject: Re: [COMMITTED] bpf: add pseudo-c asm dialect for "nop"
Date: Tue, 25 Jul 2023 13:46:28 +0200 [thread overview]
Message-ID: <875y68gqnf.fsf@oracle.com> (raw)
In-Reply-To: <20230724190858.8717-1-david.faust@oracle.com> (David Faust's message of "Mon, 24 Jul 2023 12:08:58 -0700")
> The define_insn "nop" was missing a template for the pseudo-c dialect,
> so the normal syntax was unconditionally emitted.
Thank you.
> Tested on bpf-unknown-none, committed as obvious.
>
> gcc/
>
> * config/bpf/bpf.md (nop): Add pseudo-c asm dialect template.
> ---
> gcc/config/bpf/bpf.md | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gcc/config/bpf/bpf.md b/gcc/config/bpf/bpf.md
> index 3e2d760fbe4..64342ea1de2 100644
> --- a/gcc/config/bpf/bpf.md
> +++ b/gcc/config/bpf/bpf.md
> @@ -103,7 +103,7 @@ (define_mode_attr msuffix [(SI "32") (DI "")])
> (define_insn "nop"
> [(const_int 0)]
> ""
> - "ja\t0"
> + "{ja\t0|goto 0}"
> [(set_attr "type" "alu")])
>
> ;;;; Arithmetic/Logical
prev parent reply other threads:[~2023-07-25 11:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-24 19:08 David Faust
2023-07-25 11:46 ` Jose E. Marchesi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875y68gqnf.fsf@oracle.com \
--to=jose.marchesi@oracle.com \
--cc=cupertino.miranda@oracle.com \
--cc=david.faust@oracle.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).