public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: "Jose E. Marchesi" <jose.marchesi@oracle.com>
To: Cupertino Miranda <cupertino.miranda@oracle.com>
Cc: gcc-patches@gcc.gnu.org, elena.zannoni@oracle.com,
	david.faust@oracle.com
Subject: Re: [PATCH v4] bpf: fixed template for neg (added second operand)
Date: Fri, 21 Jul 2023 20:21:25 +0200	[thread overview]
Message-ID: <875y6d5dne.fsf@oracle.com> (raw)
In-Reply-To: <20230721181954.31073-1-cupertino.miranda@oracle.com> (Cupertino Miranda's message of "Fri, 21 Jul 2023 19:19:54 +0100")


Better with the commit message.
OK.  Thanks.

> This patch fixes define_insn for "neg" to support 2 operands.
> Initial implementation assumed the format "neg %0" while the instruction
> allows both a destination and source operands. The second operand can
> either be a register or an immediate value.
>
> gcc/ChangeLog:
>
> 	* config/bpf/bpf.md: fixed template for neg instruction.
> ---
>  gcc/config/bpf/bpf.md | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/gcc/config/bpf/bpf.md b/gcc/config/bpf/bpf.md
> index 329f62f55c33..adf11e151df1 100644
> --- a/gcc/config/bpf/bpf.md
> +++ b/gcc/config/bpf/bpf.md
> @@ -139,10 +139,10 @@
>  
>  ;;; Negation
>  (define_insn "neg<AM:mode>2"
> -  [(set (match_operand:AM 0 "register_operand" "=r")
> -        (neg:AM (match_operand:AM 1 "register_operand" " 0")))]
> +  [(set (match_operand:AM         0 "register_operand" "=r,r")
> +        (neg:AM (match_operand:AM 1 "register_operand" " r,I")))]
>    ""
> -  "neg<msuffix>\t%0"
> +  "neg<msuffix>\t%0,%1"
>    [(set_attr "type" "<mtype>")])
>  
>  ;;; Multiplication

      reply	other threads:[~2023-07-21 18:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-21 18:19 Cupertino Miranda
2023-07-21 18:21 ` Jose E. Marchesi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875y6d5dne.fsf@oracle.com \
    --to=jose.marchesi@oracle.com \
    --cc=cupertino.miranda@oracle.com \
    --cc=david.faust@oracle.com \
    --cc=elena.zannoni@oracle.com \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).