From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=Z0Dq=5H=gmail.com=gaiusmod2@sourceware.org>
Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f])
	by sourceware.org (Postfix) with ESMTPS id 87E793858CDA
	for <gcc-patches@gcc.gnu.org>; Tue, 10 Jan 2023 16:01:34 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 87E793858CDA
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com
Received: by mail-wm1-x32f.google.com with SMTP id m3so9189757wmq.0
        for <gcc-patches@gcc.gnu.org>; Tue, 10 Jan 2023 08:01:34 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20210112;
        h=mime-version:user-agent:message-id:in-reply-to:date:references
         :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to;
        bh=X7NarPzA/QhWPl/6v3RsG+TNgSgz/hPv2PNz7cNfn84=;
        b=iJK20MCZUhATl6+6fwst98fg7qPm9/p08HI1NMpSBhnvf2O0qzF3QDp5pnjx3tkXjh
         VT2AE9MW7xiSmUvmUZxRYYJ5QVRMRqG+q56qAGBLl7pVY7YKWC+2vtUeRd+BEt13mFyo
         trVvTGlktwuaroMCRIMhGII9Ahq9PoDn2mpeYW84l3qsEpVyKqFrsgyZIDySZqL74+gL
         bYmacIJ2fgEQzlMuuzJjmXsCZf6OINe4wZdhFIyv9WV7SdvhAIm7F0vq/A2LqdbP69hw
         vkdDhxeLxEMDRsmwPkj9whS2/aTex91woa5nrhB+1Uz+Wu5kEo8BsOw6MnUAL+XnY/ru
         jDjA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20210112;
        h=mime-version:user-agent:message-id:in-reply-to:date:references
         :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date
         :message-id:reply-to;
        bh=X7NarPzA/QhWPl/6v3RsG+TNgSgz/hPv2PNz7cNfn84=;
        b=iEdWwMRbnF3tafrCQC0Cnp0/pOmUVGwI+1w9AvdHeDB7QHsfC2ay09SQ3zmX3GfhED
         HFQbOM97YlyOOs09C/IULyoD1WyPemjaO+MfdA5fzDBx9yuZZR/VIXm74N6LwvjpQ2tc
         2kSiCY1JWdW+RE5CaSp/6zaGhQjdBTDQdbOIzbA2xzcmU76FKM872I8udlnOs0NavKLk
         eUNoamzwRK24KTyAciOHpbt7wQu5badIQ9SCPvjxb9Yl8TOg87MAbKKOBCPevkGTXGCf
         8nv+lA7D3z0yR4McgDdqnkPTFgOuGvZOFsEPBooEIJ8kQRZa8TZ+EcSKc3Myqu2SSy7x
         z1QQ==
X-Gm-Message-State: AFqh2krezogRE/04QiuOEQOknnE0nQYJPDS7KD5OlTHnFkV+AxsdtdZy
	ZGWyJ0Y+c5Mqwu66DQ0yzJE=
X-Google-Smtp-Source: AMrXdXt2C5ZQJP0XLIxrzOrVs1F63DrH6mX/7tJUUeJSUmIqADxcGF1H/ORPCXmnq30dyKCEvjU4wg==
X-Received: by 2002:a05:600c:1ca5:b0:3d1:d746:7bca with SMTP id k37-20020a05600c1ca500b003d1d7467bcamr49886156wms.4.1673366492639;
        Tue, 10 Jan 2023 08:01:32 -0800 (PST)
Received: from lancelot ([195.147.220.46])
        by smtp.gmail.com with ESMTPSA id s23-20020a1cf217000000b003d1e3b1624dsm19899084wmc.2.2023.01.10.08.01.32
        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
        Tue, 10 Jan 2023 08:01:32 -0800 (PST)
Received: from gaius by lancelot with local (Exim 4.94.2)
	(envelope-from <gaiusmod2@gmail.com>)
	id 1pFH44-002N1s-P1; Tue, 10 Jan 2023 16:01:28 +0000
From: Gaius Mulley <gaiusmod2@gmail.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: Richard Biener <richard.guenther@gmail.com>,  gcc-patches@gcc.gnu.org
Subject: Re: [PATCH, Modula2] PR-108142 Many empty directories created in
 the build directory
References: <87h6wzf9ci.fsf@debian>
	<CAFiYyc2EkQXFmBAXeJgfUPu_fr8GWrAyD=R8=dJzqAztPdiKAg@mail.gmail.com>
	<Y71B+UbMHKZQIOv7@tucnak>
Date: Tue, 10 Jan 2023 16:01:28 +0000
In-Reply-To: <Y71B+UbMHKZQIOv7@tucnak> (Jakub Jelinek's message of "Tue, 10
	Jan 2023 11:46:17 +0100")
Message-ID: <875ydel6p3.fsf@debian>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Status: No, score=-1.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gcc-patches.gcc.gnu.org>

Jakub Jelinek <jakub@redhat.com> writes:

> On Tue, Jan 10, 2023 at 11:16:28AM +0100, Richard Biener via Gcc-patches wrote:
>> > @@ -424,7 +388,7 @@ override PLUGINCFLAGS := $(filter-out -mdynamic-no-pic,$(PLUGINCFLAGS))
>> >
>> >  plugin/m2rte$(soext): $(srcdir)/m2/plugin/m2rte.cc $(GCC_HEADER_DEPENDENCIES_FOR_M2) \
>> >          insn-attr-common.h insn-flags.h $(generated_files)
>> > -       test -d plugin || mkdir plugin
>> > +       -test -d plugin || $(mkinstalldirs) plugin
>> 
>> I wonder if that's possibly racy (that's why you use mkinstalldirs?)?
>
> Using $(mkinstalldirs) in the patch is what I've suggested because
> previously the patch was using mkdir -p which we almost never use
> (I think only some Ada Makefiles).  Above when it is a single directory
> mkdir is fine.
> 	-test -d $(TESTSUITEDIR) || mkdir $(TESTSUITEDIR)
> etc. is what is used in gcc/Makefile.in in some spots.
> If 2 shells do that test -d plugin || mkdir plugin at the same time,
> then yes, both might do mkdir, but that is why we have the - at the start,
> the error of doing mkdir twice will be ignored then.

thanks both - will apply the patch and close the PR

regards,
Gaius