From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id BC84C3952489 for ; Wed, 7 Dec 2022 15:45:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BC84C3952489 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2B7FJ3gd015634; Wed, 7 Dec 2022 15:45:28 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=references : from : to : cc : subject : in-reply-to : date : message-id : content-type : mime-version; s=corp-2022-7-12; bh=6nKC/DzHqbxCcUVkqZKiasIQwStgDZfQt1gU4FsJlOE=; b=TDENfrbXawAw+kAHdPhAFF2PFzTYRT2BQ/RKwrF5DGOIEOnserCCGxaW8VhotwHAK8xC Bgpc/nj2xxwA3QCqsHvXy8Me5MKUYjONDUdQiW8QpyqW/H7qKwz7WbSrlL+bVoxnEGUi CuAobAnGRjP7tpTKEUZ7YqlDYJW//PDELYnNmy4PuGlRR/+Ab7NLscHOYaFjtKo5h6nl ZRFl3MTvIAnl7itp1utNB1hQhmMOFCQ9tRxMtNPO1heNraJUIJfEL1pDTnS1ndC2H4zm KaPMJFcTL0z0ndnROgZh90kl8/I0zo6OIhPLlSjm+Whz+SXrRcRnoSdpezqOyYle4Dw2 6Q== Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3maujkgffj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 07 Dec 2022 15:45:27 +0000 Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 2B7F0sR9021920; Wed, 7 Dec 2022 15:45:27 GMT Received: from nam12-dm6-obe.outbound.protection.outlook.com (mail-dm6nam12lp2168.outbound.protection.outlook.com [104.47.59.168]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3maa5xw4j1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 07 Dec 2022 15:45:26 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kbwkAS0YCPgYjGLdIlhN7vdtcPefKBsotEUAygryF2QpAXaWQuGlMd4LSAqNxy18pPo03vKB6zqWfZ5J2mwPnoNnzPQiBPDIvay15heXVnI2fkca8D6YspmnXabJzKkqHzAdBFDFYJe6e6HlYq1sLd5PwSpcrXDuuJdDKf3It3F3yjhcK9VvftOVG58Dq1mYw2aCqEQRQUR0Dwhp68vfXrOvZGlyULf1rE4DpbsdcVc0U0cmh3ReXM47GaO6jNc77LKwABMrlV1Vm1yCa6GvgxfcyNwsR+hXkpzWz0AHvj549xDrHoNVNR1ccsSse0FnwksHpJlCVUxj0SG4LBnCig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6nKC/DzHqbxCcUVkqZKiasIQwStgDZfQt1gU4FsJlOE=; b=in9GnxtinowaK3DOaRQL7hHF7oa3gY2Ooi1pvok4tXMTH67pyE5L1qTrFHjKcCvKxseyXcYn+WDqKhPkuEClJ/uZhSvy9lhSN1pU7OG8/plNWxAqtgLKV03DI1BvM2uG6LhY24XaBLsaFuPe2JM+Q5nNr0nKAsf1p93NgFclGf2NRvuCJdgHrwwrfELkU47Urglo3HfepJ+7az7odS7jUiHyeDKdqOq+FS+k6zBq1ifx8MT4s2Trp4/nd0+fxTEmt1GImzfjH8kao2CXJcbNybw1vo9NkszWmC6rFTm73Ob51BMktZaYeg+RdMyetGpzXvUPfK7f7HzMBFcvQ83NJw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6nKC/DzHqbxCcUVkqZKiasIQwStgDZfQt1gU4FsJlOE=; b=rqwsOxAVAEaotI3/Sv4o0xQV621a0TzOv+UzsbkX0CWQ8D/riui71gK9zdE9Qr8TRQRZRz/HaLogk1VmsBSSVp5VYZeHrqdmjNnI7jm8qDjRnlZVfaxci0Gj6cElrAUfh68FwKDoaGAd0545pM5aFJGbpCiUtw7+mm3bdm8PqNM= Received: from BN6PR1001MB2340.namprd10.prod.outlook.com (2603:10b6:405:30::36) by SJ0PR10MB5859.namprd10.prod.outlook.com (2603:10b6:a03:3ef::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.14; Wed, 7 Dec 2022 15:45:24 +0000 Received: from BN6PR1001MB2340.namprd10.prod.outlook.com ([fe80::8681:5931:e558:2638]) by BN6PR1001MB2340.namprd10.prod.outlook.com ([fe80::8681:5931:e558:2638%7]) with mapi id 15.20.5880.014; Wed, 7 Dec 2022 15:45:24 +0000 References: <20221202175225.2780-1-cupertino.miranda@oracle.com> <20221202175225.2780-3-cupertino.miranda@oracle.com> <795fde7f-5bde-d1a5-e790-b15774effd1c@gmail.com> User-agent: mu4e 1.4.15; emacs 28.1 From: Cupertino Miranda To: Jeff Law Cc: gcc-patches@gcc.gnu.org, jose.marchesi@oracle.com Subject: Re: [PATCH 2/2] Corrected pr25521.c target matching. In-reply-to: <795fde7f-5bde-d1a5-e790-b15774effd1c@gmail.com> Date: Wed, 07 Dec 2022 15:45:19 +0000 Message-ID: <875yen5ib4.fsf@oracle.com> Content-Type: text/plain X-ClientProxiedBy: LO4P123CA0281.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:195::16) To BN6PR1001MB2340.namprd10.prod.outlook.com (2603:10b6:405:30::36) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN6PR1001MB2340:EE_|SJ0PR10MB5859:EE_ X-MS-Office365-Filtering-Correlation-Id: 60c39a93-037b-4f7a-a8d5-08dad86a0e54 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YAZzpESeyvrOUf9NahpeVBFzx4eGDYocZYEi9A3bkWcUkwGe/MBontDMCNFKaHLVcnLuDCJGbIfUBjhJC9XbhdUv7+UF8Wz9o6q5Ieuk9WokF7c/GnEzg0igv1BEiisBqgRfygj8OqIUgUoe9sfnI4fbDxgRwPNDVJWB2e4unZohyuF/TU1Hm7B/sBdZvGNn/vHcreWu3E2cn3NWyDvHK0rbzuc3eZXG0fOBKF2uBmEEV3vmUq32EExK0TLBpavnGRmCOOK8f8ioFqA6u67eNnJ5DmO0xtQ+cfyARhxsECyGI32A4cBsdt/c/daCUDAzKaNYUBGV+6ftqkrdxTOtM+WELzXNZUkyur3VAfknqf8RNQIxHFpKpU35CLQr4/y/Yzd2nGtNR0oPN52wGC5UBWVkwZu2bIzuaWsMpMwxgHC7GC8oSuwFm6+txei94J3ijoEDncy6XBB99LBoHoAfKfBLhv2cFiV0H8rPtMTPwqrzEZHQsrlHbdnqtsTfx1ZKClRxN5XCL5Od47K+SzdqKhvoXsxL7keZpsWAUeE0bfTVjKxJvonaJ38hBAEkP8MrFKOQ7DLmj8GFUfDSTHQUM1yonEfSfadwA7svMeMLH0v4nW+Dz6JH12r0qTgm+CDFujlxHYpFWEGSFZzg6qxcYg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN6PR1001MB2340.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(136003)(376002)(39860400002)(346002)(396003)(451199015)(36756003)(86362001)(53546011)(478600001)(6486002)(6506007)(8676002)(8936002)(66556008)(6666004)(107886003)(5660300002)(316002)(6916009)(2906002)(44832011)(66476007)(66946007)(41300700001)(4326008)(38100700002)(186003)(2616005)(6512007)(83380400001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?1JWHUF/QF+BGq99ldXrIRhAFBFfPDd5c0So+9d4dw7OJPZo7eXsvcs2uDrqw?= =?us-ascii?Q?XApjGTzvMnraGivqqxGthXkVS5PwXcoRVG2naFK1kHBe0QLJARMBFAR5tVNW?= =?us-ascii?Q?TOZGqnfI5VgDZGiJpq3JeUxDxL6WgBa6Cig6ufXkUYz2T2R4kiAT8vJ4kUcq?= =?us-ascii?Q?Jppzcg9bCwxoSWVq/LDW2u28C0FkNOQkiFyr3kJGMZvdEo8J0iOLsk7QP6U1?= =?us-ascii?Q?OYyk8XbAhHskLQJs61LoD3ZwvjiyfIzEqrT9rh5dbHHfDA6Ie4fRJsPtu9HO?= =?us-ascii?Q?rzHB758vY1VIh6rY9Aj+oc8kAIa17nt7gJlP2iqNJiv7ECE6TbpHb6jCmOJ8?= =?us-ascii?Q?cvU20bAz4Hjl+wtpFMQyClRJmS21zyLpVcMDcI05qRdi5cmDYNSKUSgB5OI6?= =?us-ascii?Q?bBFNjXs7lddLKp4e2PrpLk8Z1qFy6enXsrcJZKSaSQ+auVzwMeumE3QT31Jk?= =?us-ascii?Q?0+UcpD0K4NhHKjJM6d3fIPF48lfHE0Hh9V59iHtL7pUW2LlZERWMjYU/aAj0?= =?us-ascii?Q?VW0wOr6x/7Y0EmqL2j/ZuWHuIUyPIQ+vCWoqNHkXwuAWuu3qyTFR/pL2ME/+?= =?us-ascii?Q?pcbX2eQT5tZRdXrUkzA9lUOztHS8CNNizml025fH3PAs1JxU7fypjgRAUoKq?= =?us-ascii?Q?29sBGKb3JEZicgqOukhjC+DH+htJIujNzuK6qIp1TkoXnl1YA1MuZo8VLEpq?= =?us-ascii?Q?URzFiyZQqDidXBAvv1E3rgEUEkXTew4FNCm4PmJoLF880un5EQJqaCUm7asT?= =?us-ascii?Q?/uWbynwDqVs0fuwM4zBsSsiLB/PO/v0Uel7yrlQ0ZNpg7IFI1k3KKajwr3z/?= =?us-ascii?Q?O8zAlBjtSHFIxwJUex0qtbgXAhsH3f7+suQFVj3+SR/16n3+9hmq6KShxUfy?= =?us-ascii?Q?t5tgfSsRyTsGM8AUM8QUrDCNDtPLmsdB3a6wjPWB3BgPaKfJ5Wio2bW49Zv+?= =?us-ascii?Q?ft3OpYt6GKzPLySGtPpicrH+IJNU3tvxlVrGywq8JqZpiU6QAIwYRXd648X+?= =?us-ascii?Q?ylhVn6x5a7It2TAaXxtRkEo9AJ9/AXbK6fgIQDAOmruwXfZ1UVg7uPHiZmo6?= =?us-ascii?Q?W9hiPvfBbQ+lAtW/COMq66xdz2nhFEIBreP4Xd8ayxSdQ8q2sMpvUqBt+XRO?= =?us-ascii?Q?/MKp5C1IEfS82xaVdFKsmNteBkrOIV4B8F/fL6KZP/wcn7/IE5TGMSmGZ2xs?= =?us-ascii?Q?UJBKnD7wd01lfg+T0Wap5LI6wJD0ZQjGP3bOuT+4vlAEBwxinxkNXINVtD6i?= =?us-ascii?Q?BzGq0dHuYRs8EJLA8UFwmh8IPbEU92oqvMfP+gKX/vwA1n701is10baTgj4k?= =?us-ascii?Q?BMR+Nl4Hl6bytJ3JvyJWh5lZWq/iKsjK341T2+aqGj2UhV7p65GlrvlhkRRz?= =?us-ascii?Q?ZzuuSCWn//wq7QJaFEWodMbRx8gPc3pTGiCCSXgACy8FZS0RCN1hR2oh5erC?= =?us-ascii?Q?8SO4eCrlCWMq2tjv/I2puBK+Nfj1LLvSTbpsv4Cz1Sr5zr882caboit35wHB?= =?us-ascii?Q?UEmBOjDG7Jct+eCSTsh0ak0qkUhjOqJ/f2BVDsJORCr6IoqIh2739p5TBzpj?= =?us-ascii?Q?rOCzvHteGhaS+FI47ltwXe2M7mEDzN6D8alTT0sJCY0AW2xPH/Gy/Muw7XOa?= =?us-ascii?Q?xoglG8Ki24KkVnwPV3ya0t0=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 60c39a93-037b-4f7a-a8d5-08dad86a0e54 X-MS-Exchange-CrossTenant-AuthSource: BN6PR1001MB2340.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2022 15:45:24.7096 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gtyQ3T45nHvKIN+HjtQlJzaz/QPiojm8JU/QJJon4EcbUfDjrSUDSaUepBr4UEyVmcY+WFiou5pjJJOgmSFi2xk538iQUdzIbzWly9AChFs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR10MB5859 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-12-07_08,2022-12-07_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 adultscore=0 phishscore=0 spamscore=0 bulkscore=0 mlxscore=0 suspectscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000 definitions=main-2212070136 X-Proofpoint-ORIG-GUID: Qe8Ou16KcX-fdV_iFTtSKLjb3PoYlf2T X-Proofpoint-GUID: Qe8Ou16KcX-fdV_iFTtSKLjb3PoYlf2T X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > On 12/2/22 10:52, Cupertino Miranda via Gcc-patches wrote: >> This commit is a follow up of bugzilla #107181. >> The commit /a0aafbc/ changed the default implementation of the >> SELECT_SECTION hook in order to match clang/llvm behaviour w.r.t the >> placement of `const volatile' objects. >> However, the following targets use target-specific selection functions >> and they choke on the testcase pr25521.c: >> *rx - target sets its const variables as '.section C,"a",@progbits'. > That's presumably a constant section. We should instead twiddle the test to > recognize that section. Although @progbits is indeed a constant section, I believe it is more interesting to detect if the `rx' starts selecting more standard sections instead of the current @progbits. That was the reason why I opted to XFAIL instead of PASSing it. Can I keep it as such ? > >> *powerpc - its 32bit version is eager to allocate globals in .sdata >> sections. >> Normally, one can expect for the variable to be allocated in .srodata, >> however, in case of powerpc-*-* or powerpc64-*-* (with -m32) >> 'targetm.have_srodata_section == false' and the code in >> categorize_decl_for_section(varasm.cc), forces it to allocate in .sdata. >> /* If the target uses small data sections, select it. */ >> else if (targetm.in_small_data_p (decl)) >> { >> if (ret == SECCAT_BSS) >> ret = SECCAT_SBSS; >> else if targetm.have_srodata_section && ret == SECCAT_RODATA) >> ret = SECCAT_SRODATA; >> else >> ret = SECCAT_SDATA; >> } > I'd just skip the test for 32bit ppc. There should be suitable effective-target > tests you can use. > > jeff