From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa2.mentor.iphmx.com (esa2.mentor.iphmx.com [68.232.141.98]) by sourceware.org (Postfix) with ESMTPS id 58B103847805 for ; Thu, 20 May 2021 09:52:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 58B103847805 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=Thomas_Schwinge@mentor.com IronPort-SDR: A/OoUjdUuU9JgXskKBhW4ZB7jP5Ns6I53ADJpk31WE5odCMJ5z7V076hH0l2YdaEckneLTJkax YaXMh/rh1JlcPlgMc3rPXUBtinFa6ZeuNTsKeW6PYM1D48IcfXGIMdup6BRuGYrUqhSL2Gvbhl 36+RaoXVMGInKKbX9mlbQkvPe5+8h3i24YXISlod4uTA1jRdmFQJKWZN1uSNN4lPPX20A+iZJU 3tMU1VHOcZ4HKXKoaOxn7UiFZW+2BHt2pq7kjv8wbGIMPA6Pyoq4MZYN0ZTRVieRI51QFIEEBI J5w= X-IronPort-AV: E=Sophos;i="5.82,313,1613462400"; d="scan'208";a="61424020" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa2.mentor.iphmx.com with ESMTP; 20 May 2021 01:52:56 -0800 IronPort-SDR: uP1q2hpGxgZSUXnuZkQKEgpU7Fpthr6QG4+yPJOZNd2sLKobhtl7QqcikJi0eEFhB83Kf+oAPH CyH8D7leAcTIz6o7cZF5ArBwqrFDDBqZgQjbsd04biZQG+szTD9q/GCwy8SX47l/MG4iuv66L9 nEc2jrJNopV02QDK2ihMKMqlCE0GaAgUW84a1WKSHNy/fH0RS5w8yy7/LTJPnAbudl2VH7h6sy ViS5as0Q/O2/D5QlFKGxyMFmyVpg+0afBJ5Mkbr1K4N+WOYYw0sgbtBRVpYISx6gFUhdPu+u64 7nY= From: Thomas Schwinge To: Tom de Vries CC: Alexander Monakov , Jakub Jelinek , Andrew Stubbs , Subject: Re: [PATCH][libgomp, nvptx] Fix hang in gomp_team_barrier_wait_end In-Reply-To: References: <20210420112344.GA7277@delia> <9afc4cec-58de-c941-16d3-a120bd081ce0@suse.de> <0fa1b56e-81e0-ca20-b68a-4578c9dabc84@suse.de> User-Agent: Notmuch/0.29.3+94~g74c3f1b (https://notmuchmail.org) Emacs/27.1 (x86_64-pc-linux-gnu) Date: Thu, 20 May 2021 11:52:46 +0200 Message-ID: <875yzdbukx.fsf@euler.schwinge.homeip.net> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: SVR-IES-MBX-03.mgc.mentorg.com (139.181.222.3) To svr-ies-mbx-01.mgc.mentorg.com (139.181.222.1) X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 May 2021 09:53:01 -0000 Hi Tom! First, thanks for looking into this PR99555! I can't comment on the OpenMP/nvptx changes, so just the following: On 2021-04-23T18:48:01+0200, Tom de Vries wrote: > --- a/libgomp/testsuite/libgomp.fortran/task-detach-6.f90 > +++ b/libgomp/testsuite/libgomp.fortran/task-detach-6.f90 > @@ -1,6 +1,5 @@ > ! { dg-do run } > > -! { dg-additional-sources on_device_arch.c } > ! { dg-prune-output "command-line option '-fintrinsic-modules-path=3D.= *' is valid for Fortran but not for C" } Please remove the 'dg-prune-output', too. ;-) Your changes leave 'libgomp/testsuite/lib/libgomp.exp:check_effective_target_offload_device_nv= ptx', 'libgomp/testsuite/libgomp.c-c++-common/on_device_arch.h', 'libgomp/testsuite/libgomp.fortran/on_device_arch.c' unused. Should we keep those for a potential future use (given that they've been tested to work) or remove (as now unused, danger of bit-rot)? Gr=C3=BC=C3=9Fe Thomas ----------------- Mentor Graphics (Deutschland) GmbH, Arnulfstrasse 201, 80634 M=C3=BCnchen R= egistergericht M=C3=BCnchen HRB 106955, Gesch=C3=A4ftsf=C3=BChrer: Thomas H= eurung, Frank Th=C3=BCrauf