From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13958 invoked by alias); 3 Jan 2018 21:30:42 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 13813 invoked by uid 89); 3 Jan 2018 21:30:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-12.2 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:2021 X-HELO: mail-wm0-f68.google.com Received: from mail-wm0-f68.google.com (HELO mail-wm0-f68.google.com) (74.125.82.68) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 03 Jan 2018 21:30:31 +0000 Received: by mail-wm0-f68.google.com with SMTP id 64so124507wme.3 for ; Wed, 03 Jan 2018 13:30:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:mail-followup-to:cc:subject:references :date:in-reply-to:message-id:user-agent:mime-version; bh=HxkFv5mB7aVrmDIWi7ztKuBhn71DSbMw0XisorXvKh4=; b=Pey3UA1E9GQCyHODt7cWhoF+LqjFBjMfDv1KUSsicW3c71eCYUNJkA5MtIP6hIi+SO xPeNZlBPPn48xZs0/kZAVszBXuhPJkNAuZ7t/mOGBEiqLsVDwCBXPOtLcZvf3SZRDd9E JbceD7P8kA/Rjz8NPFjsrk4veLLobxACHm9567LA+Hi8CQKuOz/N2y4gyWGg35qF5xzi 93lHKQCbOvqBqqLpTRzpN2l1Pdjvz2AAMHdYjcYcSTR2JKH/FpcRTx5+LFTgXmi4Q5Py WfGYt3MlUXbUhVtzSXSZmJAoxWobFsIT0BEjJmKBgmu25mlivP/cxA+inhkQgfLB5Xvv b0UQ== X-Gm-Message-State: AKGB3mL1JwtlAqWvP159ZrfdidajwvpmUe80Dk8vYkhK1lmGhkWoiS23 +TMNWzSB7HLdPaLFAv/6CFia9x4eoSo= X-Google-Smtp-Source: ACJfBoukSrykMZSLPtFFFXNBq3Qas0Au7+nDf/HuiSUweUmUlN7R+50J6bHCYPhlUL7tN8IQTgTnqg== X-Received: by 10.28.220.215 with SMTP id t206mr2340107wmg.75.1515015017705; Wed, 03 Jan 2018 13:30:17 -0800 (PST) Received: from localhost ([95.144.14.233]) by smtp.gmail.com with ESMTPSA id c34sm3941413wra.53.2018.01.03.13.30.16 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 03 Jan 2018 13:30:16 -0800 (PST) From: Richard Sandiford To: Jakub Jelinek Mail-Followup-To: Jakub Jelinek ,gcc-patches@gcc.gnu.org, richard.sandiford@linaro.org Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH] Fix gcc.dg/vect-opt-info-1.c testcase References: <871sltvm7r.fsf@linaro.org> <87bmkxkc7f.fsf@linaro.org> <20180103212326.GO1833@tucnak> Date: Wed, 03 Jan 2018 21:30:00 -0000 In-Reply-To: <20180103212326.GO1833@tucnak> (Jakub Jelinek's message of "Wed, 3 Jan 2018 22:23:26 +0100") Message-ID: <87608ik4uv.fsf@linaro.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-01/txt/msg00181.txt.bz2 Jakub Jelinek writes: > On Mon, Oct 23, 2017 at 06:26:12PM +0100, Richard Sandiford wrote: >> 2017-10-23 Richard Sandiford >> Alan Hayward >> David Sherwood > ... > >> --- /dev/null 2017-10-21 08:51:42.385141415 +0100 >> +++ gcc/testsuite/gcc.dg/vect-opt-info-1.c 2017-10-23 >> 17:22:26.571498977 +0100 >> @@ -0,0 +1,11 @@ >> +/* { dg-options "-std=c99 -fopt-info -O3" } */ >> + >> +void >> +vadd (int *dst, int *op1, int *op2, int count) >> +{ >> + for (int i = 0; i < count; ++i) >> + dst[i] = op1[i] + op2[i]; >> +} >> + >> +/* { dg-message "loop vectorized" "" { target *-*-* } 6 } */ >> +/* { dg-message "loop versioned for vectorization because of possible >> aliasing" "" { target *-*-* } 6 } */ > > This testcase fails e.g. on i686-linux. The problem is > 1) it really should be at least guarded with > /* { dg-do compile { target vect_int } } */ > because on targets that can't vectorize even simple int operations > this will obviously fail Hmm, yeah. > 2) that won't help for i686 though, because we need -msse2 added > to options for it to work; that is normally added by > check_vect_support_and_set_flags > only when in vect.exp. If it was just that target, we could add > dg-additional-options, but I'm afraid many other targets add some options. > > The following works for me, calling it nodump-* ensures that > -fdump-tree-* isn't added, which I believe is essential for the testcase; Yeah, that's right, the bug was using dump_file when dump_enabled_p (), which would segfault when -fopt-info was passed and -fdump-tree-vect* wasn't. > tested on x86_64-linux with > RUNTESTFLAGS='--target_board=unix\{-m32,-m32/-mno-sse,-m64\} vect.exp=nodump*' > ok for trunk? > > Sadly I don't have your broken development version of the patch, so can't > verify it fails with the broken patch. Me neither any more, but it looks good to me FWIW. Thanks, Richard