public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Richard Sandiford <rdsandiford@googlemail.com>
To: Ilya Enkovich <enkovich.gnu@gmail.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH, PR target/65103, 2/3] Propagate address constants into loops for i386
Date: Sun, 15 Mar 2015 20:30:00 -0000	[thread overview]
Message-ID: <8761a22ecm.fsf@googlemail.com> (raw)
In-Reply-To: <20150310150027.GC27860@msticlxl57.ims.intel.com> (Ilya	Enkovich's message of "Tue, 10 Mar 2015 18:00:27 +0300")

Ilya Enkovich <enkovich.gnu@gmail.com> writes:
> This patch allows propagation of loop invariants for i386 if propagated
> value is a constant to be used in address operand.  Bootstrapped and
> tested on x86_64-unknown-linux-gnu.  OK for trunk or stage 1?

Is it necessary for this to be a target hook?  The concept doesn't seem
particularly target-specific.  We should only propagate into the address
if the new cost is no greater than the old cost, but if the address
meets that condition and if propagating at this point in the pipeline is
a win on x86, then wouldn't it be a win for other targets too?

Thanks,
Richard

  parent reply	other threads:[~2015-03-15 20:30 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-10 15:00 Ilya Enkovich
2015-03-10 16:12 ` Ilya Enkovich
2015-03-15 20:30 ` Richard Sandiford [this message]
2015-03-17 19:13   ` Jeff Law
2015-04-14  5:22   ` Jeff Law
2015-04-15 11:07     ` Ilya Enkovich
2015-04-17  8:36       ` Ilya Enkovich
2015-04-21  6:45         ` Jeff Law
2015-05-05 11:05           ` Ilya Enkovich
2015-05-21 13:22             ` Ilya Enkovich
2015-05-28 23:54             ` Jeff Law
2015-06-01 12:26               ` Ilya Enkovich
2015-06-25 14:15                 ` Ilya Enkovich
2015-07-09 20:04                 ` Jeff Law

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8761a22ecm.fsf@googlemail.com \
    --to=rdsandiford@googlemail.com \
    --cc=enkovich.gnu@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).