From: Thomas Schwinge <thomas@codesourcery.com>
To: GCC Patches <gcc-patches@gcc.gnu.org>
Cc: Dominique Dhumieres <dominiq@lps.ens.fr>,
Jan Hubicka <hubicka@ucw.cz>, Andrew Pinski <pinskia@gmail.com>,
Richard Guenther <richard.guenther@gmail.com>,
Jan Hubicka <hubicka@ucw.cz>, <dave.anglin@bell.net>,
<ro@gcc.gnu.org>, <iains@gcc.gnu.org>
Subject: Commit policy? Re: [PATCH 7/7] Plug ipa-prop escape analysis into gimple_call_arg_flags
Date: Tue, 10 Jun 2014 06:48:00 -0000 [thread overview]
Message-ID: <8761k9ntuy.fsf@kepler.schwinge.homeip.net> (raw)
In-Reply-To: <87oayami5b.fsf@kepler.schwinge.homeip.net>
[-- Attachment #1: Type: text/plain, Size: 2941 bytes --]
Hi!
On Tue, 3 Jun 2014 11:55:44 +0200, I wrote:
> Ping -- OK to commit to trunk?
Even though several of those who I'd consider regular GCC developers do
agree with this patch (see also <https://gcc.gnu.org/PR61334>), that is
not enough "consensus" to consider this patch approved, right? Wouldn't
it be a good idea for GCC to move to a more "liberal" policy in this
regard? (That seems to work nicely for glibc.)
Ping.
> On Wed, 28 May 2014 23:55:31 +0200, Jan Hubicka <hubicka@ucw.cz> wrote:
> > > On Mon, 26 May 2014 02:16:35 -0700, Andrew Pinski <pinskia@gmail.com> wrote:
> > > > On Mon, May 26, 2014 at 1:59 AM, Dominique Dhumieres <dominiq@lps.ens.fr> wrote:
> > > > > r210901 breaks bootstrap on targets not supporting strnlen, e.g., darwin10.
> > > > >
> > > > > ../../_clean/gcc/lto-cgraph.c:976:68: error: 'strnlen' was not declared in this scope
> > >
> > > I'm seeing the same on MinGW, which also doesn't have strnlen (which is a
> > > GNU extension).
> > >
> > > > strnlen should be declared in include/libiberty.h if there is no
> > > > declaration as libiberty support is already there. That should be a
> > > > simple fix.
> > >
> > > Like this?
> >
> > This looks good to me (thoguh strnlen is posix). I can not approve the patch
> > but I would preffer it over just hand implementing strnlen there (that is easy,
> > too)
>
> Patch is also considered good by testers in
> <https://gcc.gnu.org/PR61334>.
>
> > > --- gcc/config.in
> > > +++ gcc/config.in
> > > [Regenerate.]
> > > --- gcc/configure
> > > +++ gcc/configure
> > > [Regenerate.]
> > > --- gcc/configure.ac
> > > +++ gcc/configure.ac
> > > @@ -1136,7 +1136,7 @@ CFLAGS="$CFLAGS -I${srcdir} -I${srcdir}/../include $GMPINC"
> > > saved_CXXFLAGS="$CXXFLAGS"
> > > CXXFLAGS="$CXXFLAGS -I${srcdir} -I${srcdir}/../include $GMPINC"
> > > gcc_AC_CHECK_DECLS(getenv atol asprintf sbrk abort atof getcwd getwd \
> > > - strsignal strstr stpcpy strverscmp \
> > > + stpcpy strnlen strsignal strstr strverscmp \
> > > errno snprintf vsnprintf vasprintf malloc realloc calloc \
> > > free basename getopt clock getpagesize ffs gcc_UNLOCKED_FUNCS, , ,[
> > > #include "ansidecl.h"
> > > diff --git include/libiberty.h include/libiberty.h
> > > index 7fd0703..56b8b43 100644
> > > --- include/libiberty.h
> > > +++ include/libiberty.h
> > > @@ -636,6 +636,10 @@ extern int snprintf (char *, size_t, const char *, ...) ATTRIBUTE_PRINTF_3;
> > > extern int vsnprintf (char *, size_t, const char *, va_list) ATTRIBUTE_PRINTF(3,0);
> > > #endif
> > >
> > > +#if defined (HAVE_DECL_STRNLEN) && !HAVE_DECL_STRNLEN
> > > +extern size_t strnlen (const char *, size_t);
> > > +#endif
> > > +
> > > #if defined(HAVE_DECL_STRVERSCMP) && !HAVE_DECL_STRVERSCMP
> > > /* Compare version strings. */
> > > extern int strverscmp (const char *, const char *);
>
>
> Grüße,
> Thomas
[-- Attachment #2: Type: application/pgp-signature, Size: 472 bytes --]
next prev parent reply other threads:[~2014-06-10 6:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-26 9:00 Dominique Dhumieres
2014-05-26 9:16 ` Andrew Pinski
2014-05-26 9:29 ` Christophe Lyon
2014-05-26 16:32 ` Jan Hubicka
2014-05-28 7:26 ` Thomas Schwinge
2014-05-28 21:55 ` Jan Hubicka
2014-06-03 9:56 ` Thomas Schwinge
2014-06-10 6:48 ` Thomas Schwinge [this message]
2014-06-10 6:54 ` Commit policy? " Andrew Pinski
2014-06-10 9:07 ` Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8761k9ntuy.fsf@kepler.schwinge.homeip.net \
--to=thomas@codesourcery.com \
--cc=dave.anglin@bell.net \
--cc=dominiq@lps.ens.fr \
--cc=gcc-patches@gcc.gnu.org \
--cc=hubicka@ucw.cz \
--cc=iains@gcc.gnu.org \
--cc=pinskia@gmail.com \
--cc=richard.guenther@gmail.com \
--cc=ro@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).