public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Richard Sandiford <rsandifo@linux.vnet.ibm.com>
To: vogt@linux.vnet.ibm.com
Cc: gcc-patches@gcc.gnu.org, Andreas Krebbel <krebbel@linux.vnet.ibm.com>
Subject: Re: [PATCH] S390: Fix crash with -mhotpatch and gfortran
Date: Wed, 12 Feb 2014 11:34:00 -0000	[thread overview]
Message-ID: <8761okd0p3.fsf@sandifor-thinkpad.stglab.manchester.uk.ibm.com> (raw)
In-Reply-To: <20140212102838.GA10947@linux.vnet.ibm.com> (Dominik Vogt's	message of "Wed, 12 Feb 2014 11:28:38 +0100")

Dominik Vogt <vogt@linux.vnet.ibm.com> writes:
> diff --git a/gcc/config/s390/s390.c b/gcc/config/s390/s390.c
> index 32a25a4..9ae8ffd 100644
> --- a/gcc/config/s390/s390.c
> +++ b/gcc/config/s390/s390.c
> @@ -5510,9 +5510,8 @@ s390_asm_output_function_label (FILE *asm_out_file, const char *fname,
>        if (hotpatch_trampoline_halfwords >= 0
>  	  && decl_function_context (decl) != NULL_TREE)
>  	{
> -	  warning_at (0, DECL_SOURCE_LOCATION (decl),
> -		      "hotpatch_prologue is not compatible with nested"
> -		      " function");
> +	  warning_at (0, OPT_mhotpatch,
> +		      "hotpatching is not compatible with nested functions");

Looks like this should be:

	  warning_at (DECL_SOURCE_LOCATION (decl), OPT_mhotpatch,
		      "hotpatching is not compatible with nested functions");

Thanks,
Richard

  parent reply	other threads:[~2014-02-12 11:34 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-12 10:28 Dominik Vogt
2014-02-12 10:30 ` [PATCH] (gcc-4.8) " Dominik Vogt
2014-02-13  5:51   ` Dominik Vogt
2014-02-13 12:40     ` Andreas Krebbel
2014-02-12 11:34 ` Richard Sandiford [this message]
2014-02-13  5:48   ` [PATCH] " Dominik Vogt
2014-02-13 12:41     ` Andreas Krebbel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8761okd0p3.fsf@sandifor-thinkpad.stglab.manchester.uk.ibm.com \
    --to=rsandifo@linux.vnet.ibm.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=krebbel@linux.vnet.ibm.com \
    --cc=vogt@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).