From: Jim Meyering <jim@meyering.net>
To: Tom Tromey <tromey@redhat.com>
Cc: gcc-patches@gcc.gnu.org, fortran@gcc.gnu.org
Subject: Re: [PATCH v4] Re: avoid useless if-before-free tests
Date: Mon, 18 Apr 2011 20:43:00 -0000 [thread overview]
Message-ID: <8762qb47ps.fsf@rho.meyering.net> (raw)
In-Reply-To: <m3aafn71v1.fsf@fleche.redhat.com> (Tom Tromey's message of "Mon, 18 Apr 2011 14:15:14 -0600")
Tom Tromey wrote:
>>>>>> "Jim" == Jim Meyering <jim@meyering.net> writes:
>
> Jim> Since v3, I've rebased these and moved the fortran changes to precede
> Jim> these (changing gfc_free to free introduced a few more instances
> Jim> that this transformation deals with). As mentioned before, the
> Jim> conditional-removing transformation was done mechanically with
> Jim> two manual corrections. One to deal with a following "else",
> Jim> and another to restore a conditional that should not have been
> Jim> removed.
>
> I'm not sure if this needs a review (I forgot what happened on the last
> thread) but for avoidance of doubt, the java bits are ok.
Thanks. I wasn't sure either.
I'll presume it's ok and commit tomorrow if no one says otherwise,
since some people actually did review (and spot the invalid
transformation that I've since corrected).
next prev parent reply other threads:[~2011-04-18 20:37 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-05 14:06 Jim Meyering
2011-03-05 19:16 ` Joseph S. Myers
2011-03-07 19:52 ` Dr Andrew John Hughes
2011-03-07 22:47 ` Joseph S. Myers
2011-03-08 16:57 ` Dr Andrew John Hughes
2011-03-08 17:17 ` Jim Meyering
2011-03-08 10:45 ` Jim Meyering
2011-03-08 14:21 ` [PATCH v2] " Jim Meyering
2011-03-08 14:30 ` Rainer Orth
2011-03-08 15:28 ` Ian Lance Taylor
2011-03-08 15:36 ` Jakub Jelinek
2011-03-08 17:03 ` Jim Meyering
2011-03-08 18:45 ` Rainer Orth
2011-03-08 19:13 ` Jim Meyering
2011-03-08 19:20 ` Rainer Orth
2011-03-08 19:39 ` Jakub Jelinek
2011-03-08 17:54 ` [PATCH v3] " Jim Meyering
2011-03-08 19:34 ` DJ Delorie
2011-03-15 9:19 ` Janne Blomqvist
2011-03-15 10:03 ` [PATCH gcc/fortran] get rid of gfc_free Jim Meyering
2011-03-15 10:08 ` Jakub Jelinek
2011-03-15 10:27 ` Jim Meyering
2011-03-15 14:18 ` Janne Blomqvist
2011-03-15 18:21 ` Jim Meyering
2011-03-24 16:51 ` [PATCH v3] Re: avoid useless if-before-free tests Jim Meyering
2011-04-15 7:54 ` Janne Blomqvist
2011-04-15 8:18 ` Jim Meyering
2011-04-15 8:48 ` Janne Blomqvist
2011-04-15 8:56 ` Jim Meyering
2011-04-15 13:23 ` Tom Tromey
2011-04-15 18:12 ` Jim Meyering
2011-04-18 15:33 ` Jim Meyering
2011-04-18 16:32 ` Janne Blomqvist
2011-04-18 16:39 ` Jim Meyering
2011-04-18 19:59 ` Jim Meyering
2011-04-18 20:37 ` [PATCH v4] " Jim Meyering
2011-04-18 20:42 ` Tom Tromey
2011-04-18 20:43 ` Jim Meyering [this message]
2011-04-19 13:00 ` [PATCH v3] " Michael Matz
2011-04-19 16:04 ` Jim Meyering
2011-03-05 19:19 ` Joseph S. Myers
2011-03-07 22:56 ` Paolo Carlini
2011-03-08 16:34 ` Jeff Law
2011-03-09 9:39 ` Richard Guenther
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8762qb47ps.fsf@rho.meyering.net \
--to=jim@meyering.net \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).