From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 6FA1C3858C2D for ; Tue, 14 Nov 2023 22:27:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6FA1C3858C2D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6FA1C3858C2D Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700000836; cv=none; b=eBQaTKVaVNA9GdmGB5XcrAjCiMWgpp7Bi733brzjCmhtibL/qcQtKptOyeJyT6yAI8ug+1wX3Tc7ln4fKBujR2/kvifrWSK0ivSOx3c0eExdmcdK4kS3Uu7zRRCyQbNMzOqwPyxg/TQ2K5U+nCHGexUWTp2SkaHuSYAL5sk4Abc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700000836; c=relaxed/simple; bh=wtQGbD4Kyxnf/Z9kn2csSsORUTmzz1mA3rKrHXDsWpI=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=r5Lr/qbus05TyBI+hnTaSrpSbWVDwdL/lzgAJu8fGQrYYxD4FrBrupg7hbIhg1t4JEWMLus4O3dYKdFS3RTEwWdLg82CVxxAIkIPNCl+t7VcZKvALSIL6FTftsxRNGIY3YxAjq5xKp7hxGG1AarmMEvR2l8AtHClT0/i2y3INBE= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1700000835; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PXgM0oLlO88SiB04fMw7xFjeJ6jN7T9cfaYnddCU1m0=; b=UfIgVOAu9UDI1Rk91on1ETW15SECQNFOgokdb3KZUwHzHiqy61QDTIBIHyKD82+KQHccbZ fQd+NOt6a/+ovBeg0v/2M9kXcVAYR9cWr3kARiTj3WRO8Yp7R5NtJQf5UuULsqg4Ap73iZ 5fMVKU/rg2ENYbs9A9TRh4yqV4e8LGM= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-610-2wXnSHdxMbaw-Fa-dJmtHw-1; Tue, 14 Nov 2023 17:27:11 -0500 X-MC-Unique: 2wXnSHdxMbaw-Fa-dJmtHw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 83D161C0BA48; Tue, 14 Nov 2023 22:27:11 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.2.16.3]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 76E1B371; Tue, 14 Nov 2023 22:27:10 +0000 (UTC) From: Florian Weimer To: Marek Polacek Cc: gcc-patches@gcc.gnu.org, jason@redhat.com, jeffreyalaw@gmail.com, joseph@codesourcery.com, sam@gentoo.org Subject: Re: [PATCH v2 8/8] c: Add new -Wdeclaration-missing-parameter-type permerror References: Date: Tue, 14 Nov 2023 23:27:08 +0100 In-Reply-To: (Marek Polacek's message of "Tue, 14 Nov 2023 15:26:43 -0500") Message-ID: <877cmkug1v.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: * Marek Polacek: > On Tue, Nov 14, 2023 at 06:50:58PM +0100, Florian Weimer wrote: >> --- a/gcc/c-family/c.opt >> +++ b/gcc/c-family/c.opt >> @@ -591,6 +591,10 @@ Wdeclaration-after-statement >> C ObjC Var(warn_declaration_after_statement) Init(-1) Warning >> Warn when a declaration is found after a statement. >> >> +Wdeclaration-missing-parameter-type >> +C ObjC Warning >> +Warn for missing parameter types in function declarations. >> + > > This doesn't have Var(warn_declaration_missing_parameter), so > -fpermissive -Wno-declaration-missing-parameter-type still warns > for > > void foo (i); > > where I think the warning should be suppressed. Is that expected? > It would be nice to have a test for that combination. Okay, I'll send a v3 tomorrow with this change and a test. I had no idea that this was necessary. 8-/ Thanks, Florian