Hi!

On 2023-05-12T10:27:29+0200, I wrote:
> The cleanup is done, now turn ourselves to the changes proper re PR91884
> "libgomp testsuite: (not) using a specific driver for C++, Fortran":
>
> On 2014-11-04T10:31:37-0800, Mike Stump <mikestump@comcast.net> wrote:
>> On Nov 4, 2014, at 4:13 AM, Thomas Schwinge <thomas@codesourcery.com> wrote:
>>> On Wed, 15 Oct 2014 17:46:48 +0200, I wrote:
>>>> No matter whether it's C, C++, or Fortran source code, the libgomp
>>>> testsuite always uses (for build-tree testing) gcc/xgcc, or (for
>>>> installed testing) GCC_UNDER_TEST.  It doesn't make use of
>>>> GXX_UNDER_TEST, GFORTRAN_UNDER_TEST.  To support the latter two
>>>> languages' needs, some -l[...] flags are then added via lang_link_flags.
>>>> For example, for Fortran this is -lgfortran.  This is, however, not what
>>>> would happen if using the gfortran driver to build (which is what a user
>>>> would be doing -- which we should replicate as much as possible at least
>>>> for installed testing): the gfortran driver also adds -lquadmath, if
>>>> applicable.
>>>>
>>>> Now, I wonder why to re-invent all that in the libgomp testsuite, if the
>>>> respective driver already has that knowledge, via spec files, for
>>>> example?  (Also, the regular GCC compiler tests, gcc/testsuite/, are
>>>> doing the right thing.)  Why is libgomp testsuite implemented this way --
>>>> just a legacy of the past, or is there a need for that (that I'm not
>>>> seeing)?
>>>>
>>>> [...]
>>>>
>>>> Am I on the right track with the following?
>>>
>>> Nobody commented, which also means nobody disagreed
>>
>> :-)
>>
>>> OK to commit all that to trunk?
>>
>> Ok, thanks.
>
>> Watch for any review points from the libgomp people, they might trickle a few in.  I don’t mean to cut short any review points from them.
>
> After Tobias in his 2019 "PR testsuite/91884 Add -lquadmath if available"
> again picked up my idea and parts of my 2014 patches (... but in the end
> settled for a "simpler" solution to the problem at hand), my original
> proposal also got an ACK from Rainer,
> <https://inbox.sourceware.org/ydd36g2jc7a.fsf@CeBiTec.Uni-Bielefeld.DE>.
>
>> Also, please watch for breakage.
>
> Always.  :-)
>
>
> First, another "no change in behavior" new patch, loosely based
> on/extracted out of my earlier work.  I'm posting it separately, but
> given that it's in line with my earlier work (just a separate step), I
> intend to push it soon, unless there are any objections, of course.
> "libgomp testsuite: Have each '*.exp' file specify the compiler to use [PR91884]"
> ("..., which is still 'GCC_UNDER_TEST' for all of them"), see attached.

..., and then finally
"libgomp testsuite: As appropriate, use the 'gcc', 'g++', 'gfortran' driver [PR91884]",
see attached.

    ..., that is, 'GCC_UNDER_TEST', 'GXX_UNDER_TEST', 'GFORTRAN_UNDER_TEST' instead
    of 'GCC_UNDER_TEST' for all of them.  No need anymore for 'gcc -lstdc++ -x c++'
    for C++ code, or 'gcc -lgfortran' plus conditional '-lquadmath' for Fortran
    code.  (Getting rid of explicit '-foffload=-lgfortran' is for another day.)


By the way, all changes (individually) tested in a number of different
configurations: '--enable-languages=[...]', native vs. cross, build-tree
vs. installed testing, etc.


Grüße
 Thomas


-----------------
Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955