From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa2.mentor.iphmx.com (esa2.mentor.iphmx.com [68.232.141.98]) by sourceware.org (Postfix) with ESMTPS id 605A53857C45; Sat, 25 Feb 2023 09:12:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 605A53857C45 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-IronPort-AV: E=Sophos;i="5.97,327,1669104000"; d="scan'208";a="99474606" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa2.mentor.iphmx.com with ESMTP; 25 Feb 2023 01:11:58 -0800 IronPort-SDR: JpchJdbvCMUAtLkr1v8shPbircOWuNwoCZmC4nP89tUoXrxOJT1tGxxnJk2d5zYUBQOZrlt/V/ 35v1OSD/0uTrGj24reQQtzLTiQX1B56IHbs8aSdlbmTDmvipejO7BDGorO+re4uP/+ryhUnahA 0Zb+D1ROuofllFCLM0Yo+/6FcOlNCNda1kK2j1WEdAM3bCxKed0TYlscfYiLqUAVXyWVoNAuVa 0a6nuDdQIJuHowP/hvxCcxyCTl7g6eT/Bh4W1kq7RtYJ1gQDwyL1B6akzcozuAjM274bgkdu/3 9ec= From: Thomas Schwinge To: Tobias Burnus CC: , Jakub Jelinek , Subject: Re: [Patch] Fortran/OpenMP: Fix mapping of array descriptors and deferred-length strings In-Reply-To: <57880257-d50f-e72b-5423-932af6c64e92@codesourcery.com> References: <57880257-d50f-e72b-5423-932af6c64e92@codesourcery.com> User-Agent: Notmuch/0.29.3+94~g74c3f1b (https://notmuchmail.org) Emacs/28.2 (x86_64-pc-linux-gnu) Date: Sat, 25 Feb 2023 10:11:48 +0100 Message-ID: <877cw6cdnv.fsf@euler.schwinge.homeip.net> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-10.mgc.mentorg.com (139.181.222.10) To svr-ies-mbx-10.mgc.mentorg.com (139.181.222.10) X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,KAM_SHORT,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Tobias! On 2023-02-23T17:42:08+0100, Tobias Burnus wrote: > (Side note: this patch has been committed to OG12 as http://gcc.gnu.org/g= :55a18d47442 ) I see og12 commit 55a18d4744258e3909568e425f9f473c49f9d13f "Fortran/OpenMP: Fix mapping of array descriptors and deferred-length strin= gs" regress existing test cases as follows: [-PASS:-]{+FAIL:+} gfortran.dg/goacc/finalize-1.f -O scan-tree-dump= -times gimple "(?n)#pragma omp target oacc_exit_data map\\(delete:MEM <[^>]= +> \\[\\(integer\\(kind=3D.\\)\\[0:\\] \\*\\)_[0-9]+\\] \\[len: [^\\]]+\\]\= \) map\\(to:del_f_p \\[pointer set, len: [0-9]+\\]\\) map\\(alloc:del_f_p\\= .data \\[pointer assign, bias: [^\\]]+\\]\\) finalize$" 1 PASS: gfortran.dg/goacc/finalize-1.f -O scan-tree-dump-times gimple= "(?n)#pragma omp target oacc_exit_data map\\(delete:del_f \\[len: [0-9]+\\= ]\\) finalize$" 1 PASS: gfortran.dg/goacc/finalize-1.f -O scan-tree-dump-times gimple= "(?n)#pragma omp target oacc_exit_data map\\(force_from:MEM <[^>]+> \\[\\(= integer\\(kind=3D.\\)\\[0:\\] \\*\\)_[0-9]+\\] \\[len: [^\\]]+\\]\\) map\\(= to:cpo_f_p \\[pointer set, len: [0-9]+\\]\\) map\\(alloc:cpo_f_p\\.data \\[= pointer assign, bias: [^\\]]+\\]\\) finalize$" 1 PASS: gfortran.dg/goacc/finalize-1.f -O scan-tree-dump-times gimple= "(?n)#pragma omp target oacc_exit_data map\\(force_from:cpo_f \\[len: [0-9= ]+\\]\\) finalize$" 1 @@ -54679,7 +54679,7 @@ PASS: gfortran.dg/goacc/finalize-1.f -O sca= n-tree-dump-times gimple "(?n)#pr PASS: gfortran.dg/goacc/finalize-1.f -O scan-tree-dump-times origin= al "(?n)#pragma acc exit data map\\(from:\\*\\(integer\\(kind=3D.\\)\\[0:\\= ] \\*\\) parm\\.1\\.data \\[len: [^\\]]+\\]\\) map\\(to:cpo_f_p \\[pointer = set, len: [0-9]+\\]\\) map\\(alloc:\\(integer\\(kind=3D1\\)\\[0:\\] \\* res= trict\\) cpo_f_p\\.data \\[pointer assign, bias: \\(.*int.*\\) parm\\.1\\.d= ata - \\(.*int.*\\) cpo_f_p\\.data\\]\\) finalize;$" 1 PASS: gfortran.dg/goacc/finalize-1.f -O scan-tree-dump-times origin= al "(?n)#pragma acc exit data map\\(from:cpo_f\\) finalize;$" 1 PASS: gfortran.dg/goacc/finalize-1.f -O scan-tree-dump-times origin= al "(?n)#pragma acc exit data map\\(from:cpo_r\\);$" 1 [-PASS:-]{+FAIL:+} gfortran.dg/goacc/finalize-1.f -O scan-tree-dump= -times original "(?n)#pragma acc exit data map\\(release:\\*\\(integer\\(ki= nd=3D.\\)\\[0:\\] \\*\\) parm\\.0\\.data \\[len: [^\\]]+\\]\\) map\\(to:del= _f_p \\[pointer set, len: [0-9]+\\]\\) map\\(alloc:\\(integer\\(kind=3D1\\)= \\[0:\\] \\* restrict\\) del_f_p\\.data \\[pointer assign, bias: \\(.*int.*= \\) parm\\.0\\.data - \\(.*int.*\\) del_f_p\\.data\\]\\) finalize;$" 1 PASS: gfortran.dg/goacc/finalize-1.f -O scan-tree-dump-times origin= al "(?n)#pragma acc exit data map\\(release:del_f\\) finalize;$" 1 PASS: gfortran.dg/goacc/finalize-1.f -O scan-tree-dump-times origin= al "(?n)#pragma acc exit data map\\(release:del_r\\);$" 1 PASS: gfortran.dg/goacc/finalize-1.f -O (test for excess errors) [-PASS:-]{+FAIL:+} gfortran.dg/gomp/pr78260-2.f90 -O scan-tree-dump= -times original "#pragma omp target data map\\(tofrom:\\*\\(integer\\(kind= =3D4\\)\\[0:\\] \\* restrict\\) __result->data \\[len: D.[0-9]+ \\* 4\\]\\)= map\\(to:\\*__result \\[pointer set, len: ..\\]\\) map\\(alloc:\\(integer\= \(kind=3D4\\)\\[0:\\] \\* restrict\\) __result->data \\[pointer assign, bia= s: 0\\]\\) map\\(alloc:__result \\[pointer assign, bias: 0\\]\\)" 1 [-PASS:-]{+FAIL:+} gfortran.dg/gomp/pr78260-2.f90 -O scan-tree-dump= -times original "#pragma omp target data map\\(tofrom:\\*\\(integer\\(kind= =3D4\\)\\[0:\\] \\* restrict\\) arr.data \\[len: D.[0-9]+ \\* 4\\]\\) map\\= (to:arr \\[pointer set, len: ..\\]\\) map\\(alloc:\\(integer\\(kind=3D4\\)\= \[0:\\] \\* restrict\\) arr.data \\[pointer assign, bias: 0\\]\\)" 1 PASS: gfortran.dg/gomp/pr78260-2.f90 -O scan-tree-dump-times origin= al "#pragma omp target data map\\(tofrom:\\*__result.0\\) map\\(alloc:__res= ult.0 \\[pointer assign, bias: 0\\]\\)" 2 PASS: gfortran.dg/gomp/pr78260-2.f90 -O scan-tree-dump-times origin= al "#pragma omp target data map\\(tofrom:__result_f1\\)" 1 PASS: gfortran.dg/gomp/pr78260-2.f90 -O scan-tree-dump-times origin= al "#pragma omp target update to\\(\\*\\(integer\\(kind=3D4\\)\\[0:\\] \\* = restrict\\) __result->data \\[len: D.[0-9]+ \\* 4\\]\\)" 1 Do to the scan patterns need adjusting, or is something wrong? Gr=C3=BC=C3=9Fe Thomas ----------------- Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstra=C3=9Fe 201= , 80634 M=C3=BCnchen; Gesellschaft mit beschr=C3=A4nkter Haftung; Gesch=C3= =A4ftsf=C3=BChrer: Thomas Heurung, Frank Th=C3=BCrauf; Sitz der Gesellschaf= t: M=C3=BCnchen; Registergericht M=C3=BCnchen, HRB 106955