public inbox for
 help / color / mirror / Atom feed
From: Andreas Schwab <>
To: Tom de Vries via Gcc-patches <>
Cc: Tom de Vries <>
Subject: Re: [PATCH] Add --without-makeinfo
Date: Sun, 09 Oct 2022 19:27:31 +0200	[thread overview]
Message-ID: <877d183o1o.fsf@igel.home> (raw)
In-Reply-To: <20221004152132.GA1906@delia.home> (Tom de Vries via Gcc-patches's message of "Tue, 4 Oct 2022 17:21:33 +0200")

On Okt 04 2022, Tom de Vries via Gcc-patches wrote:

> diff --git a/ b/
> index 0152c69292e..e4a2c076674 100644
> --- a/
> +++ b/
> @@ -3441,6 +3441,9 @@ case " $build_configdirs " in
>  esac
>  AC_CHECK_PROGS([MAKEINFO], makeinfo, [$MISSING makeinfo])
> +if test $with_makeinfo = "no"; then

Quoting is backwards.  You should quote the variable substitution, not
the literal.

Andreas Schwab,
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."

      parent reply	other threads:[~2022-10-09 17:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-04 15:21 Tom de Vries
2022-10-09 17:02 ` Eric Gallager
2022-10-09 17:27 ` Andreas Schwab [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877d183o1o.fsf@igel.home \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).