From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa2.mentor.iphmx.com (esa2.mentor.iphmx.com [68.232.141.98]) by sourceware.org (Postfix) with ESMTPS id DACA5385740E; Wed, 14 Sep 2022 16:20:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DACA5385740E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-IronPort-AV: E=Sophos;i="5.93,315,1654588800"; d="scan'208";a="83065282" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa2.mentor.iphmx.com with ESMTP; 14 Sep 2022 08:20:49 -0800 IronPort-SDR: 5lpQGUFv5JArXzeImcjQDH0KNvyh0tX7Lhoyr0VieuU5/CMMiDELV4fjpvAufSSq0RIpdcaTmN minihFO586m8ZMo4nWEW9KayBSFC/l+LDPI17DwePaeHx8DTXAQV1VNIPA5X260KjiauOrmDv2 L33g0mpEp4kd7xVoe1HCkiHta2ifa0uCpv6H6lTfw8hSxy4XZMGow5XpDIkhVWJcJm4d3yKTxj X0ZRY/GcXPXWL/osBPXQ50WfMlQuq3tQI6LMAQoZ5v0GrqCSCWnsPsWyivVqY2G5SxiKne4BMZ r0I= From: Thomas Schwinge To: Richard Biener , CC: , Subject: Re: [PATCH Rust front-end v2 34/37] gccrs: add lang.opt In-Reply-To: References: <20220824115956.737931-1-philip.herron@embecosm.com> <20220824115956.737931-35-philip.herron@embecosm.com> User-Agent: Notmuch/0.29.3+94~g74c3f1b (https://notmuchmail.org) Emacs/27.1 (x86_64-pc-linux-gnu) Date: Wed, 14 Sep 2022 18:20:43 +0200 Message-ID: <877d26lyg4.fsf@euler.schwinge.homeip.net> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: SVR-IES-MBX-07.mgc.mentorg.com (139.181.222.7) To svr-ies-mbx-10.mgc.mentorg.com (139.181.222.10) X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,KAM_SHORT,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi! On 2022-09-14T15:39:47+0200, Richard Biener via Gcc-patches wrote: > On Wed, Aug 24, 2022 at 2:13 PM wrote: >> >> From: Philip Herron >> >> We have some rust specific langugage options note -fwrapv is enabled by >> default in the code. We are trying to respect options such as >> -Wunused-result which we get by porting over c++ no-discard for rust's >> must-use attribute, so we have enabled these by default directly here. > > LGTM Actually, NACK. ;-) See "gccrs setting warn_unused_variable breaks thousands of non-Rust tests". The 'Init(1)' in 'gcc/rust/lang.opt' are in conflict with any (default) 'Init(0)' in other '*.opt' files -- remember that all '*.opt' files are processed together by GCC's "options machinery", and thus 'gcc/rust/lang.opt' may (and here, does) affect non-Rust front end code. I do have a patch series adding a 'LangInit(@var{language}, @var{value})' option property, and patches to use this in a lot of places (here and in other front ends' '*.opt' files), where currently we implement such logic in '*.cc' files; '[...]_init_options_struct' functions via 'LANG_HOOKS_INIT_OPTIONS_STRUCT' (those then largely become empty and may be removed). I assume this idea to be uncontroversial; I "just" need to get it polished and submitted... Gr=C3=BC=C3=9Fe Thomas >> gcc/rust/lang.opt | 118 ++++++++++++++++++++++++++++++++++++++++++++++ >> 1 file changed, 118 insertions(+) >> create mode 100644 gcc/rust/lang.opt >> >> diff --git a/gcc/rust/lang.opt b/gcc/rust/lang.opt >> new file mode 100644 >> index 00000000000..1f6855ede1d >> --- /dev/null >> +++ b/gcc/rust/lang.opt >> @@ -0,0 +1,118 @@ >> +; Options for the Rust front end. >> +; Copyright (C) 2003-2022 Free Software Foundation, Inc. >> +; >> +; This file is part of GCC. >> +; >> +; GCC is free software; you can redistribute it and/or modify it under >> +; the terms of the GNU General Public License as published by the Free >> +; Software Foundation; either version 3, or (at your option) any later >> +; version. >> +; >> +; GCC is distributed in the hope that it will be useful, but WITHOUT AN= Y >> +; WARRANTY; without even the implied warranty of MERCHANTABILITY or >> +; FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License >> +; for more details. >> +; >> +; You should have received a copy of the GNU General Public License >> +; along with GCC; see the file COPYING3. If not see >> +; . >> + >> +; See the GCC internals manual for a description of this file's format. >> + >> +; Please try to keep this file in ASCII collating order. >> + >> +; Describes command-line options used by this frontend >> + >> +Language >> +Rust >> + >> +I >> +Rust Joined Separate >> +; Documented in c.opt >> + >> +L >> +Rust Joined Separate >> +; Not documented >> + >> +Wall >> +Rust >> +; Documented in c.opt >> + >> +Wunused-variable >> +Rust Var(warn_unused_variable) Init(1) Warning >> +; documented in common.opt >> + >> +Wunused-const-variable >> +Rust Warning Alias(Wunused-const-variable=3D, 2, 0) >> +Warn when a const variable is unused. >> + >> +Wunused-const-variable=3D >> +Rust Joined RejectNegative UInteger Var(warn_unused_const_variable) Ini= t(1) Warning LangEnabledBy(Rust,Wunused-variable, 1, 0) IntegerRange(0, 2) >> +Warn when a const variable is unused. >> + >> +Wunused-result >> +Rust Var(warn_unused_result) Init(1) Warning >> +Warn if a caller of a function, marked with attribute warn_unused_resul= t, does not use its return value. >> + >> +frust-crate=3D >> +Rust Joined RejectNegative >> +-frust-crate=3D Set the crate name for the compilatio= n >> + >> +frust-debug >> +Rust Var(flag_rust_debug) >> +Dump various Rust front end internals. >> + >> +frust-dump- >> +Rust Joined RejectNegative >> +-frust-dump- Dump Rust frontend internal information. >> + >> +frust-max-recursion-depth=3D >> +Rust RejectNegative Type(int) Var(rust_max_recursion_depth) Init(64) >> +-frust-max-recursion-depth=3Dinteger >> + >> +frust-mangling=3D >> +Rust Joined RejectNegative Enum(frust_mangling) Var(flag_rust_mangling) >> +-frust-mangling=3D[legacy|v0] Choose which version to use for name = mangling >> + >> +Enum >> +Name(frust_mangling) Type(int) UnknownError(unknown rust mangling optio= n %qs) >> + >> +EnumValue >> +Enum(frust_mangling) String(legacy) Value(0) >> + >> +EnumValue >> +Enum(frust_mangling) String(v0) Value(1) >> + >> +frust-cfg=3D >> +Rust Joined RejectNegative >> +-frust-cfg=3D Set a config expansion option >> + >> +frust-edition=3D >> +Rust Joined RejectNegative Enum(frust_edition) Var(flag_rust_edition) >> +-frust-edition=3D[2015|2018|2021] Choose which edition to u= se when compiling rust code >> + >> +Enum >> +Name(frust_edition) Type(int) UnknownError(unknown rust edition %qs) >> + >> +EnumValue >> +Enum(frust_edition) String(2015) Value(0) >> + >> +EnumValue >> +Enum(frust_edition) String(2018) Value(1) >> + >> +EnumValue >> +Enum(frust_edition) String(2021) Value(2) >> + >> +frust-embed-metadata >> +Rust Var(flag_rust_embed_metadata) >> +Flag to enable embeding metadata directly into object files >> + >> +frust-metadata-output=3D >> +Rust Joined RejectNegative >> +-frust-metadata-output=3D Path to output crate metadata >> + >> +o >> +Rust Joined Separate >> +; Documented in common.opt >> + >> +; This comment is to ensure we retain the blank line above. >> -- >> 2.25.1 >> ----------------- Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstra=C3=9Fe 201= , 80634 M=C3=BCnchen; Gesellschaft mit beschr=C3=A4nkter Haftung; Gesch=C3= =A4ftsf=C3=BChrer: Thomas Heurung, Frank Th=C3=BCrauf; Sitz der Gesellschaf= t: M=C3=BCnchen; Registergericht M=C3=BCnchen, HRB 106955