From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 74645 invoked by alias); 28 Nov 2019 14:13:39 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 74610 invoked by uid 89); 28 Nov 2019 14:13:38 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-18.1 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_SHORT,SPF_PASS autolearn=ham version=3.3.1 spammy=H*Ad:U*kcy, HX-Languages-Length:2072, Whatever, disturb X-HELO: esa3.mentor.iphmx.com Received: from esa3.mentor.iphmx.com (HELO esa3.mentor.iphmx.com) (68.232.137.180) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 28 Nov 2019 14:13:37 +0000 IronPort-SDR: 9vp/uwaDGntv7hQPYDh0YyAys09SSH64GUdoNc5gkNoCgpNSZZ2pC/y8i7Y3kOnGAF7tBD51yE 3tsXO5rZm1FJ0dLGiwY1w2ozodO71sJNwjCpVgMc4nG3rUtIGFWG5v8nqeRN9KrnkQPMjceFdV VU4Hysuus224vvyonT6duDnos7OXdDoYU7GhVbf57HpqrR0vkVA1/nPI34xbTYuwOO4RB8cTWJ acc0CsLkyqJtRoqZ044Ky8LmqoLAlibth3VnopeyTo3HCgQ1J0s5rqqyTxVpdGSQXsQX4rIXrB lsc= Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa3.mentor.iphmx.com with ESMTP; 28 Nov 2019 06:13:35 -0800 IronPort-SDR: mTU/boarRWcDdfQjFAJLsFqBCblp3sqzr0jBm21rOuIAVSf7Zd6KgKEumzy2s+yd15iaskYS5E hIg43XGc8hvf/wUQf3ovQdr7xVbLGK7RHVtp4bU62Jg2+/7UIlQxlIje1YQSrToWyhf8tnYvhD nwiNvx9RLy9yPOmHY4TR2gg/n2qJLumndcdwZXQAAbcOVtvRa2Sb4ICdEnPG2jX+8giQyBJ4rn Mrv890LmNWuXZ/ka9mazWKmsQULSENy9LyuIljN9JQbPU58+rjW/9EHXN/HS0CuBw6C566sEJF beY= From: Thomas Schwinge To: Julian Brown , Joseph Myers CC: , Richard Biener , Jakub Jelinek , Jeff Law , Kwok Cheung Yeung Subject: Re: Prevent all uses of DFP when unsupported (PR c/91985) In-Reply-To: References: <87a78hm1ku.fsf@euler.schwinge.homeip.net> User-Agent: Notmuch/0.29.1+93~g67ed7df (https://notmuchmail.org) Emacs/26.1 (x86_64-pc-linux-gnu) Date: Thu, 28 Nov 2019 14:22:00 -0000 Message-ID: <877e3km6m5.fsf@euler.schwinge.homeip.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Return-Path: tschwing@mentor.com X-SW-Source: 2019-11/txt/msg02561.txt.bz2 --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-length: 1245 Hi! So, testing just finished, and indeed: On 2019-11-27T22:33:25+0000, Joseph Myers wrote: > On Wed, 27 Nov 2019, Thomas Schwinge wrote: > >> If I turn that conditional cited above into 'if (1)', then nvptx >> offloading testing seems to return to normality, but I have not yet >> assessed whether that has any ill effects on decimal float types support, ... this (see attached) doesn't disturb x86_64-pc-linux-gnu (with nvptx offloading) as well as powerpc64le-unknown-linux-gnu (without offloading) tests in any way. >> and/or how this should be fixed properly. (Julian, please have a look, >> if you can, or tell me if you're busy with other things.) > > Whatever allows this to work for _FloatN types (when x86_64 supports=20 > _Float128 but nxptx doesn't, for example) should be applied to the DFP=20 > types as well. Joseph, Julian, or anyone else, please review if that's (conceptually) the correct fix, and before commit, I'll then remove the 'if' conditional, and re-indent, obviously. If approving this patch (conceptually), please respond with "Reviewed-by: NAME " so that your effort will be recorded in the commit log, see . Gr=C3=BC=C3=9Fe Thomas --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-WIP-Unconditionally-enable-decimal-float-types.trunk.patch Content-Transfer-Encoding: quoted-printable Content-length: 831 =46rom 272dfd2d0bd05ca32a12a3d30ea2871030e5d784 Mon Sep 17 00:00:00 2001 From: Thomas Schwinge Date: Thu, 28 Nov 2019 09:17:57 +0100 Subject: [PATCH] WIP Unconditionally enable decimal float types in 'gcc/tree.c:build_common_tree_nodes' --- gcc/tree.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/tree.c b/gcc/tree.c index 5ae250ee595..d61496518fa 100644 --- a/gcc/tree.c +++ b/gcc/tree.c @@ -10334,7 +10334,7 @@ build_common_tree_nodes (bool signed_char) uint64_type_node =3D make_or_reuse_type (64, 1); =20 /* Decimal float types. */ - if (targetm.decimal_float_supported_p ()) + if (1 || targetm.decimal_float_supported_p ()) { dfloat32_type_node =3D make_node (REAL_TYPE); TYPE_PRECISION (dfloat32_type_node) =3D DECIMAL32_TYPE_SIZE; --=20 2.17.1 --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" Content-length: 658 -----BEGIN PGP SIGNATURE----- iQGzBAEBCgAdFiEEU9WEfWKGQazCmycCAKI7+41Q4XkFAl3f1gIACgkQAKI7+41Q 4XmkmgwA40V3lxQeUM1ne2blVdJsdD1x+ikr+CUfWhKvgMIMVPNTNBpUwPkeWJgY LyQCl70RSpo60p2Kumny/GDijK7jvxy7qT8tKaMEa+pxs491mYUC7lA9xWI9gbyu cD85yl/I91OlneKROZVxDUCbm5Vv/PttQLtrfYxxUmqXgIn2Tjd9IIZ2rylmmxFw DaofXpbWTsO4W8wyKH5USmx4xMAXl42qcrsT09yKNicVzWYYGdWBFgxWhEUJbexc I0zgaKjjxk4FTEB2US6UdoeXywsSTrHtgMUP7AdU5j49L5r2/tKpJ0s93WW4ZmO4 1JuI8TT7PtOip1QhQVwNtF+7oy2M3kvjP94Gnk5Qii96irniNGzuwFJ6eYd+Ceik mVGDtEXUClMklsNy8ryEqMsfOuh2zM1OIiRp/acGuaUoep9hehWMo0iPnk4twU8b nsuhcEn3iLDHtJ/zdWXm34H6lmje+GUwB/ILCHOIAZFZwKMzbUGxk2dRNIYX9V8r mdA2Zbm1 =pkxA -----END PGP SIGNATURE----- --==-=-=--