Re: [PATCH, testsuite] Fix PR68629: attr-simd-3.c failure on arm-none-eabi targets

[Thomas Schwinge <thomas@codesourcery.com>]

[-- Attachment #1: Type: text/plain, Size: 2407 bytes --]

Hi!

On Wed, 9 Dec 2015 17:56:13 +0800, "Thomas Preud'homme" <thomas.preudhomme@arm.com> wrote:
> c-c++-common/attr-simd-3.c fails to compile on arm-none-eabi targets due to -fcilkplus needing -pthread which is not available for those targets. This patch solves this issue by adding a condition to the cilkplus effective target that compiling with -fcilkplus succeeds and requires cilkplus as an effective target for attr-simd-3.c testcase.

>         PR testsuite/68629
>         * lib/target-supports.exp (check_effective_target_cilkplus): Also
>         check that compiling with -fcilkplus does not give an error.
>         * c-c++-common/attr-simd-3.c: Require cilkplus effective target.

> --- a/gcc/testsuite/lib/target-supports.exp
> +++ b/gcc/testsuite/lib/target-supports.exp
> @@ -1432,7 +1432,12 @@ proc check_effective_target_cilkplus { } {
>      if { [istarget avr-*-*] } {
>  	return 0;
>      }
> -    return 1
> +    return [ check_no_compiler_messages_nocache fcilkplus_available executable {
> +	#ifdef __cplusplus
> +	extern "C"
> +	#endif
> +	    int dummy;
> +	} "-fcilkplus" ]
>  }
>  
>  proc check_linker_plugin_available { } {
> 
> 
> Testsuite shows no regression when run with
>   + an arm-none-eabi GCC cross-compiler targeting Cortex-M3
>   + a bootstrapped x86_64-linux-gnu GCC native compiler

With this committed in r231605, I now see all gcc/testsuite/ Cilk+
testing disappear for "configure && make && make check", because of:

    Executing on host: [...]/build-gcc/gcc/xgcc -B[...]/build-gcc/gcc/ fcilkplus_available14337.c  -fno-diagnostics-show-caret -fdiagnostics-color=never  -fcilkplus  -lm    -o fcilkplus_available14337.exe    (timeout = 300)
    spawn [...]/build-gcc/gcc/xgcc -B[...]/build-gcc/gcc/ fcilkplus_available14337.c -fno-diagnostics-show-caret -fdiagnostics-color=never -fcilkplus -lm -o fcilkplus_available14337.exe
    xgcc: error: libcilkrts.spec: No such file or directory
    compiler exited with status 1

Can you confirm that in your build/test tree, the compiler is picking up
the build-tree libcilkrts, and not the one from /usr/lib/ (or similar)?

Long ago, in r208889, a similar problem has been diagnosed and fixed by
Rainer and Tobias (CCed just in case),
<http://news.gmane.org/find-root.php?message_id=%3C53336904.5010003%40net-b.de%3E>,
so I wonder what broke now?


Grüße
 Thomas

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 472 bytes --]