From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 42946 invoked by alias); 21 Sep 2015 19:32:43 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 42932 invoked by uid 89); 21 Sep 2015 19:32:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-wi0-f180.google.com Received: from mail-wi0-f180.google.com (HELO mail-wi0-f180.google.com) (209.85.212.180) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Mon, 21 Sep 2015 19:32:41 +0000 Received: by wicge5 with SMTP id ge5so130745327wic.0 for ; Mon, 21 Sep 2015 12:32:38 -0700 (PDT) X-Received: by 10.180.106.99 with SMTP id gt3mr14102233wib.51.1442863958408; Mon, 21 Sep 2015 12:32:38 -0700 (PDT) Received: from localhost ([2.26.27.200]) by smtp.googlemail.com with ESMTPSA id i6sm12602172wjw.43.2015.09.21.12.32.36 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 21 Sep 2015 12:32:37 -0700 (PDT) From: Richard Sandiford To: Richard Biener Mail-Followup-To: Richard Biener ,Trevor Saunders , David Malcolm , GCC Patches , rdsandiford@googlemail.com Cc: Trevor Saunders , David Malcolm , GCC Patches Subject: Re: (patch,rfc) s/gimple/gimple */ References: <20150916131510.GA21102@tsaunders-iceball.corp.tor1.mozilla.com> <1442430674.32352.109.camel@surprise> <20150918133200.GA22271@tsaunders-iceball.corp.tor1.mozilla.com> Date: Mon, 21 Sep 2015 20:39:00 -0000 In-Reply-To: (Richard Biener's message of "Fri, 18 Sep 2015 15:46:44 +0200") Message-ID: <877fnj6017.fsf@googlemail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2015-09/txt/msg01608.txt.bz2 Richard Biener writes: > On Fri, Sep 18, 2015 at 3:32 PM, Trevor Saunders wrote: >> On Wed, Sep 16, 2015 at 03:11:14PM -0400, David Malcolm wrote: >>> On Wed, 2015-09-16 at 09:16 -0400, Trevor Saunders wrote: >>> > Hi, >>> > >>> > I gave changing from gimple to gimple * a shot last week. It turned out >>> > to be not too hard. As you might expect the patch is huge so its >>> > attached compressed. >>> > >>> > patch was bootstrapped + regtested on x86_64-linux-gnu, and run through >>> > config-list.mk. However I needed to update it some for changes made >>> > while testing. Do people want to make this change now? If so I'll try >>> > and commit the patch over the weekend when less is changing. >>> >>> >>> FWIW there are some big changes in gcc/tree-vect-slp.c:vectorizable_load >>> that looks like unrelated whitespace changes, e.g. the following (and >>> there are some followup hunks). Did something change underneath, or was >>> there a stray whitespace cleanup here? (I skimmed through the patch, >>> and this was the only file I spotted where something looked wrong) >> >> yeah, it was a stray whitespace cleanup, but I reverted it. >> >> Given the few but only positive comments I've seen I'm planning to >> commit this over the weekend. > > Thanks a lot! > > If you are still in a refactoring mood then I have sth else here. When > streamlining the gimple accessors I noticed the glaring const-correctness > issue in > > /* Return a pointer to the LHS of assignment statement GS. */ > > static inline tree * > gimple_assign_lhs_ptr (const gassign *gs) > { > return const_cast (&gs->op[0]); > } > > and was thinking to either "fix" it by removing the 'const' or by > merging gimple_assign_lhs and gimple_assign_lhs_ptr into > > static inline const tree& > gimple_assign_lhs (const gassign *); > > static inline tree& > gimple_assign_lhs (gassign *); AIUI const_tree (like const_rtx) only protects the top-level tree. This is something I always hoped to change for rtl one day, but fixing all the fallout would be an incredibly dull task... I suppose protecting the top level is still better than nothing though. Thanks, Richard