From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 60473 invoked by alias); 22 Jul 2015 07:43:51 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 60461 invoked by uid 89); 22 Jul 2015 07:43:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 22 Jul 2015 07:43:48 +0000 Received: from nat-ies.mentorg.com ([192.94.31.2] helo=SVR-IES-FEM-01.mgc.mentorg.com) by relay1.mentorg.com with esmtp id 1ZHogq-0004I3-9b from Thomas_Schwinge@mentor.com ; Wed, 22 Jul 2015 00:43:44 -0700 Received: from feldtkeller.schwinge.homeip.net (137.202.0.76) by SVR-IES-FEM-01.mgc.mentorg.com (137.202.0.104) with Microsoft SMTP Server id 14.3.224.2; Wed, 22 Jul 2015 08:43:42 +0100 From: Thomas Schwinge To: Nathan Sidwell CC: GCC Patches , Jakub Jelinek Subject: Re: [gomp] Move openacc vector& worker single handling to RTL In-Reply-To: <55AEA5F1.2000003@codesourcery.com> References: <5597120D.2080308@acm.org> <20150703231159.GP10247@tucnak.redhat.com> <559844EF.6010208@acm.org> <559AD85B.2050102@acm.org> <20150707095408.GD10247@tucnak.redhat.com> <559BDE68.9010302@acm.org> <20150707142229.GG10247@tucnak.redhat.com> <559D381C.7020804@acm.org> <20150708145822.GB10247@tucnak.redhat.com> <559D9A29.2020409@acm.org> <559F10F2.9050102@acm.org> <87bnf9v5ma.fsf@kepler.schwinge.homeip.net> <55AEA5F1.2000003@codesourcery.com> User-Agent: Notmuch/0.9-101-g81dad07 (http://notmuchmail.org) Emacs/24.3.1 (x86_64-pc-linux-gnu) Date: Wed, 22 Jul 2015 08:32:00 -0000 Message-ID: <877fps1vu4.fsf@schwinge.name> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-SW-Source: 2015-07/txt/msg01808.txt.bz2 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-length: 3487 Hi Nathan! On Tue, 21 Jul 2015 16:05:05 -0400, Nathan Sidwell wrote: > On 07/18/15 11:37, Thomas Schwinge wrote: > > On Thu, 09 Jul 2015 20:25:22 -0400, Nathan Sidwell wro= te: > >> This is the patch I committed. [...] > > > > Prompted by your recent "-O0 patch" to =C2=BB[f]ix PTX worker spill/fil= l=C2=AB, I > > used the attached patch 0001-O0-libgomp-C-C-testing.patch to run all C > > and C++ libgomp testing with -O0 (for Fortran, we iterate through vario= us > > kinds of optimization levels anyway). (There are no regressions of > > OpenMP testing.) > > > > For OpenACC nvptx offloading, there must still be something wrong; here= 's > > a count of the (non-deterministic!) regressions of ten runs of the > > libgomp testsuite. As private-vars-loop-worker-5.c fails most often, it > > probably makes sense to look into that one first. > > > > For avoidance of doubt, there are no such regressions if I un-apply your > > patch to =C2=BB[m]ove openacc vector& worker single handling to RTL=C2= =AB. >=20 > I cannot reproduce the failures. Applying your patch I see the following= new fails: >=20 > FAIL: libgomp.oacc-c/../libgomp.oacc-c-c++-common/lib-5.c=20 > -DACC_DEVICE_TYPE_host_nonshm=3D1 -DACC_MEM_SHARED=3D0 execution test > FAIL: libgomp.oacc-c/../libgomp.oacc-c-c++-common/private-vars-local-work= er-3.c=20 > -DACC_DEVICE_TYPE_nvidia=3D1 -DACC_MEM_SHARED=3D0 e > xecution test > FAIL: libgomp.oacc-c/../libgomp.oacc-c-c++-common/private-vars-loop-worke= r-7.c=20 > -DACC_DEVICE_TYPE_nvidia=3D1 -DACC_MEM_SHARED=3D0 ex > ecution test > FAIL: libgomp.oacc-c++/../libgomp.oacc-c-c++-common/present-1.c=20 > -DACC_DEVICE_TYPE_nvidia=3D1 -DACC_MEM_SHARED=3D0 output pattern te > st, is , should match present clause: !acc_is_present > FAIL:=20 > libgomp.oacc-c++/../libgomp.oacc-c-c++-common/private-vars-local-worker-2= .c=20 > -DACC_DEVICE_TYPE_nvidia=3D1 -DACC_MEM_SHARED=3D0 > execution test > FAIL: libgomp.oacc-c++/../libgomp.oacc-c-c++-common/private-vars-loop-vec= tor-1.c=20 > -DACC_DEVICE_TYPE_nvidia=3D1 -DACC_MEM_SHARED=3D0 > execution test > FAIL: libgomp.oacc-c++/../libgomp.oacc-c-c++-common/private-vars-loop-wor= ker-4.c=20 > -DACC_DEVICE_TYPE_nvidia=3D1 -DACC_MEM_SHARED=3D0 > execution test > FAIL: libgomp.oacc-c++/../libgomp.oacc-c-c++-common/private-vars-loop-wor= ker-5.c=20 > -DACC_DEVICE_TYPE_nvidia=3D1 -DACC_MEM_SHARED=3D0 > execution test >=20 > Which differs from your list. Well, then instead look into one of these (the private-vars-* ones)? :-) (Still hoping they're all caused by the same problem.) > Attempting to reproduce outside the test suite=20 > results in working executables. Have you tried running it multiple times? As I said, it's non-deterministic. Taking from libgomp.log the compile command line of private-vars-loop-worker-5.c for =C2=BB-DACC_DEVICE_TYPE_nvidia=3D1=C2=AB, = removing the constructor.o stuff, replacing =C2=BB-L=C2=AB by =C2=BB{-L,-Wl\,-rpath\= ,}=C2=AB, and adding =C2=BB-O0=C2=AB at the end, I then see the following: $ while :; do ./private-vars-loop-worker-5.exe 2> /dev/null && echo -n = .; done ...Aborted (core dumped) .........Aborted (core dumped) ........Aborted (core dumped) ....Aborted (core dumped) .Aborted (core dumped) ...........Aborted (core dumped) ........Aborted (core dumped) Aborted (core dumped) .Aborted (core dumped) ...Aborted (core dumped) [...] Gr=C3=BC=C3=9Fe, Thomas --=-=-= Content-Type: application/pgp-signature Content-length: 472 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJVr0mUAAoJEPoxNhtoi6CO6VAH/0mTzfBtN8J4/aqkv+Xxg06H UKrV08NQtra8vUPhknJIs84jt8i9pbczeqt0V+K5T1q3SXKpuulAubqA1MsDaCYy XHpMeOiHS8ZTbCP3T9bxEgTuVsloJuBXZnSzJLiCZTol554eee6yT4iSaI9+vNwh 4xoW85/t8HKMDzwLHr+lqRM9Wi+si+t87tdjRtBEoA7wmYAnqXr076AObz9dy3pg qQsu6DrImgo1sYDXtWSZSBbjxG98DKSIiCzn5DkfTMUp1R3YyVstDfQII8bSVhNl x8UbPiLA2pKWzQuKf3jpdhdfhWnztIac2W8u8a9/PFCNezZ0ysLS2Jk+CF9W08c= =d3m9 -----END PGP SIGNATURE----- --=-=-=--