From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 117873 invoked by alias); 17 Apr 2015 14:42:32 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 117864 invoked by uid 89); 17 Apr 2015 14:42:31 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 X-HELO: gproxy8-pub.mail.unifiedlayer.com Received: from gproxy8-pub.mail.unifiedlayer.com (HELO gproxy8-pub.mail.unifiedlayer.com) (67.222.33.93) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with SMTP; Fri, 17 Apr 2015 14:42:30 +0000 Received: (qmail 30683 invoked by uid 0); 17 Apr 2015 14:42:22 -0000 Received: from unknown (HELO cmgw3) (10.0.90.84) by gproxy8.mail.unifiedlayer.com with SMTP; 17 Apr 2015 14:42:22 -0000 Received: from box522.bluehost.com ([74.220.219.122]) by cmgw3 with id H8iC1q0042f2jeq018iFef; Fri, 17 Apr 2015 14:42:20 -0600 X-Authority-Analysis: v=2.1 cv=ae7yw3Yt c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=cNaOj0WVAAAA:8 a=f5113yIGAAAA:8 a=udL4O0NGDEAA:10 a=zstS-IiYAAAA:8 a=PnD2wP_eR3oA:10 a=GwV-GePwM2MA:10 a=e9J7MTPGsLIA:10 a=20KFwNOVAAAA:8 a=6hJqEZ3Atxzg8I2yn3EA:9 Received: from [71.33.138.241] (port=42018 helo=pokyo) by box522.bluehost.com with esmtpsa (TLSv1.2:AES128-GCM-SHA256:128) (Exim 4.82) (envelope-from ) id 1Yj7TB-0007vG-Ia; Fri, 17 Apr 2015 08:42:13 -0600 From: Tom Tromey To: David Malcolm Cc: "gcc-patches\@gcc.gnu.org" Subject: Re: [RFC stage 1] Proposed new warning: -Wmisleading-indentation References: <1429196485.32584.46.camel@surprise> Date: Fri, 17 Apr 2015 14:42:00 -0000 In-Reply-To: <1429196485.32584.46.camel@surprise> (David Malcolm's message of "Thu, 16 Apr 2015 11:01:25 -0400") Message-ID: <877ftahl4u.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Identified-User: {36111:box522.bluehost.com:elynrobi:tromey.com} {sentby:smtp auth 71.33.138.241 authed with tom+tromey.com} X-SW-Source: 2015-04/txt/msg00888.txt.bz2 >>>>> "Dave" == David Malcolm writes: Dave> However within libcpp and gcc, in linemap's expanded_location and in Dave> diagnostic messages, the "column" numbers are actually 1-based counts of Dave> *characters*, so the "column" numbers emitted in diagnostics for the Dave> start of the first token in each line are actually: FWIW this is actually in violation of the GNU coding standards. There's a bug open for it. However, I was always afraid to change this in cpp, since presumably it would break existing programs that read gcc's output. It's a bad situation because the standard can't be changed, either, as other programs (e.g., bison and I think Emacs) do follow it faithfully. Dave> (i) a consistent value for tabs in terms of spaces, or There's already -ftabstop for this, but it isn't per-file. Tom