From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20070 invoked by alias); 5 Nov 2012 21:28:20 -0000 Received: (qmail 20052 invoked by uid 22791); 5 Nov 2012 21:28:20 -0000 X-SWARE-Spam-Status: No, hits=-3.5 required=5.0 tests=AWL,BAYES_00,DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM,KHOP_RCVD_TRUST,KHOP_SPAMHAUS_DROP,NML_ADSP_CUSTOM_MED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE X-Spam-Check-By: sourceware.org Received: from mail-wi0-f179.google.com (HELO mail-wi0-f179.google.com) (209.85.212.179) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 05 Nov 2012 21:28:14 +0000 Received: by mail-wi0-f179.google.com with SMTP id hq7so2817855wib.8 for ; Mon, 05 Nov 2012 13:28:13 -0800 (PST) Received: by 10.216.205.166 with SMTP id j38mr4030537weo.186.1352150893584; Mon, 05 Nov 2012 13:28:13 -0800 (PST) Received: from localhost ([2.26.192.222]) by mx.google.com with ESMTPS id f1sm12055434wiy.2.2012.11.05.13.28.11 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 05 Nov 2012 13:28:12 -0800 (PST) From: Richard Sandiford To: Steve Ellcey Mail-Followup-To: Steve Ellcey ,, rdsandiford@googlemail.com Cc: Subject: Re: [patch, testsuite, mips] Fix gcc.dg/torture/mips-sdata-1.c References: <853292c5-73e0-4fbe-8174-1734f559dd5d@EXCHHUB01.MIPS.com> <87hap3dc7m.fsf@talisman.home> <87d2zrdbto.fsf@talisman.home> <1352150318.15035.191.camel@ubuntu-sellcey> Date: Mon, 05 Nov 2012 21:28:00 -0000 In-Reply-To: <1352150318.15035.191.camel@ubuntu-sellcey> (Steve Ellcey's message of "Mon, 5 Nov 2012 13:18:38 -0800") Message-ID: <877gpzd9jj.fsf@talisman.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2012-11/txt/msg00437.txt.bz2 Steve Ellcey writes: > On Mon, 2012-11-05 at 20:38 +0000, Richard Sandiford wrote: >> This sort of thing should usually be handled automatically by >> scan-assembler, and is for me: >> >> /foo/gcc/xgcc -B/foo/gcc/ /bar/gcc/testsuite/gcc.dg/torture/mips-sdata-1.c -fno-diagnostics-show-caret >> -O2 -flto -fuse-linker-plugin -fno-fat-lto-objects -mexplicit-relocs -ffat-lto-objects -S >> -isystem /foo/mipsisa64-elf/soft-float/newlib/targ-include -isystem /bar/newlib/libc/include -EB >> -msoft-float -o mips-sdata-1.s >> >> So the test passes all variations here. I wonder what's different in >> your case? >> >> Richard > > Well that is weird. I took out my change and I still see the error: > > Executing on > host: /local/home/sellcey/nightly/obj-mips-mti-elf/gcc/final/gcc/xgcc > -B/local/home/sellcey/nightly/obj-mips-mti-elf/gcc/final/gcc/ /local/home/sellcey/nightly/src/gcc/gcc/testsuite/gcc.dg/torture/mips-sdata-1.c -fno-diagnostics-show-caret -O2 -flto -fuse-linker-plugin -fno-fat-lto-objects -mexplicit-relocs -S -o mips-sdata-1.s (timeout = 300) > spawn /local/home/sellcey/nightly/obj-mips-mti-elf/gcc/final/gcc/xgcc > -B/local/home/sellcey/nightly/obj-mips-mti-elf/gcc/final/gcc/ /local/home/sellcey/nightly/src/gcc/gcc/testsuite/gcc.dg/torture/mips-sdata-1.c -fno-diagnostics-show-caret -O2 -flto -fuse-linker-plugin -fno-fat-lto-objects -mexplicit-relocs -S -o mips-sdata-1.s^M > PASS: gcc.dg/torture/mips-sdata-1.c -O2 -flto -fuse-linker-plugin > -fno-fat-lto-objects (test for excess errors) > FAIL: gcc.dg/torture/mips-sdata-1.c -O2 -flto -fuse-linker-plugin > -fno-fat-lto-objects scan-assembler gp_?rel\\(my_struct > > > Do you know where the -ffat-lto-objects option in your run came from? I > don't have that in my results and my tree is up-to-date. gcc.dg.exp has: if [check_effective_target_lto] { # When having plugin test both slim and fat LTO and plugin/nonplugin # path. if [check_linker_plugin_available] { set LTO_TORTURE_OPTIONS [list \ { -O2 -flto -fno-use-linker-plugin -flto-partition=none } \ { -O2 -flto -fuse-linker-plugin -fno-fat-lto-objects } ] set gcc_force_conventional_output "-fcfat-lto-objects" } else { set LTO_TORTURE_OPTIONS [list \ { -O2 -flto -flto-partition=none } \ { -O2 -flto } ] } } and scanasm.exp has: proc scan-assembler_required_options { args } { global gcc_force_conventional_output return $gcc_force_conventional_output } (similarly for scan-assembler-not, etc.). Those options are then supposed to be added by gcc.dg.exp:gcc-dg-test-1: # Let { dg-final { action } } force options as returned by an # optional proc ${action}_required_options. upvar 2 dg-final-code finalcode foreach x [split $finalcode "\n"] { set finalcmd [lindex $x 0] if { [info procs ${finalcmd}_required_options] != "" } { set req [${finalcmd}_required_options] if { $req != "" } { lappend extra_tool_flags $req } } } if { $extra_tool_flags != "" } { lappend options "additional_flags=$extra_tool_flags" } set comp_output [$target_compile "$prog" "$output_file" "$compile_type" $options] Does it work for you if you run it separately? E.g. with: make check-gcc RUNTESTFLAGS=dg-torture.exp=mips-sdata-1.c Richard