From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id D27DF3858C53 for ; Mon, 26 Sep 2022 05:41:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D27DF3858C53 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com Received: from pps.filterd (m0098420.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 28Q4ZPVK030992; Mon, 26 Sep 2022 05:41:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=9ZNtt0EGoxSfp2xQxNrY1E87FZIj7w4qpdrMXotZX/w=; b=IfuXcQUd8v9VQ/NzvhiNdHuOyYPxUUrzmzVCra7Q5PqK64gTpF51aqjy9Dh7ubMjG9cc up7jHB5h88tVgVcYfHBKUlPbZu+jYJQOLVszqZwEiYoGuXc0Sab8EMdYn96ztiYlkM8b GxkEhBrMPP+PKqUqBZ17fZ4lcYxWcJhAnAqX3kvI4hTBXaiXwQ01GnezL9091WQYDo2z dNtwY+GrDoPUwXst+bhN7ouK/OzW8AtN75MmIQd3rEHsMiYMZT5Ot4E6VGbV8FU+W+/f w9VE9mjGWzrPVzN4OxKkdHWznXXBcyD4nubWvVadZ54Z0MLFIpiJ0dXYNLy6A8kbYDOP 5Q== Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com (PPS) with ESMTPS id 3jtby72t27-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 26 Sep 2022 05:41:21 +0000 Received: from m0098420.ppops.net (m0098420.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 28Q5NBgw016938; Mon, 26 Sep 2022 05:41:20 GMT Received: from ppma06ams.nl.ibm.com (66.31.33a9.ip4.static.sl-reverse.com [169.51.49.102]) by mx0b-001b2d01.pphosted.com (PPS) with ESMTPS id 3jtby72t1d-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 26 Sep 2022 05:41:20 +0000 Received: from pps.filterd (ppma06ams.nl.ibm.com [127.0.0.1]) by ppma06ams.nl.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 28Q5ZM5l009118; Mon, 26 Sep 2022 05:41:18 GMT Received: from b06avi18626390.portsmouth.uk.ibm.com (b06avi18626390.portsmouth.uk.ibm.com [9.149.26.192]) by ppma06ams.nl.ibm.com with ESMTP id 3jss5j1x6k-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 26 Sep 2022 05:41:18 +0000 Received: from d06av25.portsmouth.uk.ibm.com (d06av25.portsmouth.uk.ibm.com [9.149.105.61]) by b06avi18626390.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 28Q5b6f839846266 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 26 Sep 2022 05:37:06 GMT Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 8363811C04C; Mon, 26 Sep 2022 05:41:16 +0000 (GMT) Received: from d06av25.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id DC5D711C04A; Mon, 26 Sep 2022 05:41:14 +0000 (GMT) Received: from [9.197.236.181] (unknown [9.197.236.181]) by d06av25.portsmouth.uk.ibm.com (Postfix) with ESMTP; Mon, 26 Sep 2022 05:41:14 +0000 (GMT) Message-ID: <8789786a-071d-ebd0-e2ab-79674072d425@linux.ibm.com> Date: Mon, 26 Sep 2022 13:41:13 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH] rs6000: Fix the condition with frame_pointer_needed_indeed [PR96072] Content-Language: en-US To: Segher Boessenkool Cc: GCC Patches , David Edelsohn , Peter Bergner References: <20220922221302.GK25951@gate.crashing.org> From: "Kewen.Lin" In-Reply-To: <20220922221302.GK25951@gate.crashing.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: EMJ6WWbONcdNVSkuVXFANLgyUMNpVdyY X-Proofpoint-GUID: lHSchQRe98u1H_QJtx51V8G619_cnq5I X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.528,FMLib:17.11.122.1 definitions=2022-09-26_04,2022-09-22_02,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 malwarescore=0 priorityscore=1501 adultscore=0 phishscore=0 spamscore=0 lowpriorityscore=0 suspectscore=0 impostorscore=0 mlxscore=0 bulkscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2209130000 definitions=main-2209260031 X-Spam-Status: No, score=-12.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,NICE_REPLY_A,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Segher, Thanks for the comments! on 2022/9/23 06:13, Segher Boessenkool wrote: > Hi! > > On Thu, Sep 22, 2022 at 09:41:42AM +0800, Kewen.Lin wrote: >> * config/rs6000/rs6000-logue.cc (rs6000_emit_epilogue): Update the >> condition for adding REG_CFA_DEF_CFA reg note with >> frame_pointer_needed_indeed. > >> --- a/gcc/config/rs6000/rs6000-logue.cc >> +++ b/gcc/config/rs6000/rs6000-logue.cc >> @@ -4956,7 +4956,7 @@ rs6000_emit_epilogue (enum epilogue_type epilogue_type) >> a REG_CFA_DEF_CFA note, but that's OK; A duplicate is >> discarded by dwarf2cfi.cc/dwarf2out.cc, and in any case would >> be harmless if emitted. */ >> - if (frame_pointer_needed) >> + if (frame_pointer_needed_indeed) >> { >> insn = get_last_insn (); > > I thought about adding an assert here, but the very next insn gives a > clear enough message anyway, zo it would be just noise :-) > >> diff --git a/gcc/testsuite/gcc.target/powerpc/pr96072.c b/gcc/testsuite/gcc.target/powerpc/pr96072.c >> new file mode 100644 >> index 00000000000..23d1cc74ffd >> --- /dev/null >> +++ b/gcc/testsuite/gcc.target/powerpc/pr96072.c >> @@ -0,0 +1,14 @@ >> +/* { dg-options "-O1" } */ >> + >> +/* Verify there is no ICE on 32 bit environment. */ > > /* This used to ICE with the SYSV ABI (PR96072). */ Updated. > > Please use -O2 if that works here. > Updated too. > Okay for trunk. Thank you! > Comitted in r13-2846, since it's a regression causing ICE, I think we want this to backport? Is it ok to backport this after burn-in time? Thanks again! BR, Kewen