From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (smtp.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) by sourceware.org (Postfix) with ESMTP id A06633858418 for ; Wed, 6 Mar 2024 13:54:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A06633858418 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A06633858418 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:ea4a:1:5054:ff:fec7:86e4 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709733263; cv=none; b=fCdbWLJssUS9uJQVnu3ONCOC/S2dsxNWrzxoP2C1KeQtjm7kLE2yzqG+/HGdv82YK4zDxJt+bRNuEDgpLQosjbhcbMhB0uLpyZJblS3/fEegkEzadSalyg0qd4UAmAMfEEOWco4x79WUbzeaEot8NnBDx6G++j50J3KVcw6UrtU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709733263; c=relaxed/simple; bh=/M5GOIMmIP+y78tZzakpG01QjyEsaeS0eVAx+azBeYo=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=k7aKXkgDbiMeMMhXM0aHvs2kY93XNShC3+M5q+GNS40FwpyTrUZ7gh37XjpuMF516Kp99JJDbnAtOIQ31ovJoKYrA2D8pHMA3W02ZGcTHVWar85uNV16v/8TX+5Jn3KnPRIyt72vQOUJ2xZWyEX2LryeWXTuvptFuyIaVWA+mIk= ARC-Authentication-Results: i=1; server2.sourceware.org From: Sam James To: FX Coudert Cc: gcc-patches , Iain Sandoe , dimitry@andric.com Subject: Re: [PATCH] Include safe-ctype.h after C++ standard headers, to avoid over-poisoning In-Reply-To: (FX Coudert's message of "Wed, 6 Mar 2024 14:42:12 +0100") Organization: Gentoo References: User-Agent: mu4e 1.12.0; emacs 30.0.50 Date: Wed, 06 Mar 2024 13:54:11 +0000 Message-ID: <878r2v1n5o.fsf@gentoo.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,KAM_SHORT,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable FX Coudert writes: > I would like to patch this patch from September 2023: > https://gcc.gnu.org/pipermail/gcc-patches/2023-September/631611.html > > This bug is now hitting macOS in the latest version of Xcode (it was orig= inally seen on freebsd). > I confirm that the patch is restoring bootstrap on x86_64-apple-darwin23 Iain hit an issue with it and I never got a chance to look into how to fix it. > > OK to push? > FX > > > > > >> Ref: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D111632 >>=20 >> When building gcc's C++ sources against recent libc++, the poisoning of >> the ctype macros due to including safe-ctype.h before including C++ >> standard headers such as , , etc, causes many compilation >> errors, similar to: >>=20 >> In file included from /home/dim/src/gcc/master/gcc/gensupport.cc:23: >> In file included from /home/dim/src/gcc/master/gcc/system.h:233: >> In file included from /usr/include/c++/v1/vector:321: >> In file included from >> /usr/include/c++/v1/__format/formatter_bool.h:20: >> In file included from >> /usr/include/c++/v1/__format/formatter_integral.h:32: >> In file included from /usr/include/c++/v1/locale:202: >> /usr/include/c++/v1/__locale:546:5: error: '__abi_tag__' attribute >> only applies to structs, variables, functions, and namespaces >> 546 | _LIBCPP_INLINE_VISIBILITY >> | ^ >> /usr/include/c++/v1/__config:813:37: note: expanded from macro >> '_LIBCPP_INLINE_VISIBILITY' >> 813 | # define _LIBCPP_INLINE_VISIBILITY _LIBCPP_HIDE_FROM_ABI >> | ^ >> /usr/include/c++/v1/__config:792:26: note: expanded from macro >> '_LIBCPP_HIDE_FROM_ABI' >> 792 | >> __attribute__((__abi_tag__(_LIBCPP_TOSTRING( >> _LIBCPP_VERSIONED_IDENTIFIER)))) >> | ^ >> In file included from /home/dim/src/gcc/master/gcc/gensupport.cc:23: >> In file included from /home/dim/src/gcc/master/gcc/system.h:233: >> In file included from /usr/include/c++/v1/vector:321: >> In file included from >> /usr/include/c++/v1/__format/formatter_bool.h:20: >> In file included from >> /usr/include/c++/v1/__format/formatter_integral.h:32: >> In file included from /usr/include/c++/v1/locale:202: >> /usr/include/c++/v1/__locale:547:37: error: expected ';' at end of >> declaration list >> 547 | char_type toupper(char_type __c) const >> | ^ >> /usr/include/c++/v1/__locale:553:48: error: too many arguments >> provided to function-like macro invocation >> 553 | const char_type* toupper(char_type* __low, const >> char_type* __high) const >> | ^ >> /home/dim/src/gcc/master/gcc/../include/safe-ctype.h:146:9: note: >> macro 'toupper' defined here >> 146 | #define toupper(c) do_not_use_toupper_with_safe_ctype >> | ^ >>=20 >> This is because libc++ uses different transitive includes than >> libstdc++, and some of those transitive includes pull in various ctype >> declarations (typically via ). >>=20 >> There was already a special case for including before >> safe-ctype.h, so move the rest of the C++ standard header includes to >> the same location, to fix the problem. >>=20 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iOUEARYKAI0WIQQlpruI3Zt2TGtVQcJzhAn1IN+RkAUCZeh1g18UgAAAAAAuAChp c3N1ZXItZnByQG5vdGF0aW9ucy5vcGVucGdwLmZpZnRoaG9yc2VtYW4ubmV0MjVB NkJCODhERDlCNzY0QzZCNTU0MUMyNzM4NDA5RjUyMERGOTE5MA8cc2FtQGdlbnRv by5vcmcACgkQc4QJ9SDfkZApqQD/QmEvX51CfcolEaoI2axVsr/J1lbP+3FQl8em 01i/YnwBALOfDCkkJwfceysI+8tV3Xs6d3tZVo+NeUrIG9pvIM0G =Ls8j -----END PGP SIGNATURE----- --=-=-=--