From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) by sourceware.org (Postfix) with ESMTPS id A450E3858C35 for ; Wed, 24 Jan 2024 12:23:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A450E3858C35 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=baylibre.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A450E3858C35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::331 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706098992; cv=none; b=fMA74xFm5efVYWoq7bWSeVrzSYt1eqS6yB2DKgm9dZQv26Ra29jit3pxbtRG329BhnIHha4d4MMBLlysMDLMGh65z113TBqQ8DdUDtMRpweHMEnfm7pCPTXmw9TSOkrUAlpBFdNpDAHh4mh/U+UX5Krd1bxoP1xnxHDonVEl31M= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706098992; c=relaxed/simple; bh=QOPkTGs/T6TXZoREMcgtyZs5uQaYcS/NYigOGWt3z5s=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=lsX3vU4PzF6eqAfwByfCGS7PZNlIBoKi3gnvd3sPL2XyKOZwcPktgs9y1enepJp3yV0Ah73ePKrdchTokuH3tVwghuY3a0Fr1DJ8tZGYiWjNliqkg25v2oCMaZN99KU/0PrlbdqosZhqC2mVFraZECVba9fIoZbpEhOiC8um1cY= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-40e9101b5f9so59562775e9.3 for ; Wed, 24 Jan 2024 04:23:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1706098988; x=1706703788; darn=gcc.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:user-agent :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9RgGxL7/nmrJX9Sv1oucPM0qiY2DEkj9OJBzkbz3aBY=; b=oe24JLP8wb5iTInLEkDaUi/oXrHtP9/XZHZ24VVeMHTYhyWShHiOL5YWFTSVdyxJo1 1c2FllruUGxMlpz+VrREqwo36OVelptspuVrgg1J/r5XvNvDCsK49Zrksz2mDSiPG1Mr BRDcxVd7UpaY3C4fxL+ml+sFSrQTlmG5LtkQzAGG8EBiITCjhjzSqWWr9FuSp2vKG7wS qM1bB5bO6iW7mDrrduM4CB6fM6Aw34pXAkvyjgoxrlzrSUgKEt1Y+cBWaRWyFMKhkthk dvbqtoQYmntHu/xCEHrEK1P7XJ+c6ubMrXAmba/Gd3rX8qvelzru7QtR2+EMFHJoOHvV sdwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706098988; x=1706703788; h=content-transfer-encoding:mime-version:message-id:date:user-agent :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=9RgGxL7/nmrJX9Sv1oucPM0qiY2DEkj9OJBzkbz3aBY=; b=NEEwsg8ZN2x0FYXA1EXQcNfALQtyF8OiBs3etSw4/WEscOgwv5HVe8FP3nB0QlpYfl GjgkzlCNs4GFEKWuPo6+efb36g8OO2+VfAJNqRCDqmnhiJsLQBpAHfs2vpt4dPL6dgJj Ii3x1yCH6ZJx53sec8Qa2ZUQS+FmGapt8T7TYUH7l7IAi07xtHdSp0SpiiMMKoCDu3Kv dKIIxo+AOIMi4E/MRAKk8FG9RakQZeSXBDWq/1O6PuyiyfJd4YfciS0QGYc05UL++ir2 COYji+cnf1fWtj8fUc09oo99cPi3JIyQneejt6j3YGunRJI159kZRgmltNS6fXdMCaSz 6t4w== X-Gm-Message-State: AOJu0YwhHfooHJAdJdCnpZa1/vZRIBizutK4oW/ERsp/m/ZTiAlPCE1K 6z5UvEQsI8sOTwv+qQnB+t5JH9ZYXqmUs69vk4YjwBg6fSxlVP2aJaUTx9JE62w= X-Google-Smtp-Source: AGHT+IFrbw6Kli2m7PpUdKLDKiiMyzM8SEgQERk2SWBEDbttzNpnca7BkOl/BR9NG5DtF7/I01niwQ== X-Received: by 2002:a05:600c:a3a5:b0:40e:499c:f332 with SMTP id hn37-20020a05600ca3a500b0040e499cf332mr1077006wmb.108.1706098988029; Wed, 24 Jan 2024 04:23:08 -0800 (PST) Received: from euler.schwinge.homeip.net (p200300c8b7344200b5efa23283b9f09b.dip0.t-ipconnect.de. [2003:c8:b734:4200:b5ef:a232:83b9:f09b]) by smtp.gmail.com with ESMTPSA id j7-20020a05600c190700b0040e52cac976sm48918041wmq.29.2024.01.24.04.23.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jan 2024 04:23:07 -0800 (PST) From: Thomas Schwinge To: "H.J. Lu" Cc: gcc-patches@gcc.gnu.org, Hongtao Liu Subject: Re: [PATCH] x86: Update PR 35513 tests In-Reply-To: <20220210135515.162048-1-hjl.tools@gmail.com> References: <20220210135515.162048-1-hjl.tools@gmail.com> User-Agent: Notmuch/0.29.3+94~g74c3f1b (https://notmuchmail.org) Emacs/28.2 (x86_64-pc-linux-gnu) Date: Wed, 24 Jan 2024 13:23:04 +0100 Message-ID: <878r4erkd3.fsf@euler.schwinge.homeip.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi! On 2022-02-10T05:55:15-0800, "H.J. Lu via Gcc-patches" wrote: > 1. Require linker with GNU_PROPERTY_1_NEEDED support for PR 35513 > run-time tests. Moving my x86_64-pc-linux-gnu testing from an old to a newish system (Ubuntu 20.04), I notice: [-PASS: g++.target/i386/pr35513-1.C -std=3Dgnu++98 (test for excess er= rors)-] [-PASS:-]{+UNSUPPORTED:+} g++.target/i386/pr35513-1.C -std=3Dgnu++98[-= execution test-] Etc. [-PASS: g++.target/i386/pr35513-2.C -std=3Dgnu++98 (test for excess er= rors)-] [-PASS:-]{+UNSUPPORTED:+} g++.target/i386/pr35513-2.C -std=3Dgnu++98[-= execution test-] Etc. ..., due to the 'property_1_needed' effective-target check now diagnosing: /usr/bin/ld: warning: /tmp/ccFNkvfI.o: unsupported GNU_PROPERTY_TYPE (5= ) type: 0xb0008000 ..., with: $ /usr/bin/ld --version | head -n 1 GNU ld (GNU Binutils for Ubuntu) 2.34 I'm not familiar with these properties, but I wonder if really some support has been removed (so that this indeed is now UNSUPPORTED), or if something's wrong somewhere (so that this should still PASS). For reference: > --- a/gcc/testsuite/lib/target-supports.exp > +++ b/gcc/testsuite/lib/target-supports.exp > +proc check_effective_target_property_1_needed { } { > + return [check_no_compiler_messages_nocache property_1_needed executabl= e { > +/* Assembly code */ > +#ifdef __LP64__ > +# define __PROPERTY_ALIGN 3 > +#else > +# define __PROPERTY_ALIGN 2 > +#endif > + > + .section ".note.gnu.property", "a" > + .p2align __PROPERTY_ALIGN > + .long 1f - 0f /* name length. */ > + .long 4f - 1f /* data length. */ > + /* NT_GNU_PROPERTY_TYPE_0. */ > + .long 5 /* note type. */ > +0: > + .asciz "GNU" /* vendor name. */ > +1: > + .p2align __PROPERTY_ALIGN > + /* GNU_PROPERTY_1_NEEDED. */ > + .long 0xb0008000 /* pr_type. */ > + .long 3f - 2f /* pr_datasz. */ > +2: > + /* GNU_PROPERTY_1_NEEDED_INDIRECT_EXTERN_ACCESS. */ > + .long 1 > +3: > + .p2align __PROPERTY_ALIGN > +4: > + .text > + .globl main > +main: > + .byte 0 > + } ""] > +} Gr=C3=BC=C3=9Fe Thomas