From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oo1-xc32.google.com (mail-oo1-xc32.google.com [IPv6:2607:f8b0:4864:20::c32]) by sourceware.org (Postfix) with ESMTPS id A77AD3858D32 for ; Fri, 18 Aug 2023 21:24:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A77AD3858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-oo1-xc32.google.com with SMTP id 006d021491bc7-56d6dfa8b52so892158eaf.3 for ; Fri, 18 Aug 2023 14:24:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1692393884; x=1692998684; h=content-transfer-encoding:mime-version:message-id:date:in-reply-to :subject:cc:to:from:user-agent:references:from:to:cc:subject:date :message-id:reply-to; bh=0on3TPYYs8fCftSl6OYg2lt4ce0w2w3ndxy3OQOkxc0=; b=VNBgsnfNYxFeiCGu/lPGCD69n/eBNUNmUXTwhCEqE1bbjpWg74e7fazeJ7/R9YsOb5 DUkWX2i+hdZ7r38FErw4L2Q/XCORTASC0b5q3LqS8Y9TWxhsVigyx62TbGZny30jho+u 3pT8GsRDS9wh5nUgV+cbRmVx+MqqjjEAOoWBsLcFWJDbuZS0y8SiFV75nVvdjWMDF84b uZvz+eT1rWfQwFWdBqWRTaqxqFv02fcQaak2YxZfDIp81VjpuRht/oeP8BHCl5IENjgq f5y4vlGZ66K+1SqiepuEXggzKZ9CZB89jKcU0thXzHmOXYcsslyNd7FBQzLVRh2LblcL Ef5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692393884; x=1692998684; h=content-transfer-encoding:mime-version:message-id:date:in-reply-to :subject:cc:to:from:user-agent:references:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=0on3TPYYs8fCftSl6OYg2lt4ce0w2w3ndxy3OQOkxc0=; b=CdWVXbPomTWmy4X401mmJ6rIYDDbquxQnQ4qVt1Xc8JJ0eKBg/JAeSp4MD9K20eIRG bh8kFvNKz5HyjfcqSvFC/3SAmK9oTMHHig7NgyNQEEJh4ke3ZFue9cMf2CY6uTE461Hy 9EHCuohhnAltFmOauMpV0z1IIyYshBmXWLFKzhz+iBgsm+bookcegL9uIMU9ADrIrIuA t6Mn/W+UL3Xg8SasNSmLjc1sFkEBXJ97YmX+UVI5bGuW7jHcx2MHXgPCZbGQBdGwCWuL tgW1NMPMXMecROs5rQQM1fHKW7/2br06+zSYQtvZNERrS/yxy+TOHHKxhfEw97t/tyzq 9cvA== X-Gm-Message-State: AOJu0YwNha8zjaxMkz2/vbSpR61eWlwOnL56XDgS9NPCx1aB1zk0v89n 2d1UigQuMrIK7toHdLVE5+D0cw== X-Google-Smtp-Source: AGHT+IHT5cIwl4K0Cbe6N5vvJsA1p3eeK1lmqRPZTAlxCXmOBss/UvXNaUb6qHn0l1YMxggGkcRX5Q== X-Received: by 2002:a4a:301e:0:b0:56c:7c3b:1c21 with SMTP id q30-20020a4a301e000000b0056c7c3b1c21mr541809oof.0.1692393883974; Fri, 18 Aug 2023 14:24:43 -0700 (PDT) Received: from localhost ([2804:14d:7e39:8470:80dc:7e47:4373:7fd8]) by smtp.gmail.com with ESMTPSA id r134-20020a4a378c000000b0056e45a34dcfsm1257617oor.1.2023.08.18.14.24.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Aug 2023 14:24:43 -0700 (PDT) References: <20230721212937.1784983-1-thiago.bauermann@linaro.org> <87r0o4p9fe.fsf@linaro.org> <2f86430f-2f3b-76fa-50bc-514b18ec9dd7@codesourcery.com> User-agent: mu4e 1.10.5; emacs 28.2 From: Thiago Jung Bauermann To: Tobias Burnus Cc: gcc-patches@gcc.gnu.org, Andrew Pinski , Patrick Palka Subject: Re: [PATCH] testsuite: Adjust g++.dg/gomp/pr58567.C to new compiler message In-reply-to: <2f86430f-2f3b-76fa-50bc-514b18ec9dd7@codesourcery.com> Date: Fri, 18 Aug 2023 18:24:40 -0300 Message-ID: <878ra8kprb.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hello Tobias, Tobias Burnus writes: > Hello Thiago, > > the patch looks good to me. Thanks! Can you commit the patch yourself or > do you need someone to do this for you? Thank you! I don't have commit access, so I would need someone to do this for me. > On 15.08.23 18:17, Thiago Jung Bauermann via Gcc-patches wrote: >> Thiago Jung Bauermann writes: >> >>> Commit 92d1425ca780 "c++: redundant targ coercion for var/alias tmpls" >>> changed the compiler error message in this testcase from >>> >>> : In instantiation of 'void foo() [with T =3D int]': >>> :14:11: required from here >>> :8:22: error: 'int' is not a class, struct, or union type >>> :8:22: error: 'int' is not a class, struct, or union type >>> :8:22: error: 'int' is not a class, struct, or union type >>> :8:3: error: expected iteration declaration or initialization >>> compiler exited with status 1 >>> >>> to: >>> >>> : In instantiation of 'void foo() [with T =3D int]': >>> :14:11: required from here >>> :8:22: error: 'int' is not a class, struct, or union type >>> :8:3: error: invalid type for iteration variable 'i' >>> compiler exited with status 1 >>> Excess errors: >>> :8:3: error: invalid type for iteration variable 'i' >>> >>> Andrew Pinski analysed the issue in PR 110756 and considered that it wa= s a >>> testsuite issue in that the error message changed slightly. Also, it's= a >>> better error message. >>> >>> Therefore, we only need to adjust the testcase to expect the new messag= e. >>> >>> gcc/testsuite/ChangeLog: >>> PR testsuite/110756 >>> g++.dg/gomp/pr58567.C: Adjust to new compiler error message. >>> --- >>> gcc/testsuite/g++.dg/gomp/pr58567.C | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/gcc/testsuite/g++.dg/gomp/pr58567.C b/gcc/testsuite/g++.dg= /gomp/pr58567.C >>> index 35a5bb027ffe..866d831c65e4 100644 >>> --- a/gcc/testsuite/g++.dg/gomp/pr58567.C >>> +++ b/gcc/testsuite/g++.dg/gomp/pr58567.C >>> @@ -5,7 +5,7 @@ >>> template void foo() >>> { >>> #pragma omp parallel for >>> - for (typename T::X i =3D 0; i < 100; ++i) /* { dg-error "'int' is n= ot a class, struct, or union type|expected iteration declaration or initial= ization" } */ >>> + for (typename T::X i =3D 0; i < 100; ++i) /* { dg-error "'int' is n= ot a class, struct, or union type|invalid type for iteration variable 'i'" = } */ >>> ; >>> } >>> >> Ping? I just tested trunk. It still fails this test, and this patch >> still fixes the failures. > Tobias > ----------------- > Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstra=C3=9Fe 2= 01, 80634 M=C3=BCnchen; > Gesellschaft mit beschr=C3=A4nkter Haftung; Gesch=C3=A4ftsf=C3=BChrer: Th= omas Heurung, Frank Th=C3=BCrauf; > Sitz der Gesellschaft: M=C3=BCnchen; Registergericht M=C3=BCnchen, HRB 10= 6955 --=20 Thiago