From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id 86F4838367B0 for ; Wed, 7 Dec 2022 15:12:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 86F4838367B0 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2B7ENbtQ007995; Wed, 7 Dec 2022 15:12:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=references : from : to : cc : subject : in-reply-to : date : message-id : content-type : mime-version; s=corp-2022-7-12; bh=KecmqvhuoBgAx9dUq9LHEQpX3ODg9ol6xubSkl5Tuwc=; b=2GhCYRpol/RUpGdX5hVDerwtMnf6QiHn2Wg269kn8Lo1J8w+5Hz7GRifFamA9F5YbxOk H5UzPHJQVs4PRehcI+AnNkG/yKMgotPgUy3ul4JPwBVp8s57H9Wwnrxire7f45ESxPpX TdqThu7S9XdlZQ0ENUQkxwYo/nG5WUa9bDUIPBmhRiBeI81hDbbOw+2pglQHV7CCv2dZ ieYdvuLxXg4yPL1IsSG+kvrYHmBS/QOJeFprkjBgIkilGa6M6ZT0XaWeSmd8MvZ70fO6 It9qwceFx+uooMsbER2SF9tKZ4pKqBh/AZM5O/JYaDT2GAY1/eaYWpCIOkCoKqbcOoYg 7g== Received: from iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (iadpaimrmta02.appoci.oracle.com [147.154.18.20]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3mauf8gb9n-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 07 Dec 2022 15:12:15 +0000 Received: from pps.filterd (iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com [127.0.0.1]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (8.17.1.5/8.17.1.5) with ESMTP id 2B7F4CAW021791; Wed, 7 Dec 2022 15:12:15 GMT Received: from nam02-dm3-obe.outbound.protection.outlook.com (mail-dm3nam02lp2040.outbound.protection.outlook.com [104.47.56.40]) by iadpaimrmta02.imrmtpd1.prodappiadaev1.oraclevcn.com (PPS) with ESMTPS id 3maa5xtwrt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 07 Dec 2022 15:12:15 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=g1E1vJhfrCUyk2FRcIq0agYj9oPr8V2QaJlZ5bf22r2p4Q7iyh3YtYBvqc1lZzEJREPsL71sQjAF65nd89DueP2MO83nYTy6L7yF006UA+wsmDhjSqYfxPTpRvuIGoq+iMR4+FWlTiOVeUXfny6fYhdeE3cfq2M3Og2d0yjvmjLndZxfOT1K9xltNp5TJANE+Ea3liNcvuEFmEEt+9GqDroSv7lKDpqqU8iBfYUrcrMUwxr4PLGIl6rlTBi5u/ep3xIOXgQn/4gx36dNMvhwS7eVkpejU6ngz36FSzPhQQhrpODlnY1NgrlULGu2XgbXWO4kHCwDsjpCT3e1oojX8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KecmqvhuoBgAx9dUq9LHEQpX3ODg9ol6xubSkl5Tuwc=; b=f6QGLXmSyvB0u9F2aETkeP6LRrMZfZ0464reW9UQMlU1rm1C+pSGNBJYplw6JB3eAV6pONx2+67hPx8I40Y3G8TUXxrrTEzBfF5kkmQ89u1iF80CIM9GY2WyaDcSWhtT+Qy7cupTOYeW2lzF4UPsSj1BOx3eYpLfzDOZb6J1ocr3bYUtlaqgCVGDogKiKTP2pHqY/u4JIY3meiW4xi5CFftw5Lz1cNh1lLFQan5jDAy5m2iiWsTcziyiWkspLchC0xp6qragDu/GDtEo5sfPbFeIlo9RVinPAEd7uWffMjBuj8zmg3CcUPj+FDUeeLaMd+gK+ZaxaOdNsl4yrLh1bQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KecmqvhuoBgAx9dUq9LHEQpX3ODg9ol6xubSkl5Tuwc=; b=rJmY+R+jpWZ57q/ekONJ67qyAejdrevmvNOJ3YXP/TEXeoW4QuYpgtqD1zSknA9Jlk8He/oPNvnJgm6maXwp20uFR71r2DMLEL6s1/t0bWjrXHOoCyv4G8fo0s+MrkA/J0EK/yaU5vNx33ogMVlOPpCWejEqsyRdA7Z1sRarJh8= Received: from BN6PR1001MB2340.namprd10.prod.outlook.com (2603:10b6:405:30::36) by BLAPR10MB4882.namprd10.prod.outlook.com (2603:10b6:208:30d::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5880.14; Wed, 7 Dec 2022 15:12:13 +0000 Received: from BN6PR1001MB2340.namprd10.prod.outlook.com ([fe80::8681:5931:e558:2638]) by BN6PR1001MB2340.namprd10.prod.outlook.com ([fe80::8681:5931:e558:2638%7]) with mapi id 15.20.5880.014; Wed, 7 Dec 2022 15:12:13 +0000 References: <20221202175225.2780-1-cupertino.miranda@oracle.com> <20221202175225.2780-2-cupertino.miranda@oracle.com> User-agent: mu4e 1.4.15; emacs 28.1 From: Cupertino Miranda To: Jeff Law Cc: gcc-patches@gcc.gnu.org, jose.marchesi@oracle.com Subject: Re: [PATCH 1/2] select .rodata for const volatile variables. In-reply-to: Date: Wed, 07 Dec 2022 15:12:07 +0000 Message-ID: <878rjj5jug.fsf@oracle.com> Content-Type: text/plain X-ClientProxiedBy: LO4P123CA0565.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:33b::19) To BN6PR1001MB2340.namprd10.prod.outlook.com (2603:10b6:405:30::36) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN6PR1001MB2340:EE_|BLAPR10MB4882:EE_ X-MS-Office365-Filtering-Correlation-Id: 74f8e044-c9e9-456f-255d-08dad8656b65 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: S/B3BW74eCViLpjEQNWsZXT2uMbwLvq6uhtWzH+kGmBS62lzkfpDxPHq4sQRWOXPBRNUQ9MNxuN2xPNny8YmMbHn24wGI4wChotTeDznLFiNxf286bp6RfV3Hj8XzhRTsfVzf4USPig7duow9aneWv1svh7OOGSC4lgJKVz3HW1lrwLqvHtALwCtLRnw5fmY1V29jco7ovJOHFFTxYPytj+sB/S5WGLaIjemfevxmyn6sdTcgqysKTdnO/nYgJRX9BZyfikCSn89ryDGN12EIaU+n22s3PO+IQDhEveJdClpJR53gLXcXWtuq5osJhRlxZGYr5iQcUjTCOycqH3J0QvIUjMqSoyeKCbpPjWeCKDyXWBt/XBQ5qOuDkzkFHVt+Vf9oAXY4ahRPwjbsw6aJ5IBq41WgSdOJ4TuxmcBRQI+7Cg2HrJSkUczVmMLqusa8ENqqKcm6i+sW+EZDW5UT8R6sBuiQYuBVoaFX7n3Akr2kQacb6tTgVzT2SfvPlyZFqHJdiWplQ13k3yTYEk8ZundJR64fSZxaGpSqKKm0GgatBeS7/sbyOxJnRKv5JyLdbgiydaK9AOel6rS4JEiBAoM5xxWCzFbkFsL121zE6/G3Su5flmaxyaEC04MT/eOIIuOIyrFgWUgMx5r2ap1aixB9wR2dKXNA2rBBWDTIo+LzZzJvX5S66nMGbbnOakxMwCEbC2R2YWPePsx4TMrEriVYVkjQl7Wc/kK4iAR5CUHbI5oAkJVbsK3MYiFila7 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN6PR1001MB2340.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(396003)(39860400002)(346002)(136003)(376002)(451199015)(83380400001)(36756003)(86362001)(478600001)(6916009)(966005)(6486002)(5660300002)(8676002)(44832011)(2906002)(66476007)(8936002)(66556008)(66946007)(41300700001)(4326008)(38100700002)(6506007)(107886003)(53546011)(2616005)(6666004)(316002)(6512007)(186003)(142923001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?r+BO0pPAlOi1Lt9L9ND+aKZKvrKhFWjPNPdbX7vg0xAssQgKweoMaFOKdBe+?= =?us-ascii?Q?Puw4GiBIHXY4c+MCYC82TuDJ/eS4oFx7DdYJCfOIQcaVhfOJ9tMGd2pd2sbn?= =?us-ascii?Q?7XmmtUeC6oF0I2h+ZFZMDltxKp8TkIPinGDTWhvmkFPTRA67Xyzc6gH7UzRU?= =?us-ascii?Q?yojzg/IhVo37ZyGWfIHb1rl8Acx62QY4BDNqN5vlbzWnwuRKt11F38KY9wRv?= =?us-ascii?Q?M0KbsfW5bVaqB5at4nroDSADwYe5ixpxNmPsgRlybutoAy981bHjRqgJ6aXZ?= =?us-ascii?Q?HQhuDmMFLIyExaEingivMC24u3qJx2n0V41dBt8Pq7FuOHaxAhtzvcvlhEDt?= =?us-ascii?Q?TKL2NJQZ7C10COgv9s439cHc4eyqItRhYM99iAQgYR94cWThAJohLeBsnlDT?= =?us-ascii?Q?YjENL9q0FVieT3v4DiCfrHJooq/3idJJV1IkGQktt12hnwSewdb6b2LDd3Ho?= =?us-ascii?Q?mqMCfgg2Ij/2ipJ4DWeTfKWqkRipuzAmezl2DYkssEVpSyzxltf1cvl+oyMR?= =?us-ascii?Q?ENs0LqhlMyY+xuHbVe0XqrWw2l3y19X5k3utxWBeFvlHvfsv5ehZF+BNFpD3?= =?us-ascii?Q?8YHqAAKWwvT/pLDefJQg2MMhYs/1yMD4APmA6DnEEeTUbYZEdrnPsfjzZ8R6?= =?us-ascii?Q?58YDR5rFxcMvAbnY+vg8a+4FoqSx26cjyiz+2Y/b2gWPBCg8LHLJPZQdc1oV?= =?us-ascii?Q?7DMyBs42PZ72aVZeF8uASZy+JnnP3hwN6YiffJ6a6hx5hkqjx5mrvWor3vQ3?= =?us-ascii?Q?RiDAUpixouUjB5Vmvzc6oUrUBek5QVGmDcBc11Tz1UEKxuk8f0kArfttr1sM?= =?us-ascii?Q?C+EbC2zajCTRnfLB5/iHm6mkX6cLFnQbWAmugExQqsjOAqlkxNBxS9iJumPX?= =?us-ascii?Q?76tg0e7/y3/fFNxSlIbZ3LArscmPTJiPCI2pfMRv9TLs0agPVlluXF0dGxGa?= =?us-ascii?Q?bkpF4OWp5W4SALmnEt9xglKy2IG23gocxKX9uXj4Nma9bQqSwPunXSfyX9nz?= =?us-ascii?Q?lVx3a5im1wK5C30cC8blaR7vupM8cWyWN6oy9PQuPFNcnW4cUEavFZ2+gblg?= =?us-ascii?Q?Hf3K8QJKXLonuo3EGRYxs96mP/5B72EfjURpp+xQV4LsstKEfm5fD6Gya17Z?= =?us-ascii?Q?jwIzGDJtZJxJEw0wbeh2eRW7OSj+050WTTapbNRDXjfVDGTvHpC3Q15ytkvx?= =?us-ascii?Q?VxFJ1bujsEX0w12N99G4y0oH2Nf7tQ5DrxJYWiDC86rF9BiBrlDBLQjy4wDZ?= =?us-ascii?Q?Ihqj77YMtVfk9lENEMNrqXEBSrb7kNTP+bHsZeA2c+6CelgSgJPPR17V99gm?= =?us-ascii?Q?/rY9yeZ4susGpzUJpZQL4foZZ5sVXk0yurcEIbTSWhSR8M8N+hF70DVZlLga?= =?us-ascii?Q?a9QgZuIKg9BKfsWAx4eHyrL0ETLXqncC/ed2T0umwyemjS5Xk8su1dbNOr88?= =?us-ascii?Q?rwlx0LUCl8OvG32symhh0Ehtr5x1RPFT2Df3fgmAOk7rapW/OWnOQhvijfax?= =?us-ascii?Q?8zkfopkBL+yz1mCcEUv4/E8fKlqNVrJnnpZO7W4LfaXyJbmTUNJgaFu0o3fW?= =?us-ascii?Q?dr5oKYdT1+fTiperKbNrzeP7aulWWJWtLqvTR7MzxUm+5NQ/L1CmO5vxOpq6?= =?us-ascii?Q?8wi/uMGI7bM+svDb3gFLCdg=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 74f8e044-c9e9-456f-255d-08dad8656b65 X-MS-Exchange-CrossTenant-AuthSource: BN6PR1001MB2340.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2022 15:12:13.3621 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: v0O6DD0ndxh3uC/SPT6YfK2ufAeLrFxoupFqBVtUj5aBhHijasCx4rZh9KQCMt7bZsKhPec3V5E31OI5StwkW1p4jhF/jNWsx3avtJXvIs0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB4882 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-12-07_07,2022-12-07_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 adultscore=0 phishscore=0 spamscore=0 bulkscore=0 mlxscore=0 suspectscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000 definitions=main-2212070131 X-Proofpoint-ORIG-GUID: qx2GeIFXepVvt8z7xUsmthwgxO4QPwLA X-Proofpoint-GUID: qx2GeIFXepVvt8z7xUsmthwgxO4QPwLA X-Spam-Status: No, score=-11.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Jeff, First of all thanks for your quick review. Apologies for the delay replying, the message got lost in my inbox. > On 12/2/22 10:52, Cupertino Miranda via Gcc-patches wrote: >> Changed target code to select .rodata section for 'const volatile' >> defined variables. >> This change is in the context of the bugzilla #170181. >> gcc/ChangeLog: >> v850.c(v850_select_section): Changed function. > I'm not sure this is safe/correct. ISTM that you need to look at the underlying > TREE_TYPE to check for const-volatile rather than TREE_SIDE_EFFECTS. I believe this was asked by Jose when he first sent the generic patches. Please notice my change is influenced by his original patch that does the same and was approved. https://gcc.gnu.org/pipermail/gcc-patches/2022-August/599348.html https://gcc.gnu.org/pipermail/gcc-patches/2022-September/602374.html > > Of secondary importance is the ChangeLog. Just saying "Changed function" > provides no real information. Something like this would be better: > > * config/v850/v850.c (v850_select_section): Put const volatile > objects into read-only sections. > > > Jeff > > > > >> --- >> gcc/config/v850/v850.cc | 1 - >> 1 file changed, 1 deletion(-) >> diff --git a/gcc/config/v850/v850.cc b/gcc/config/v850/v850.cc >> index c7d432990ab..e66893fede4 100644 >> --- a/gcc/config/v850/v850.cc >> +++ b/gcc/config/v850/v850.cc >> @@ -2865,7 +2865,6 @@ v850_select_section (tree exp, >> { >> int is_const; >> if (!TREE_READONLY (exp) >> - || TREE_SIDE_EFFECTS (exp) >> || !DECL_INITIAL (exp) >> || (DECL_INITIAL (exp) != error_mark_node >> && !TREE_CONSTANT (DECL_INITIAL (exp))))