Re: [PATCH 2/3] Add lto-dump tool.

[Thomas Schwinge <thomas@codesourcery.com>]

[-- Attachment #1: Type: text/plain, Size: 1474 bytes --]

Hi!

This minor clean-up had fallen out of me working on something else in
GCC's options machinery, several months ago:

On 2019-03-12T18:14:04+0100, marxin <mliska@suse.cz> wrote:
> gcc/lto/ChangeLog:

>       * lang.opt: Add new language LTODump and options related
>       to LTO dump tool.

As this new "Language" 'LTODump' does not share any options with 'LTO'
proper, it makes sense, in my opinion, to also make that obvious in
'gcc/lto/lang.opt', which your Subversion r270897 (Git
commit 66d62d9f2e6b059be6a018397fba555147133a9a) "Add lto-dump tool"
almost ;-) did:

> --- a/gcc/lto/lang.opt
> +++ b/gcc/lto/lang.opt
> @@ -24,6 +24,9 @@
>  Language
>  LTO
>
> +Language
> +LTODump
> +
>  Enum
>  Name(lto_linker_output) Type(enum lto_linker_output) UnknownError(unknown linker output %qs)
>
> @@ -66,6 +69,65 @@ fwpa=
>  LTO Driver RejectNegative Joined Var(flag_wpa)
>  Whole program analysis (WPA) mode with number of parallel jobs specified.
>
> +
> +[LTODump option records]
> +
> +
>  fresolution=
>  LTO Joined
>  The resolution file.

OK to push the attached
"Better separate 'LTO' vs. 'LTODump' in 'gcc/lto/lang.opt'"?


Grüße
 Thomas


-----------------
Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634 München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht München, HRB 106955

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Better-separate-LTO-vs.-LTODump-in-gcc-lto-lang.opt.patch --]
[-- Type: text/x-diff, Size: 1907 bytes --]

From 7fe1d5b8d39d863285e14fbb186599dcf6bba986 Mon Sep 17 00:00:00 2001
From: Thomas Schwinge <thomas@codesourcery.com>
Date: Fri, 1 Apr 2022 19:52:54 +0200
Subject: [PATCH] Better separate 'LTO' vs. 'LTODump' in 'gcc/lto/lang.opt'

Minor clean-up after Subversion r270897 (Git
commit 66d62d9f2e6b059be6a018397fba555147133a9a) "Add lto-dump tool".

No change in generated files.

	gcc/lto/
	* lang.opt: Better separate 'LTO' vs. 'LTODump'.
---
 gcc/lto/lang.opt | 15 +++++++--------
 1 file changed, 7 insertions(+), 8 deletions(-)

diff --git a/gcc/lto/lang.opt b/gcc/lto/lang.opt
index 550a50fc188..1ad2967d9cf 100644
--- a/gcc/lto/lang.opt
+++ b/gcc/lto/lang.opt
@@ -24,9 +24,6 @@
 Language
 LTO
 
-Language
-LTODump
-
 Enum
 Name(lto_linker_output) Type(enum lto_linker_output) UnknownError(unknown linker output %qs)
 
@@ -52,7 +49,6 @@ flinker-output=
 LTO Driver Joined RejectNegative Enum(lto_linker_output) Var(flag_lto_linker_output) Init(LTO_LINKER_OUTPUT_UNKNOWN)
 Set linker output type (used internally during LTO optimization).
 
-
 fltrans
 LTO Var(flag_ltrans)
 Run the link-time optimizer in local transformation (LTRANS) mode.
@@ -61,6 +57,10 @@ fltrans-output-list=
 LTO Joined Var(ltrans_output_list)
 Specify a file to which a list of files output by LTRANS is written.
 
+fresolution=
+LTO Joined
+The resolution file.
+
 fwpa
 LTO Driver
 Run the link-time optimizer in whole program analysis (WPA) mode.
@@ -70,6 +70,9 @@ LTO Driver RejectNegative Joined Var(flag_wpa)
 Whole program analysis (WPA) mode with number of parallel jobs specified.
 
 
+Language
+LTODump
+
 list
 LTODump Var(flag_lto_dump_list)
 Call the dump function for variables and function in IL.
@@ -131,8 +134,4 @@ callgraph
 LTODump Var(flag_dump_callgraph)
 Dump the symtab callgraph.
 
-fresolution=
-LTO Joined
-The resolution file.
-
 ; This comment is to ensure we retain the blank line above.
-- 
2.35.1