From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa2.mentor.iphmx.com (esa2.mentor.iphmx.com [68.232.141.98]) by sourceware.org (Postfix) with ESMTPS id 5EBC8384A04C for ; Thu, 20 Oct 2022 20:57:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5EBC8384A04C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-IronPort-AV: E=Sophos;i="5.95,199,1661846400"; d="scan'208";a="85242846" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa2.mentor.iphmx.com with ESMTP; 20 Oct 2022 12:57:05 -0800 IronPort-SDR: D3lATaVLXtWrPdKMzztmvtZfNpkDDOmprg3ZXMm7J+oAblJftmGcCwRB153xW64XPxB9d66LrZ Elne9vqqneHTbFhiSnlliMQvvyxzhAJcB9+FhbsuUpoRypwNkdxVPBsOVnII7KQPAgJHoEP89H 6h5C9JVzl53UuvsP+Zy/EfjfoIfsuWeRkZb50O/j2PBute07rcSE7qRLNmqltiM4r9ez8tHmw4 Kk2w06DIw5IzY5Ti7/ZL+ZcdeIXQM7iCNCQZVk9izEzD6ygrsgXUoPshOwwjlDifO2gIi9lF/U 2b8= From: Thomas Schwinge To: Jakub Jelinek , Tobias Burnus CC: Subject: Re: Remove support for Intel MIC offloading In-Reply-To: <87a65qhhk0.fsf@euler.schwinge.homeip.net> References: <499b9ae2-1365-a954-ed5e-35aede5d0def@suse.cz> <20211108085918.GH2710@tucnak> <3376e0dd-9f8e-ebac-eaef-4f02865807c3@suse.cz> <87a65qhhk0.fsf@euler.schwinge.homeip.net> User-Agent: Notmuch/0.29.1+93~g67ed7df (https://notmuchmail.org) Emacs/26.3 (x86_64-pc-linux-gnu) Date: Thu, 20 Oct 2022 22:56:57 +0200 Message-ID: <878rladxie.fsf@dem-tschwing-1.ger.mentorg.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-14.mgc.mentorg.com (139.181.222.14) To svr-ies-mbx-10.mgc.mentorg.com (139.181.222.10) X-Spam-Status: No, score=-12.0 required=5.0 tests=BAYES_00,GIT_PATCH_0,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,KAM_SHORT,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Jakub, Tobias! On 2022-10-20T13:15:43+0200, I wrote: > I'm proposing the attached "Remove support for Intel MIC offloading" Can you please confirm: > --- a/gcc/config/i386/i386-options.cc > +++ b/gcc/config/i386/i386-options.cc > @@ -307,10 +307,6 @@ ix86_omp_device_kind_arch_isa (enum omp_device_kind_= arch_isa trait, > case omp_device_kind: > return strcmp (name, "cpu") =3D=3D 0; > case omp_device_arch: > -#ifdef ACCEL_COMPILER > - if (strcmp (name, "intel_mic") =3D=3D 0) > - return 1; > -#endif > if (strcmp (name, "x86") =3D=3D 0) > return 1; > if (TARGET_64BIT) Only remove this bit as quoted, or actually remove the whole function (used for 'gcc/config/i386/i386.cc:TARGET_OMP_DEVICE_KIND_ARCH_ISA')? But if I do the latter, I get a few FAILs in compiler-side '[...]/gomp/declare-variant-[...]' test cases, and 'libgomp.c/declare-variant-1.c'. You, Jakub, had originally added that in Subversion r277662 (Git commit 9ba66bf5b9c69e0e2bcd1b2ab88160bf9b2aa417) "targetm.omp.device_kind_arch_isa and OpenMP declare variant kind/arch/isa = handling". Reading these emails, and the discussion in "[OpenMP] Context selectors missing for PowerPC", I infer that we generally would like to keep this stuff, for non-offloading OpenMP use, and thus indeed just remove the Intel MIC parts (as quoted above). Thus: > --- a/libgomp/libgomp.texi > +++ b/libgomp/libgomp.texi > @@ -4303,10 +4303,6 @@ offloading devices (it's not clear if they should = be): > > @multitable @columnfractions .60 .10 .25 > @headitem @code{arch} @tab @code{kind} @tab @code{isa} > -@item @code{intel_mic}, @code{x86}, @code{x86_64}, @code{i386}, @code{i4= 86}, > - @code{i586}, @code{i686}, @code{ia32} > - @tab @code{host} > - @tab See @code{-m...} flags in ``x86 Options'' (without @code{-m}) > @item @code{amdgcn}, @code{gcn} > @tab @code{gpu} > @tab See @code{-march=3D} in ``AMD GCN Options'' ..., I should also restore this, and only remove the Intel MIC mention. On the other hand: > diff --git a/gcc/config/i386/t-omp-device b/gcc/config/i386/t-omp-device > deleted file mode 100644 | index cfb41ed71ce..00000000000 | --- gcc/config/i386/t-omp-device | +++ /dev/null | @@ -1,6 +0,0 @@ | -omp-device-properties-i386: $(srcdir)/config/i386/i386-options.cc | - echo kind: cpu > $@ | - echo arch: intel_mic x86 x86_64 i386 i486 i586 i686 ia32 >> $@ | - echo isa: sse4 `sed -n '/^static struct ix86_target_opts isa2\?_opt= s\[\] =3D/,/^};/p' \ | - $(srcdir)/config/i386/i386-options.cc | \ | - sed -n 's/",.*$$//;s/^ { "-m//p'` >> $@ Indeed remove this whole file, or just Intel MIC, again? Here, as I understand, this is fine to remove completely, as is only used if there is an actual offload compiler (which now there isn't anymore); unused as of here: > --- a/gcc/configure.ac > +++ b/gcc/configure.ac > @@ -1153,10 +1147,6 @@ for tgt in `echo $enable_offload_targets | sed 's/= ,/ /g'`; do > > enable_offloading=3D1 > case "$tgt" in > - *-intelmic-* | *-intelmicemul-*) > - omp_device_property=3Domp-device-properties-i386 > - omp_device_property_tmake_file=3D"${omp_device_property_tmake_file}= \$(srcdir)/config/i386/t-omp-device" > - ;; > amdgcn*) > omp_device_property=3Domp-device-properties-gcn > omp_device_property_tmake_file=3D"${omp_device_property_tmake_file}= \$(srcdir)/config/gcn/t-omp-device" So I assume that is OK the way I had it prepared. Gr=C3=BC=C3=9Fe Thomas ----------------- Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstra=C3=9Fe 201= , 80634 M=C3=BCnchen; Gesellschaft mit beschr=C3=A4nkter Haftung; Gesch=C3= =A4ftsf=C3=BChrer: Thomas Heurung, Frank Th=C3=BCrauf; Sitz der Gesellschaf= t: M=C3=BCnchen; Registergericht M=C3=BCnchen, HRB 106955