From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by sourceware.org (Postfix) with ESMTPS id D08AF384A8A6 for ; Fri, 10 Sep 2021 14:12:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D08AF384A8A6 Received: from pps.filterd (m0246617.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 18ADn96D013698 for ; Fri, 10 Sep 2021 14:12:18 GMT Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by mx0b-00069f02.pphosted.com with ESMTP id 3ayty4a115-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 10 Sep 2021 14:12:18 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 18AE6JeR115881 for ; Fri, 10 Sep 2021 14:12:17 GMT Received: from nam12-dm6-obe.outbound.protection.outlook.com (mail-dm6nam12lp2174.outbound.protection.outlook.com [104.47.59.174]) by aserp3030.oracle.com with ESMTP id 3aytgemvnf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 10 Sep 2021 14:12:17 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GSwcaRDYor5GoYC/Yvvl49TiBcA6B/yZ42PVIsG9xPppi6UeEca0Jds4JgBRb9SNrpT2h5vkglamb2tNqCvtuVq0KMxgdH2jiuxsz6c77Lsr+7ngnUHZzvAaWtix4mPumUEpgAbOdSbxKOlwRBa1kQLRf5Qu1wJIPPO0Vjc63z49hJcVPA37aPKggbaFlq/tODbrsFUe/5BJuU7vVRWZa5IR8+fZrxakRyaq9cue4P9bFku48zbYMXacpOdoygSdaSGlLVdp4wY6TSJbQ3ats+XkHShUg9e2wb31qutXTxEl1e4Sy96RsvWLhbg0rP0hOJ9UvZRD+/sDY9rn7Xue/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=eIaSUzHB5kd8q5nJi2fzH01SBwyYR+1hkwAGID+HppE=; b=A3XOuk+lgIPr173DTN9PJ2RF8q+r4U7kO7aeGf+YBV5PyqoGp2wALCSPSd6FqXDEJL05AFMXwu52Vy4L97Z7SChnloEp376q8KXXZr4JnhIyQapZA5F+GgTJ30UNzf+XpcZhgVHLWHEGhPSmp9oDTmC4OvZp5I7c9B8VfvlVFf+IM3lpwMPD0duWIbQuTejgiAM2DCDciaAkfqUjW6LVGk7bJOIrhTrrfA3z5JMBzUePK4p1s5+mFZOgUd6cEUAs+EaC8q/8bymgt1RdDFlWum40txrMF3sQqs4PfKPa7Ee2mh7yAABArN1lhZaiYfVpXjP0iWgdWLH67YP09PtOvw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none Received: from BYAPR10MB2888.namprd10.prod.outlook.com (2603:10b6:a03:88::32) by BYAPR10MB3624.namprd10.prod.outlook.com (2603:10b6:a03:127::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.17; Fri, 10 Sep 2021 14:12:06 +0000 Received: from BYAPR10MB2888.namprd10.prod.outlook.com ([fe80::f89b:d57b:829b:84ca]) by BYAPR10MB2888.namprd10.prod.outlook.com ([fe80::f89b:d57b:829b:84ca%7]) with mapi id 15.20.4500.017; Fri, 10 Sep 2021 14:12:05 +0000 From: "Jose E. Marchesi" To: David Faust via Gcc-patches Subject: Re: [PATCH 0/3] bpf: add -mcpu and related feature options References: <20210909213645.11605-1-david.faust@oracle.com> Date: Fri, 10 Sep 2021 16:11:57 +0200 In-Reply-To: <20210909213645.11605-1-david.faust@oracle.com> (David Faust via Gcc-patches's message of "Thu, 9 Sep 2021 14:36:42 -0700") Message-ID: <878s04seoi.fsf@oracle.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Content-Type: text/plain X-ClientProxiedBy: AM0PR06CA0113.eurprd06.prod.outlook.com (2603:10a6:208:ab::18) To BYAPR10MB2888.namprd10.prod.outlook.com (2603:10b6:a03:88::32) MIME-Version: 1.0 Received: from termi.oracle.com (141.143.193.69) by AM0PR06CA0113.eurprd06.prod.outlook.com (2603:10a6:208:ab::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.14 via Frontend Transport; Fri, 10 Sep 2021 14:12:04 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4a2c70fa-98d9-4258-696c-08d97464f7db X-MS-TrafficTypeDiagnostic: BYAPR10MB3624: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: YOXJt2EHSe6Z0yPEO3s+58Tjg20/7xzxrhkxfxKHqL/NBmRYEPzbIsp3bdtDxedzqaa5ZDJcaripMYNSm0dyoiP+uwGwdJDFBP9j3g8aDlkfGwNltzFtehqdy3ZA/MBK4Be2EiyW6D5CHx75q9Mv7Vb5JdIAnnwAUE96Kb+oqJ90fLUBQNn/ZtfwJc42ylRpVIqdZOQPhd2qbKATHCZ5VRRyiB4+FOK16RIuiPhSEoN7WC+ZXO+aQKijkkTtfZ/4Mvfb9wdS7dRX5rnQzafwBVGk0KTNQ4m1O3eqD4qlSzfA1WrI3AnLWeiFqddoCgzexc0WrPSMlwwAYkMIQMlDac9qrdi9MSuFfvAvR5y/aHU50LVXAHj3ah72ADdO//So2zjWur2cPVIL6hVO5AZ4rSrniGX87Fut+c/t3fcs5yw6Pnt1Og/yMTE3WiInPR3T+DFgvyEpWNNrHJr+fetWjG178nXHCuJOGOB9b3qXVR4hK6LalVa6akLARv+8x7bgxbCXNgRY9ztQmsK28tkf8YBLP8HwWORdUyfiqwttYxLI3kPW0g4DAVAd5VOKi7Mo1Aa2eKS6NBG7v5dnYhKPG8Osfs41JceMtYSd80GY8RwiONXS450PEfU1LI6X7EPIthL3QU9UoqUUndm1dDcRhVGV3U6Lr7xeLUB4lu91cwvIgRLaf4xCv0pU0dSaEU7dvymc3T1HfYbvJ6M0x4pEKw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BYAPR10MB2888.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(376002)(346002)(39860400002)(136003)(366004)(396003)(956004)(2906002)(8936002)(83380400001)(6916009)(6666004)(38100700002)(38350700002)(5660300002)(6486002)(86362001)(4326008)(2616005)(478600001)(66556008)(26005)(8676002)(66476007)(316002)(52116002)(7696005)(186003)(36756003)(107886003)(66946007); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?nBVHC7EfWZlqASsqKqtrTW3/QfxEj8/6Qfy/+7pCvBuUsjkTWwb8Jkj3rJWu?= =?us-ascii?Q?z2kV5411QihHsGTzmakaFe8Qoa3QVassv/Xzk0Ifmmvj2L1438qnOPHRn2kD?= =?us-ascii?Q?uKxv33CCIqqgGxyCXJB+N0HLFz2EcmgbO+3Jjj6Fd+Pldk2xaYugYWgPMiHM?= =?us-ascii?Q?JUeabHGQaiVylWnv8cBNYiJBycKHXl7IzMLRRVS6e9mjdcJ4Uxfks5rKTxDo?= =?us-ascii?Q?dJlu6XiR0BseAplWUnX32dK7g72pH4n3f5b4LajrG6DunuPzaW+v6K198YO4?= =?us-ascii?Q?JawMy5dgkEUUg+K1eqdbLHqWnj8sqT1WwYu55dUB1Kv1XHURK+dFgfbntllb?= =?us-ascii?Q?88TVTf+pCTdIA0oK1MkAaoX5uneQJuz7DmTWvwlrt8AnhU4H2hAw/fw0kNky?= =?us-ascii?Q?CUbCluhnws7W98wxLvKiybOtHdaJZTpo9V3Ric7xIT0fROe+zw1I5gEoye5u?= =?us-ascii?Q?Yi6KDrXZ2c07C8p8zpGS1rxq7IDakEFhBJii+X2hmjf7QJY9lzuLkF13TNu+?= =?us-ascii?Q?e8b/BHZ/VXLB0VKeZCWCDL2/HpsLVX7iBUB01BWrY1PlpJWUcNI2lzA9efsy?= =?us-ascii?Q?OPlp7ipj/CfNe3jZ+Z3kP5wNkxurKJsO8Sqg1g+WBDqswabCNyxLIVYLdpqg?= =?us-ascii?Q?Tqee4/HvXzomDoveY1EXq3i/jHuuCQd+MKiBiz1asE8QT5d/quo5QJI+ty6V?= =?us-ascii?Q?dgQfHtceETZjRBNsrv32yPmrhjWOVMkVV2XOhbz20v3ZW6ERBa7OecpPZpQB?= =?us-ascii?Q?kZK1CspPOIrbJfLNIiPO31ZKYug7OP1UaXlVF4fqiR5sl4SiO1r2bkiZdxsr?= =?us-ascii?Q?VFtnHCzeRrQqQUMto7tOka4rho1kqx2F+4q4CvVC1/16kTjHwGShpOyq2Hus?= =?us-ascii?Q?DUK/Do2vtlzk391YDnAy8sxYZhOya5xH2jtQQJ601BaPFve2/AAl2SaBiWAn?= =?us-ascii?Q?XLFDfAw6JCU8ffj9YOGzABZiXeey+xa3BPINgN+xa6wcjy/4zw3ZQ1tXZvrQ?= =?us-ascii?Q?tITzhMhacQopo3/OCAtSMkYYlWnfMUHcKNn+akickMqshrsl29QcqOy4I/bx?= =?us-ascii?Q?h6O8UL9ZrqMFcTEP0XntZtExUtBNMsZQvhem4kueZN/eR4mBbEC5hTNTM0l3?= =?us-ascii?Q?h0hcdwSlU0d5fhCGPEy7Bq30cbHNuG4fjm23rNgW/UH+wGCL+6ZUWFGKVmEi?= =?us-ascii?Q?H3Rx2DFOgGUF8hGnilCI0tK3dqQtp4/VNKdFLQPhmWjVXFxvND4W7InLyjMs?= =?us-ascii?Q?cPVLBLb4KPe/i7Erzdwy+HcK0H8O7j6dLn4uAoNDRokFxwyp6xBDhN+7F8kY?= =?us-ascii?Q?bagrjkm726hhQfaaPaeLEm4v?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4a2c70fa-98d9-4258-696c-08d97464f7db X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB2888.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Sep 2021 14:12:05.7416 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9gS83VOEQ2jCpxlALYywRWzvjyO0c+d2dNffGePVp8o6ygsUagsp7G1WIcwHlZ3gh1WM7hdwDL1oYtz0CmYw7oCg+vEWwH03yYbaLmpdvIA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB3624 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10102 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0 mlxlogscore=979 bulkscore=0 adultscore=0 malwarescore=0 mlxscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2109030001 definitions=main-2109100081 X-Proofpoint-ORIG-GUID: ji9JEvf6FuMIs-EMwyvQgMr3w4J04PJJ X-Proofpoint-GUID: ji9JEvf6FuMIs-EMwyvQgMr3w4J04PJJ X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, KAM_SHORT, MSGID_FROM_MTA_HEADER, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Sep 2021 14:12:21 -0000 Hi David. > New instructions have been added over time to the eBPF ISA, but > previously there has been no good method to select which version to > target in GCC. > > This patch adds the following options to the BPF backend: > > -mcpu={v1, v2, v3} > Select which version of the eBPF ISA to target. This enables or > disables generation of certain instructions. The default is v3. > > -mjmpext > Enable extra conditional branch instructions. > Enabled for CPU v2 and above. > > -mjmp32 > Enable 32-bit jump/branch instructions. > Enabled for CPU v3 and above. > > -malu32 > Enable 32-bit ALU instructions. > Enabled for CPU v3 and above. > > Negative versions of -mjmpext, -mjmp32, and -malu32 options are also > supported. The series is OK. Thanks! > > David Faust (3): > bpf: add -mcpu and related feature options > bpf testsuite: add tests for new feature options > doc: document BPF -mcpu and related options > > gcc/config/bpf/bpf-opts.h | 7 ++++ > gcc/config/bpf/bpf-protos.h | 1 + > gcc/config/bpf/bpf.c | 41 ++++++++++++++++++++ > gcc/config/bpf/bpf.md | 44 +++++++++++---------- > gcc/config/bpf/bpf.opt | 29 ++++++++++++++ > gcc/doc/invoke.texi | 39 ++++++++++++++++++- > gcc/testsuite/gcc.target/bpf/alu-1.c | 56 +++++++++++++++++++++++++++ > gcc/testsuite/gcc.target/bpf/jmp-1.c | 57 ++++++++++++++++++++++++++++ > 8 files changed, 253 insertions(+), 21 deletions(-) > create mode 100644 gcc/testsuite/gcc.target/bpf/alu-1.c > create mode 100644 gcc/testsuite/gcc.target/bpf/jmp-1.c