From: Thomas Schwinge <thomas@codesourcery.com>
To: Ilya Verbin <iverbin@gmail.com>
Cc: Jakub Jelinek <jakub@redhat.com>, <gcc-patches@gcc.gnu.org>,
Kirill Yukhin <kirill.yukhin@gmail.com>,
Ilya Tocar <tocarip@gmail.com>,
Andrey Turetskiy <andrey.turetskiy@gmail.com>,
Bernd Schmidt <bernds@codesourcery.com>,
Jan Hubicka <hubicka@ucw.cz>, Richard Biener <rguenther@suse.de>
Subject: Re: [PATCH 2/n] OpenMP 4.0 offloading infrastructure: LTO streaming
Date: Tue, 30 Sep 2014 11:40:00 -0000 [thread overview]
Message-ID: <878ul172w5.fsf@schwinge.name> (raw)
In-Reply-To: <20140929173704.GA7526@msticlxl57.ims.intel.com>
[-- Attachment #1: Type: text/plain, Size: 2826 bytes --]
Hi!
As just discussed for the libgcc changes in
<http://news.gmane.org/find-root.php?message_id=%3C87d2ad73ze.fsf%40schwinge.name%3E>,
just some suggestions regarding the terminology, where I think that the
term »target« might be confusing in comments or symbols' names. That is,
in the following, »target« should possibly be replaced by »offload[ing]«
or similar:
On Mon, 29 Sep 2014 21:37:04 +0400, Ilya Verbin <iverbin@gmail.com> wrote:
> --- a/gcc/lto-cgraph.c
> +++ b/gcc/lto-cgraph.c
> @@ -321,6 +321,11 @@ referenced_from_other_partition_p (symtab_node *node, lto_symtab_encoder_t encod
>
> for (i = 0; node->iterate_referring (i, ref); i++)
> {
> + /* Ignore references from non-target nodes while streaming NODE into
> + offload target section. */
> + if (!ref->referring->need_lto_streaming)
> + continue;
> +
> if (ref->referring->in_other_partition
> || !lto_symtab_encoder_in_partition_p (encoder, ref->referring))
> return true;
> @@ -339,9 +344,16 @@ reachable_from_other_partition_p (struct cgraph_node *node, lto_symtab_encoder_t
> if (node->global.inlined_to)
> return false;
> for (e = node->callers; e; e = e->next_caller)
> - if (e->caller->in_other_partition
> - || !lto_symtab_encoder_in_partition_p (encoder, e->caller))
> - return true;
> + {
> + /* Ignore references from non-target nodes while streaming NODE into
> + offload target section. */
> + if (!e->caller->need_lto_streaming)
> + continue;
> +
> + if (e->caller->in_other_partition
> + || !lto_symtab_encoder_in_partition_p (encoder, e->caller))
> + return true;
> + }
> return false;
> }
> --- a/gcc/lto-section-names.h
> +++ b/gcc/lto-section-names.h
> @@ -25,6 +25,11 @@ along with GCC; see the file COPYING3. If not see
> name for the functions and static_initializers. For other types of
> sections a '.' and the section type are appended. */
> #define LTO_SECTION_NAME_PREFIX ".gnu.lto_"
> +#define OMP_SECTION_NAME_PREFIX ".gnu.target_lto_"
What about:
#define OFFLOAD_SECTION_NAME_PREFIX ".gnu.offload_lto_"
> --- a/gcc/omp-low.c
> +++ b/gcc/omp-low.c
> @@ -8337,6 +8345,11 @@ expand_omp_target (struct omp_region *region)
> push_cfun (child_cfun);
> cgraph_edge::rebuild_edges ();
>
> + /* Prevent IPA from removing child_fn as unreachable, since there are no
> + refs from the parent function to the target side child_fn. */
> + node = cgraph_node::get (child_fn);
> + node->mark_force_output ();
> +
> /* Some EH regions might become dead, see PR34608. If
> pass_cleanup_cfg isn't the first pass to happen with the
> new child, these dead EH edges might cause problems.
Grüße,
Thomas
[-- Attachment #2: Type: application/pgp-signature, Size: 472 bytes --]
next prev parent reply other threads:[~2014-09-30 11:40 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-27 18:17 Ilya Verbin
2014-09-29 1:10 ` Jan Hubicka
2014-09-29 17:37 ` Ilya Verbin
2014-09-30 11:40 ` Thomas Schwinge [this message]
2014-10-01 16:13 ` Ilya Verbin
2014-10-08 8:45 ` Jakub Jelinek
2014-10-08 9:13 ` Jakub Jelinek
2014-10-15 14:28 ` Richard Biener
2014-10-20 11:21 ` Ilya Verbin
2014-10-20 11:26 ` Jakub Jelinek
2014-10-24 14:16 ` Ilya Verbin
2014-10-24 14:29 ` Jakub Jelinek
2014-10-28 19:32 ` Ilya Verbin
2014-11-03 9:24 ` Jakub Jelinek
2014-11-05 12:47 ` Ilya Verbin
2014-11-05 12:50 ` Jakub Jelinek
2014-11-07 14:41 ` Kirill Yukhin
2014-11-12 9:32 ` Richard Biener
2014-11-12 14:11 ` Kirill Yukhin
2014-11-12 14:23 ` Richard Biener
2014-11-12 14:35 ` Kirill Yukhin
2014-11-12 14:41 ` Richard Biener
2014-11-12 17:38 ` Ilya Verbin
2014-11-13 8:51 ` Richard Biener
2015-07-31 15:37 ` Thomas Schwinge
2015-07-31 15:43 ` Ilya Verbin
2015-08-05 8:40 ` Richard Biener
2015-08-05 15:09 ` Ilya Verbin
2015-08-14 9:49 ` Forwarding -foffload=[...] from the driver (compile-time) to libgomp (run-time) (was: [PATCH 2/n] OpenMP 4.0 offloading infrastructure: LTO streaming) Thomas Schwinge
2015-08-14 13:29 ` Ilya Verbin
2015-08-17 13:57 ` Martin Jambor
2015-08-14 17:08 ` Joseph Myers
2015-08-14 21:48 ` Forwarding -foffload=[...] from the driver (compile-time) to libgomp (run-time) Thomas Schwinge
2015-08-15 4:03 ` Joseph Myers
2015-08-18 16:55 ` Thomas Schwinge
2015-08-20 23:38 ` Joseph Myers
2015-08-21 16:13 ` Nathan Sidwell
2015-08-21 16:21 ` Joseph Myers
2015-08-24 18:05 ` Joseph Myers
2015-08-24 22:50 ` Joseph Myers
2015-08-24 23:26 ` Nathan Sidwell
2015-08-25 15:04 ` Joseph Myers
2018-05-20 20:30 ` [og7] " Thomas Schwinge
2015-08-27 20:58 Pass -foffload targets from driver to libgomp at link time Joseph Myers
2015-09-03 14:58 ` Ping " Joseph Myers
2015-09-10 14:01 ` Ping^2 " Joseph Myers
2015-09-10 14:03 ` Bernd Schmidt
2015-09-11 14:29 ` Joseph Myers
2015-09-11 14:48 ` Bernd Schmidt
2015-09-11 15:28 ` Joseph Myers
2015-09-11 15:47 ` Jakub Jelinek
2015-09-11 16:16 ` Joseph Myers
2015-09-28 10:09 ` Thomas Schwinge
2015-09-29 9:48 ` Jakub Jelinek
2015-09-30 16:15 ` Thomas Schwinge
2015-10-19 16:56 ` Forwarding -foffload=[...] from the driver (compile-time) to libgomp (run-time) Thomas Schwinge
2015-10-20 10:03 ` Jakub Jelinek
2015-10-20 10:44 ` Bernd Schmidt
2015-10-20 11:18 ` Thomas Schwinge
2015-10-20 11:49 ` Bernd Schmidt
2015-10-20 12:13 ` Jakub Jelinek
2015-10-20 11:52 ` Jakub Jelinek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878ul172w5.fsf@schwinge.name \
--to=thomas@codesourcery.com \
--cc=andrey.turetskiy@gmail.com \
--cc=bernds@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hubicka@ucw.cz \
--cc=iverbin@gmail.com \
--cc=jakub@redhat.com \
--cc=kirill.yukhin@gmail.com \
--cc=rguenther@suse.de \
--cc=tocarip@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).