From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11226 invoked by alias); 9 Dec 2013 20:11:44 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 11212 invoked by uid 89); 9 Dec 2013 20:11:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 09 Dec 2013 20:11:42 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rB9KBY8w008251 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 9 Dec 2013 15:11:35 -0500 Received: from barimba (ovpn-113-93.phx2.redhat.com [10.3.113.93]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id rB9KBWUv009133 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Mon, 9 Dec 2013 15:11:33 -0500 From: Tom Tromey To: Dodji Seketeli Cc: Jakub Jelinek , GCC Patches , Manuel =?utf-8?B?TMOzcGV6LUliw6HDsWV6?= , Bernd Edlinger Subject: Re: [PATCH] preprocessor/58580 - preprocessor goes OOM with warning for zero literals References: <20131031144309.GR27813@tucnak.zalov.cz> <87y559xz7y.fsf@redhat.com> <20131031173649.GW27813@tucnak.zalov.cz> <87zjpbb5qu.fsf@redhat.com> <20131111142159.GZ27813@tucnak.zalov.cz> <878uwuap4f.fsf@redhat.com> <878uwt63e2.fsf@redhat.com> <20131113081610.GH27813@tucnak.zalov.cz> <87zjp7t73c.fsf@redhat.com> Date: Mon, 09 Dec 2013 20:11:00 -0000 In-Reply-To: <87zjp7t73c.fsf@redhat.com> (Dodji Seketeli's message of "Thu, 14 Nov 2013 15:01:59 +0100") Message-ID: <878uvtg4y3.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-12/txt/msg00887.txt.bz2 >>>>> "Dodji" == Dodji Seketeli writes: Dodji> * include/line-map.h (linemap_get_file_highest_location): Declare Dodji> new function. Dodji> * line-map.c (linemap_get_file_highest_location): Define it. I wasn't sure if this is the patch you were needing review for ... Dodji> +bool linemap_get_file_highest_location (struct line_maps * set, Dodji> + const char *file_name, Dodji> + source_location*LOC); The spacing is slight off -- one too many before "set", one too few before LOC. And LOC presumably shouldn't be uppercase here. Dodji> + const char *fname = set->info_ordinary.maps[i].d.ordinary.to_file; Dodji> + if (fname && !strcmp (fname, file_name)) Other spots in this code use filename_cmp. Otherwise the libcpp bits look ok to me. Tom