From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 37201 invoked by alias); 18 Sep 2018 19:24:35 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 36993 invoked by uid 89); 18 Sep 2018 19:24:22 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-11.4 required=5.0 tests=BAYES_00,GIT_PATCH_2,GIT_PATCH_3,KAM_NUMSUBJECT,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Honza, honza, H*f:sk:d1c04a2, fprofile-use X-HELO: userp2130.oracle.com Received: from userp2130.oracle.com (HELO userp2130.oracle.com) (156.151.31.86) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 18 Sep 2018 19:24:21 +0000 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w8IJNWcG012624; Tue, 18 Sep 2018 19:24:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : references : cc : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=dvQRqN904jU+cUdX6/RM3oaUSqxYnC0+YNTmR3JrCVw=; b=hq2qfCQWK9DZQxp2NISKVnLFTnjmVOTpS8hLgJqh8rG6PMdvKj2MUptlRuUEssheqdDS vdT4skCIzZyCtxT2tGwyD9DPxk8ehAWaDkneCi0hmULWwrnlVjVVKbwotiFR90ePaH7K Rv1cqfgziXi8/SCDbPEpUooZTPr7ZQsQ2qpPdSnM23CD7fG7oYgvbCl26Dl8gezFRCLR +qByvGGPMK1Ho1dK6tJSX5UwGUznCI+ivP2s+3X+JC57M/ghRAkR6/433//KVX0KIm++ On2M8kKGDGIpub2wMnYoyR4gjbyXp63e2sTUvTnfgZXI/murVSnEbzO9gKQ/EVxQOfIV xw== Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by userp2130.oracle.com with ESMTP id 2mgsgtppc2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 18 Sep 2018 19:24:16 +0000 Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userv0021.oracle.com (8.14.4/8.14.4) with ESMTP id w8IJOFqg004807 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 18 Sep 2018 19:24:15 GMT Received: from abhmp0006.oracle.com (abhmp0006.oracle.com [141.146.116.12]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id w8IJOELm021629; Tue, 18 Sep 2018 19:24:14 GMT Received: from [10.159.144.116] (/10.159.144.116) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 18 Sep 2018 12:24:14 -0700 Subject: Re: [PATCH] PR86957 To: Jan Hubicka , =?UTF-8?Q?Martin_Li=c5=a1ka?= References: <6a2ea403-22c3-91f6-f826-29e186f21b91@suse.cz> <159a29c5-8f8b-4194-dbea-1c9bd414db3a@oracle.com> <7ed25f0a-10a8-3eca-c032-29e76054bfb6@suse.cz> <20180917105249.GA49438@kam.mff.cuni.cz> Cc: gcc-patches@gcc.gnu.org From: Indu Bhagat Message-ID: <8792f28a-72c7-b032-65e6-f7c89cfb29e3@oracle.com> Date: Tue, 18 Sep 2018 19:41:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20180917105249.GA49438@kam.mff.cuni.cz> Content-Type: text/plain; charset=iso-8859-2; format=flowed Content-Transfer-Encoding: 8bit X-SW-Source: 2018-09/txt/msg01021.txt.bz2 On 09/17/2018 03:52 AM, Jan Hubicka wrote: >>> On 09/11/2018 02:21 AM, Martin Li¹ka wrote: >>>>> --- a/gcc/common.opt >>>>> +++ b/gcc/common.opt >>>>> @@ -811,6 +811,10 @@ Wcoverage-mismatch >>>>> Common Var(warn_coverage_mismatch) Init(1) Warning >>>>> Warn in case profiles in -fprofile-use do not match. >>>>> >>>>> +Wmissing-profile >>>>> +Common Var(warn_missing_profile) Init(1) Warning >>>>> +Warn in case profiles in -fprofile-use do not exist. >>>> Maybe 'Want about missing profile for a function in -fprofile-use build.' ? >>>> >>> Since, it also warns when feedback file is missing for a compilation unit, the >>> suggested text above will be more restrictive. So I did not change. > Perhaps we want also to have reference from -fprofile-use documentation so users notice > this option. > > Honza Thanks Yes, I had added that in the patch. Following additional text will appear at the end of -fprofile-use : + Additionally, by default, GCC also emits a warning message if +the feedback profiles do not exist (See @option{-Wmissing-profile}).