From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id CB8753858C50 for ; Thu, 31 Mar 2022 07:01:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CB8753858C50 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.cz Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id CA8EC210DB; Thu, 31 Mar 2022 07:01:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1648710111; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ItzZOqvNG2LIIRy0eWzJ7HGFPPOr4VbwsjaCjnhVyQI=; b=0nW0vCEmjVb2wOa2My5/R8Mskmj1jgaZiYF62PtFsQiUI3hpUJs6JfIRjDidqm8tiOwa53 TGXlaNs+6WRHpkWdZqHBZfIpi4z6mf2lhB27wBIkdCGLqF2zYcc2nRLi8t5pkldps6E9S9 UwMxFtNFBexKsy6v12w0grgYa8Ko3Ow= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1648710111; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ItzZOqvNG2LIIRy0eWzJ7HGFPPOr4VbwsjaCjnhVyQI=; b=IfshOQjv1xgHrTKMG2bwCpdxMsOtlBH6y4c6+AaQ8M11PvtFPCAfJbeDgzW6JUiS/bHM0H DstOSt7eMe4E+5Bg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id ACFB7139C2; Thu, 31 Mar 2022 07:01:51 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id zmZtKN9RRWI1VgAAMHmgww (envelope-from ); Thu, 31 Mar 2022 07:01:51 +0000 Message-ID: <879ec827-1d81-dbdc-b978-a366d28eb175@suse.cz> Date: Thu, 31 Mar 2022 09:01:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH] i386: simplify cpu_feature handling Content-Language: en-US From: =?UTF-8?Q?Martin_Li=c5=a1ka?= To: Jakub Jelinek Cc: Stefan Kneifel , gcc-patches@gcc.gnu.org References: <20211214102828.GU2646553@tucnak> <80d628c2-ea0d-c542-b0bb-399d83b7292d@suse.cz> <20211214161219.GX2646553@tucnak> <7d1f146e-b196-a5dd-b4b9-23d4ac68b572@suse.cz> In-Reply-To: <7d1f146e-b196-a5dd-b4b9-23d4ac68b572@suse.cz> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 Mar 2022 07:01:58 -0000 @Jakub: May I install it once stage1 opens? Cheers, Martin On 1/3/22 12:43, Martin Liška wrote: > PING: Jakub? > > On 12/15/21 10:57, Martin Liška wrote: >> On 12/14/21 17:12, Jakub Jelinek wrote: >>> I'd use INT_TYPE_SIZE - 1 instead of 31.  Otherwise LGTM. >> >> Installed with that change, thanks. >> >> Moreover, I'm suggesting a simplification: >> >> The patch removes unneeded loops for cpu_features2 and CONVERT_EXPR >> that can be simplified with NOP_EXPR. >> >> Survives i386.exp tests, may I install the patch after testing or >> is it a stage1 material? >> >> Thanks, >> Martin >