From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id 3D96D3858C60 for ; Thu, 14 Mar 2024 17:17:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3D96D3858C60 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=oracle.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=oracle.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3D96D3858C60 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=205.220.177.32 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1710436624; cv=pass; b=CLtUIdDR2LGPxYuW61YSuaP+bK3lhChAyYEj4HU8Bwt1KUp0RPey087RXTeJ1dyzn1nE2H2CA1ONW52m2FdEQmWCnBeWnxErYUNt9Iv4nFv/e+uvd6x6QhuM92Pqpgu26Ihnl29sUOpxBilKQFCvXQKmIBcLj5GQvawGKK42cKc= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1710436624; c=relaxed/simple; bh=h14TWgK7glK9p2227JeLsEgWK3W+4x6irnjNLyCNx1A=; h=DKIM-Signature:DKIM-Signature:From:To:Subject:Date:Message-ID: MIME-Version; b=mVQozc4kBv3Xfwl2VcvK1+b0eYemrnR1q97JpCgPGU7Ur36cpni6fuKTMz42I+0GH2qcvhHzP0rPPr2Y87jMu1JaJOhuHl9ep0rM+IubIynbBEYASPVOj8seMEYEMJ3lpMVQ+k0iF2PpOnSExEUMrDs+rgZXD0jWFZsYFJCPpsU= ARC-Authentication-Results: i=2; server2.sourceware.org Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 42ECMAx4009526 for ; Thu, 14 Mar 2024 17:17:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : in-reply-to : references : date : message-id : content-type : mime-version; s=corp-2023-11-20; bh=jVFhJeeZbNH500mGUBibKctaIwPlVV+I7DFf+jpzIzw=; b=kdXKEnsqYAsjeGn3dChaIO8vWWDDOrpW1/6y2KvaP/UfcWQlqS5+rl7TeljFEcT7Hw93 iFHCTOKPZUT6Ptkj/YeUh3fhNjZbEPFllUMOB+RX6XFwMJ+B7ypqBT/ks7o87MN0tHhF v7BC9L4lpnznt/R7k/VqFFWeLO3zYYSOPgllwESfCqoa0VosInwT7nr6lMkHJmwZz2Xn rKCqIXB2Kmi7DUHjQgD4MQLopHbSWkESGAyKMdRygVvezE1iYda5cdmdXZm6+GX5Bc3E ER9GwUYex/OKZamX3+BfHnk+VQKegSBbZToqAI+z6PaLzvirCRyp0RUHQ1WQEthnS0Mm pw== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3wv0ac0ua1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 14 Mar 2024 17:17:01 +0000 Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 42EGI1Cq033783 for ; Thu, 14 Mar 2024 17:17:00 GMT Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11lp2169.outbound.protection.outlook.com [104.47.57.169]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3wre7ae8vt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 14 Mar 2024 17:17:00 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=G2671IoAeHEoHOB9i4+wGPBtYHuWrAq+YqU3jF/+qwBQniKKkw82gn7IdNOquwXHFRn/UDxRPNTFLMQi/icTXXFGbm5fxkgHkyFA9MHMRuTImXZk82kicG2cxA1A7DR37kVT7lr0tt/oQp4brKqkMhfxr5WWuEY/7dXL7FdWVp+uAD0mcMcA8eK1GUP3S9zzcr7RovYtLtM2ahYRyTPMli/kjsVqp9rkCNGWpCgFU1OZmrLxmcJsKnyfQVgpSB/YK6A47SDE0f+yjzn81HvDbfg4FsQnBopTKDIxuiSnVB+gMubSfR0XGlT6DUK47eareJnr9XDv4sob6sSIDQgHTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jVFhJeeZbNH500mGUBibKctaIwPlVV+I7DFf+jpzIzw=; b=WRbY6lmgRlJyW696SUySdLrOnCPwrNHRA6FeceY5yyFk2hADZfNGeqnneTnQHrrFM16bOUadjtveO82PffKayGk4MV0Hi4oiy1mHbm6D6vrf7I+x+41kgUIc4ITpb2OdICnFgpVIo4noPlQAOGVXWIdW6wgBxuQ3qXiZfKXQKcCLeI+K+h1LPVnZaNLAA0vCqoQzcAjSPsu4iixcUB4gs7cCq4llwJnk3zkfmC5qf/ceslV6Pp16aNtgJx7rcTq4Tz2K2l5+n4aB3ypadiTXn4I9RB4xHi+2/PJIHVN/9IX7zWGO0owi5i7OYhGCVDQVR3E6YVaae6uU1HM0yuS7Kg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jVFhJeeZbNH500mGUBibKctaIwPlVV+I7DFf+jpzIzw=; b=cxjwKhULRcgOZYzKXczivuqWKs8N5bO60v7al9FWDzEfJQmKzI45oeTS/TjugJBfBokszuam5rImyh3BSCvxCemyZLBc+7RUlI0wl+9UQIBmocb2FZtVLUjhcCWIgknr1NpTRbKpb6dX39vFgUBaQ0lirV11VZBWXKz6NxsxS5o= Received: from DM6PR10MB3113.namprd10.prod.outlook.com (2603:10b6:5:1a7::12) by SA1PR10MB6415.namprd10.prod.outlook.com (2603:10b6:806:25a::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7362.36; Thu, 14 Mar 2024 17:16:58 +0000 Received: from DM6PR10MB3113.namprd10.prod.outlook.com ([fe80::c4d5:ea6c:712c:f796]) by DM6PR10MB3113.namprd10.prod.outlook.com ([fe80::c4d5:ea6c:712c:f796%4]) with mapi id 15.20.7386.020; Thu, 14 Mar 2024 17:16:58 +0000 From: "Jose E. Marchesi" To: David Faust Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH] bpf: define INT8_TYPE as signed char In-Reply-To: <20240314162355.22965-1-david.faust@oracle.com> (David Faust's message of "Thu, 14 Mar 2024 09:23:55 -0700") References: <20240314162355.22965-1-david.faust@oracle.com> Date: Thu, 14 Mar 2024 18:16:37 +0100 Message-ID: <87a5n0wx6y.fsf@oracle.com> User-Agent: Gnus/5.13 (Gnus v5.13) Content-Type: text/plain X-ClientProxiedBy: LO2P123CA0043.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600::31) To DM6PR10MB3113.namprd10.prod.outlook.com (2603:10b6:5:1a7::12) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR10MB3113:EE_|SA1PR10MB6415:EE_ X-MS-Office365-Filtering-Correlation-Id: 5bb9c620-4c69-4fd1-d14f-08dc444a8df3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5Sx3bPWXIK6srd1lbOWE+qHfxuCeb1BQk0IRyQPm1TOTDydqZnBDCUgo63KbKIejjfqCMcfAbmKTXpnNsJzBhXoUPozgpwxPaEigQRkLI3EDjNUnRb5urAeOP0/AbPhy2ApmHOkmDwW2o0dTEcRgKd/x9W74fnCMg4/3YJOdEd0apZwj7pK4dRNfkHrdrjHOGwGFqoIe94toA+dmMGCCXrq7krzFbCOKxUFB6aEAUtsBKFfFnwTe55Dk2QhC2DEnlZ30BLko4uyCv6c8PPBgXBQUYlSwrKN9ZcNDbwwE11Hhk07HN2fMelUXFch3vKU+MrDeYbmhyTq/qRz0Bl+pZaIeCfqjIchiV9LKMur48QAyDB5CdRzMJdkFsE03R08FU4UashGzz7d5afyb0xd3GbxSUFDUaaHJvgYy8/TErNJBRGlap4rlPHh018kVrfbjWlgwqCbDjYsO3/R4+X3pmbt46p80baxcDy/Z+wYfHmuRrlJmS/6SCzAbh8bSToqQWWvR/YqA3lSVZY7SpS5i2FU+sNZNqRetGy+2t8MfTkg1Q65FcCFMYCttyuyuJjfdN5WV2vwfuVHPz61tbFjbFETVqltxcodJNvdBD9MoYLonihoPKFYRiiRSmY/ErXtbmVHCfbOJTDwJBcVvcCPSiTeYfZXKNGi6g1JdKnkbssc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR10MB3113.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(1800799015)(376005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?+uQZWIDLth3bkGkJ3suyy3J5kJEXGmf8UvlnmUJH0eKgNXUYukMDdqdsKYdf?= =?us-ascii?Q?9MUbnpP6kBEpWzZKYpPN3DhQJoKb+JePiE9WrD17iCHtjrNbIT6bzPWqF9+s?= =?us-ascii?Q?dzAZUi72VIyePsk9Atu2xHOoFkv7llDg1aEkOu1UrHnWuMAfLaNCidmWFl+8?= =?us-ascii?Q?kwwMEZF49EwtLuHHu/DIzQZvBKqHNx9CWjFAsISgBkLNjXbFGTAgWnqd3Ltm?= =?us-ascii?Q?KWLNZ+5HnhcgH9emBgUBXq1MRhRF2Tmo9CET3MEzULu+aiDRyLqvCDD57ZYk?= =?us-ascii?Q?SKsVC+kVbaS+thtnf3L9Rap8yWzFLiFxfmeZapwtDRKJ43aBU37pQwMYy7wZ?= =?us-ascii?Q?AgLMFKp4PS9Vqm2aMGglzamKUa8Pcewq6bNuXKnNSKqR3+42pcq4Dq08BI0Y?= =?us-ascii?Q?e4naJMbuMZASbo2nNof0Mix8/+Him7zgQBZDlLvdpF4CjwDhbx+mIX3L6oGn?= =?us-ascii?Q?OPf9WjJkI1AmPhiLxxT9V9DzxSzA8Bt2MnwCJFUgApbsc9V8R0svmmbZU8uN?= =?us-ascii?Q?m3/aimOmBBPs4YKceetvY7vwUn9/8LX1M9P1gsmBiY0CGeMAj1dc85k0XNke?= =?us-ascii?Q?n35P6J/cvAq17MyL4AzycqR4b5PdRLUKNbiDJhuHvmFYVCrYZasHaCs/SU1P?= =?us-ascii?Q?qWmpMUT/Ypjvr3SJihrWkfW3LiW7j+7mHOoq5yor6fpP9TMI01kfK0ite0+t?= =?us-ascii?Q?Lic721aT6Q3lNg5nH0HJhz962MZ+eObOoxUU282Li5o6Sr6lO/6mleO++6PQ?= =?us-ascii?Q?HdYMlgIpJmgSQ5+oislxyLxxwIMuU6lpcglO5ohjpb9PxoVUguQAK3CnzPpf?= =?us-ascii?Q?g+KgBtBVHfI/Rw3R+775Si5r8dHmyWMISJVtWXsGf1Uii0vNpyXmk4qjDYO5?= =?us-ascii?Q?DVFy3WCGT5chX5+mSC8plkvlKtRmAArt+btLJCthlN5kxUXphYLabHug+osg?= =?us-ascii?Q?uFxRsXIT72axS4zHnUdTG5N8GQDJk92AT3m9eqqouCaMrVh+BgPnN0OHM1w8?= =?us-ascii?Q?pup7e3g1Taw3+HvFaVMZRvsTYFcE57iSwqZiEgjzWQ6XP1TYWk4dkw56GKjd?= =?us-ascii?Q?6k0IwoNDHHbKlxOOJLeJYL229h1z1Vajs/4MRZOzpJvm9s9733SrovwwVx46?= =?us-ascii?Q?7N/5ng7iu0Tu1qc1EVrYOmRCBVqzImg4seEwgkcCFy3iJ/GnpZtzftOaMNJN?= =?us-ascii?Q?7eunmcnIXeeQ5j3nTX+YJjQTbqXgHeKbE1H+vtm32cGNdoH7OO8BcG7lc57X?= =?us-ascii?Q?IAtFuIz6RSPcHEpBlQNORPSO7HZC90ilr24YrbVA3K5C4GNaOgEOxmh9OJ4L?= =?us-ascii?Q?QhA9KK4NimfQtA7eh/iqGz6FlW41oM7LL1UWLVBbPD5bCAk+dw4zTxFCMaYE?= =?us-ascii?Q?czXL05U2vHuGD4tl6KkQAZhjK6VvOokeYkZy9G2W1A3nRcdqxR2zf88MuVFx?= =?us-ascii?Q?gu8r4UdpyWRQRsSX1ShgRlXH2rnAT3o+pfbRClN1fI02Ichml+GoibWtMht0?= =?us-ascii?Q?pqRADh9KeUx7lzSVDOn6vOV2ZcpoNDgVMDVLA7nDvLxJv6BGy+HcDu8Yqnpm?= =?us-ascii?Q?tkD81M4wN1MKy48b5/3r1BMrQjPQgdDLXQSIyEkHVm3G6TWLAAhCFbEWPoDD?= =?us-ascii?Q?dQ=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: DXFjuagXOAq2e/ouGwFJ3nkx8N+X9AO7Yoli358GI3GwUGcVJz5qQZt/XkYXmEqXFsqwPzkUZIAgrw9cPKqHE8n96OLF2Mtc9+ZUY9JsnSXtuw++M0+QrzVsUhpgzufPSaa09yNm+uQjON3RuyZk9p1r2AHl1rABAfLLL9L/qGcsUYGmZryJjvLS/58hDh8b7Qchcs3siDuULA3R3oF517YUws+2IpvnjBjYKHeZaBF8HcVQQnYcqLiDjDU9lbJ5kx189jzSUvnjQDomCLApKt9LqATXaT2LHJk/LNJgonMR+RC/AYeumkVdYeDm4hhMvD21D192df+jDqG2Tc6ZmgrR/XEPTvV1ZQZ1RTv3SunLMeEXK+OGhPGIix2KJI/2Jy0vl1HCUxX7BmGi/oS62Etoli+dbckORtBhhIaTIct+hqGTiis0YKX6vK3xR7IUeifadzh32hSPG8gjqWSYR0Lez0zv6AzjB4cVHzhMulyKxKbeK4KMJvXLDEA7dHS6sdpsuPz6X4UR8T0WFuEWMuniihbQtUKAQcOfD4apnU/RiEoJc/DkN6U+g9ajdTPe2XQcNadLYRKJOOZFYhbrMp+Vfl5+1+8Brvchnou6yKM= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5bb9c620-4c69-4fd1-d14f-08dc444a8df3 X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB3113.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2024 17:16:58.1762 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: VPujswcc/tsG2jAVXMTyWN83/CvVw5o0tigKF2JHh/Fqz0BbVwRUVo9tetLWw1TOZVRZHd+KCUGIjC8EcVUeYVtqWt0vFIVEg1dy79/rUvQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR10MB6415 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-03-14_13,2024-03-13_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 phishscore=0 mlxlogscore=999 malwarescore=0 mlxscore=0 bulkscore=0 spamscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000 definitions=main-2403140131 X-Proofpoint-GUID: XSwITbrTO9K4CQeK4ZfbS0UT_U__wgfC X-Proofpoint-ORIG-GUID: XSwITbrTO9K4CQeK4ZfbS0UT_U__wgfC X-Spam-Status: No, score=-12.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi David. > Change the BPF backend to define INT8_TYPE with an explicit sign, rather > than a plain char. This is in line with other targets and removes the > risk of int8_t being affected by the signedness of the plain char type > of the host system. OK. I would add to the commit message that the motivation for this change is that even if `char' is defined to be signed in BPF targets, some BPF programs use the (mal)practice of including internal libc headers indirectly via kernel headers and that may trigger compilation errors regarding redefinitions of types. Thanks for the patch! > > Tested on x86_64-linux-gnu host for bpf-unknown-none. > Sanity checked compiling Linux kernel BPF selftests. > > gcc/ > > * config/bpf/bpf.h (INT8_TYPE): Change to signed char. > --- > gcc/config/bpf/bpf.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gcc/config/bpf/bpf.h b/gcc/config/bpf/bpf.h > index f107a5a4c34..3cc5daa1b58 100644 > --- a/gcc/config/bpf/bpf.h > +++ b/gcc/config/bpf/bpf.h > @@ -99,7 +99,7 @@ > > #define SIG_ATOMIC_TYPE "char" > > -#define INT8_TYPE "char" > +#define INT8_TYPE "signed char" > #define INT16_TYPE "short int" > #define INT32_TYPE "int" > #define INT64_TYPE "long int"