From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout-p-103.mailbox.org (mout-p-103.mailbox.org [80.241.56.161]) by sourceware.org (Postfix) with ESMTPS id B4A4B3858D35 for ; Fri, 17 Nov 2023 15:17:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B4A4B3858D35 Authentication-Results: sourceware.org; dmarc=pass (p=reject dis=none) header.from=aarsen.me Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=aarsen.me ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B4A4B3858D35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=80.241.56.161 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700234256; cv=none; b=pmMozssGik5Xl3kZOoJkOuDPw4B7y24zjcQ3B81oVQ3G4tDsBXhRneOCNiw6i0lmrSNLHeYQJ3RWuiERuWYFu2CLv1D9SlSp/7aoL93CPQWh0CyN+wcAc6zkFE3SkaymLZr8ypkFbf8FEMyRJfmaqBVwC6iDDqvlEyjnfSVO1wc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700234256; c=relaxed/simple; bh=5HjQAdzcE9s7i+0q3vPYU9rxkRSqbsL/cVxyiKmJgN8=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=sE/dMa/lzzuvW4KhgIPPifcoW3votHDGAtFJ5VwjKSD4Ta+t6RnR6z/cSVApE6Jz8uYZ/wV1jm7G31cyGcdLFBziQTBMj2axsxAst9+aZyglTn2j88gzS5RgIpbBRzgxypY9yr1nEWxAcXv1BDsLChl1qr0KMx0bXjlucY86Spg= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from smtp102.mailbox.org (smtp102.mailbox.org [10.196.197.102]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-103.mailbox.org (Postfix) with ESMTPS id 4SX0rV6tzhz9sT7; Fri, 17 Nov 2023 16:17:30 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aarsen.me; s=MBO0001; t=1700234250; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gSSGQ5xUBy1ZcPsagHHC7XseOgbiMg6LbPqrGrQIutQ=; b=ay5iD09lpaf5PVkpQCuXwmhQWX4qZibOY2caUJLDLMm6fSRS31Ck6XMJoiHyb+D9+bY3xr iTj0NQxElGbcUiyigHiadG8ZzpAu8ajF57TmDDkNQnhSXAJ9T4E4E+1WG87KhKTrjWdCZp jvGKeRVbMIgSYl3RuvupOGRPMVXtwMhZNzfgnPyVXpTwYyvIjSEPT7Ga2X4UIOEksEjhAp lZXRnmCGofsp4KgGQXRYrRxneYhoEQPjrfR3YQfWvgrciQMAX5mRUq8q8eVqOWb4P52q2w d5OxaQOkBkHeMyNdP5v+uiC5FEVs9fCNue22zdlULXgFUnqvNIGnyBzorIeXKw== References: <86o7fwhr03.fsf@aarsen.me> <8634x7hza7.fsf@aarsen.me> <86il61fscr.fsf@aarsen.me> <861qcpbdt2.fsf@aarsen.me> <86cyw99w4j.fsf@aarsen.me> <867cmh8g6i.fsf@aarsen.me> <86o7fs6a3j.fsf@aarsen.me> From: Arsen =?utf-8?Q?Arsenovi=C4=87?= To: David Edelsohn Cc: Richard Biener , Bruno Haible , gcc-patches@gcc.gnu.org Subject: Re: [PATCH v3 0/2] Replace intl/ with out-of-tree GNU gettext Date: Fri, 17 Nov 2023 16:16:56 +0100 In-reply-to: Message-ID: <87a5rc2yuv.fsf@aarsen.me> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_INFOUSMEBIZ,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable David Edelsohn writes: > On Fri, Nov 17, 2023 at 3:46=E2=80=AFAM Arsen Arsenovi=C4=87 wrote: > >> >> David Edelsohn writes: >> >> > On Thu, Nov 16, 2023 at 5:52=E2=80=AFPM Arsen Arsenovi=C4=87 wrote: >> > >> > [snip] >> >> Sure, but my patch does insert --disable-shared: >> >> >> >> --8<---------------cut here---------------start------------->8--- >> >> host_modules=3D { module=3D gettext; bootstrap=3Dtrue; no_install=3Dt= rue; >> >> module_srcdir=3D "gettext/gettext-runtime"; >> >> // We always build gettext with pic, because some >> packages >> >> (e.g. gdbserver) >> >> // need it in some configuratons, which is determined >> via >> >> nontrivial tests. >> >> // Always enabling pic seems to make sense for someth= ing >> >> tied to >> >> // user-facing output. >> >> extra_configure_flags=3D'--disable-shared --disable-j= ava >> >> --disable-csharp --with-pic'; >> >> lib_path=3Dintl/.libs; }; >> >> --8<---------------cut here---------------end--------------->8--- >> >> >> >> ... and it is applied: >> >> >> >> --8<---------------cut here---------------start------------->8--- >> >> -bash-5.1$ ./config.status --config >> >> --srcdir=3D../../gcc/gettext/gettext-runtime --cache-file=3D./config.= cache >> >> --disable-werror --with-gmp=3D/opt/cfarm >> >> --with-libiconv-prefix=3D/opt/cfarm --disable-libstdcxx-pch >> >> --with-included-gettext --program-transform-name=3Ds,y,y, >> >> --disable-option-checking --build=3Dpowerpc-ibm-aix7.3.1.0 >> >> --host=3Dpowerpc-ibm-aix7.3.1.0 --target=3Dpowerpc-ibm-aix7.3.1.0 >> >> --disable-intermodule --enable-checking=3Dyes,types,extra >> >> --disable-coverage --enable-languages=3Dc,c++ >> >> --disable-build-format-warnings --disable-shared --disable-java >> >> --disable-csharp --with-pic build_alias=3Dpowerpc-ibm-aix7.3.1.0 >> >> host_alias=3Dpowerpc-ibm-aix7.3.1.0 target_alias=3Dpowerpc-ibm-aix7= .3.1.0 >> >> CC=3Dgcc CFLAGS=3D-g 'LDFLAGS=3D-static-libstdc++ -static-libgcc >> >> -Wl,-bbigtoc' 'CXX=3Dg++ -std=3Dc++11' CXXFLAGS=3D-g >> >> --8<---------------cut here---------------end--------------->8--- >> >> >> >> I'm unsure how to tell what the produced binaries are w.r.t static or >> >> shared, but I only see .o files inside intl/.libs/libintl.a, while I = see >> >> a .so.1 in (e.g.) /lib/libz.a, hinting at it not being shared (?) >> >> >> > >> > An AIX shared library created by libtool will look like >> > libfoo.a[libfoo.so.N], where N is the package major version number. >> > Normally with one file. >> >> > An AIX static library will look like libfoo.a[a.o, b.o, c.o] >> > with multiple object files. >> > >> > An AIX archive can contain a combination of shared objects and >> > normal object files. >> > >> > AIX normally uses the convention shr.o or shr_64.o for the name >> > of the shared object file. Hint, hint, an AIX archive can contain >> > both 32 bit and 64 bit object files or shared objects. >> > >> > I don't know why the gettext build system would create >> > /home/arsen/build/./gettext/intl/.libs/libintl.a(libintl.so.8) >> > if --disable-shared was requested. That clearly is using the >> > naming of a libtool AIX shared object and failing due to >> > the missing shared object. Although in this case, the problem >> > seems to be the shared library load path. AIX uses LIBPATH, >> > not LD_LIBRARY_PATH. >> >> It doesn't create libintl.a with a libintl.so.8 inside of it. The >> libintl.a contains a bunch of objects, as I'd expect of a static >> library: >> >> --8<---------------cut here---------------start------------->8--- >> -bash-5.1$ ar -t gettext/intl/.libs/libintl.a | grep libintl >> -bash-5.1$ ar -t gettext/intl/.libs/libintl.a >> bindtextdom.o >> dcgettext.o >> ... >> --8<---------------cut here---------------end--------------->8--- >> >> >> > Also, for me, the out of tree path was >> > >> > gettext/gettext-runtime/intl/.libs >> > >> > Is your search path missing a level? >> >> No, the above is generated by the GCC build system and builds >> gettext-runtime directly (per Brunos recommendation a while ago) as it >> is replacing intl/ of similar functionality. >> >> I'm currently building GCC with libintl with the threads hack you >> mentioned applied (as I got undefined references to the pthread >> functions you discovered). I suspect that, bar this issue (which, IIUC, >> Bruno will fix in a new release?) the patch above will fix the issues >> you've encountered on AIX (note that if you want to use gettext in-tree, >> you'd still have to fetch gettext into the tree). >> >> Maybe we should provide a download-prerequisite-y script that skips >> everything but GNU gettext, to retain same behavior? >> >> Have a lovely day. >> > > I'm concerned that the gettext fixes are working around AIX support for > libpthread.a as opposed to making --disable-threads function. Indeed, my intention is to --disable-threads. The goal of the workaround is simply to test the patch I wrote. > --enabled-threads=3Disoc use of mtx_* is a workaround, but it's still not > allowing users to truly disable threads. > > Thanks, David =2D-=20 Arsen Arsenovi=C4=87 --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIYEARYKAC4WIQT+4rPRE/wAoxYtYGFSwpQwHqLEkwUCZVeECBAcYXJzZW5AYWFy c2VuLm1lAAoJEFLClDAeosSTKcoBAOfbkiIxBfR2nUCR4FgiRjrX7jsUFPhYbh7Z MzqV25jWAQCWsJFtQfy74jQPf5KduoQURLQW1wj3oSfp65hPs2t8CA== =9JrR -----END PGP SIGNATURE----- --=-=-=--